* Add linting step for extraneous elements in SVGs
... such as a trailing "s" in the Quasar SVG (#3221)
* Remove trailing space from BMC Software icon
* Improve error message for violations
Co-authored-by: Peter Noble <PeterShaggyNoble@users.noreply.github.com>
Co-authored-by: Lucas Becker <runxel@users.noreply.github.com>
* Add Alexa ranks to GitHub Templates
* Add trailing newline to icon_request.md
* Remove excess space from icon_request.md
* Updates from review
* Remove choice between issue & rank
* Fix typo in issue template
Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
* Improve wording in issue template and close last comment
Co-authored-by: Lucas Becker <runxel@users.noreply.github.com>
Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
* added Sennheiser to data
* added icon
* removed class from Sennheiser logo
* Update _data/simple-icons.json
Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
* Added Land Rover Icon
* Whitespace fix
Run svgo again to fix the overzealous whitespace consumption of svgomg.
Co-authored-by: Lucas Becker <runxel@users.noreply.github.com>
* Add linter to check svg path dimensions
Float precision is set at 3 which is the default for svgo in .svgo.yml;
precision can be raised over time.
This adds an ignore file with the current paths of non-conforming icons.
This also changes the name of the icon title linter as well so it reads
more nicely than "custom".
* Update CONTRIBUTING GUIDELINES
Add a note on visual imperfections and viewbox problems due to
optimizing.
Co-authored-by: Eric Cornelisesn <ericornelissen@gmail.com>
Co-authored-by: Peter Noble <PeterShaggyNoble@users.noreply.github.com>
* Add a SVGO Docker image
* Update Dockerfile and .dockerignore
Update the Dockerfile to create a docker image that is generally
applicable to run NPM commands, including but not limited to:
- npm run test
- npm run svgo
- npm run lint
Also updated the .dockerignore file to exclude:
- The node_modules folder
- Common Jekyll folders/files
- Files generated by the build script
The reason for choosing the alpine docker image (rather than a node
docker image) is that the CLI out of the box is better.
* Add section on using Docker to Contributing Guidelines
* Readd entrypoint for SVGO optimization to Dockerfile
Update the Dockerfile based on the original work in
32993385da by re-adding an ENTRYPOINT to
the Dockerfile. This ENTRYPOINT makes it extremely easy to spin up a
quick Docker container to optimize a single SVG (much simpler than my
copy-in -> optimize -> copy-out approach).
The description for how to use the Docker image to run other NPM scripts
has been updated accordingly. The provided command overrides the above
ENTRYPOINT by simple starting a shell so the user can interact with the
project.
Co-authored-by: Eric Cornelisesn <ericornelissen@gmail.com>
