beenull/simple-icons
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

prefer similarweb for website ranks (#7154)

Browse source 
* prefer similarweb for website ranks

* Update icon_request.yml

* Update icon_request.yml

* update CONTRIBUTING.md

* format yaml

* update pull request template

* update example

* fix formatting errors
This commit is contained in:
Sachin Raja 2022-02-21 12:29:48 -08:00 committed by GitHub
parent af7cd92f00
commit d6612085c4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
.github/ISSUE_TEMPLATE/icon_request.yml vendored
View file

@ -42,14 +42,18 @@ body:
attributes: attributes:
label: Popularity Metric label: Popularity Metric
description: >- description: >-
Provide either an [Alexa rank] or the number of GitHub stars. If these are not Provide either a [Similarweb rank] or the number of GitHub stars. If
available or too low you can still open the issue. In this case, please Similarweb does not have a rank for your brand or the rank fails to meet our
provide any information regarding the brand's popularity you think is requirements, we can also accept an [Alexa rank] as an alternative. If these
are not available or too low you can still open the issue. In this case,
please provide any information regarding the brand's popularity you think is
relevant. relevant.
[alexa rank]: https://www.alexa.com/siteinfo [Similarweb rank]: https://www.similarweb.com
placeholder: 'Example: The Alexa rank is 249,089. See https://www.alexa.com/siteinfo/simpleicons.org'
[Alexa rank]: https://www.alexa.com/siteinfo
placeholder: 'Example: The Similarweb rank is 261,758. See https://www.similarweb.com/website/simpleicons.org'
validations: validations:
required: true required: true

4
.github/PULL_REQUEST_TEMPLATE.md vendored
View file

@ -7,8 +7,8 @@ https://petershaggynoble.github.io/SI-Sandbox/preview/
--> -->
**Issue:** **Issue:**
**Alexa rank:** **Similarweb rank:**
<!-- The Alexa rank can be retrieved at https://www.alexa.com/siteinfo/ <!-- The Similarweb rank can be retrieved at https://www.similarweb.com
Please see our contributing guidelines for more details on how we Please see our contributing guidelines for more details on how we
assess a brand's popularity. --> assess a brand's popularity. -->

2
CONTRIBUTING.md
View file

@ -43,7 +43,7 @@ We welcome icon requests. Before you submit a new issue please make sure the ico
* Has not already been requested. If you find an existing issue or pull request for the brand you're looking for then please add a reaction or comment to show your support. * Has not already been requested. If you find an existing issue or pull request for the brand you're looking for then please add a reaction or comment to show your support.
* Is of a _popular_ brand: * Is of a _popular_ brand:
- For websites, the [Alexa rank](https://www.alexa.com/siteinfo) should be less than 500k. - For websites, the [Similarweb rank](https://www.similarweb.com) should be less than 500k.
- Note that for brands that have already been added the threshold for continued inclusion rises to 750k. - Note that for brands that have already been added the threshold for continued inclusion rises to 750k.
- For GitHub projects, the amount of "stars" should be above 5k. - For GitHub projects, the amount of "stars" should be above 5k.
- For anything else, popularity will be judged on a case-by-case basis. - For anything else, popularity will be judged on a case-by-case basis.