From d6612085c479a2910e600856a3e8c927682678b3 Mon Sep 17 00:00:00 2001 From: Sachin Raja Date: Mon, 21 Feb 2022 12:29:48 -0800 Subject: [PATCH] prefer similarweb for website ranks (#7154) * prefer similarweb for website ranks * Update icon_request.yml * Update icon_request.yml * update CONTRIBUTING.md * format yaml * update pull request template * update example * fix formatting errors --- .github/ISSUE_TEMPLATE/icon_request.yml | 14 +++++++++----- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- CONTRIBUTING.md | 2 +- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/icon_request.yml b/.github/ISSUE_TEMPLATE/icon_request.yml index 440fdd666..5bb1c6383 100644 --- a/.github/ISSUE_TEMPLATE/icon_request.yml +++ b/.github/ISSUE_TEMPLATE/icon_request.yml @@ -42,14 +42,18 @@ body: attributes: label: Popularity Metric description: >- - Provide either an [Alexa rank] or the number of GitHub stars. If these are not - available or too low you can still open the issue. In this case, please - provide any information regarding the brand's popularity you think is + Provide either a [Similarweb rank] or the number of GitHub stars. If + Similarweb does not have a rank for your brand or the rank fails to meet our + requirements, we can also accept an [Alexa rank] as an alternative. If these + are not available or too low you can still open the issue. In this case, + please provide any information regarding the brand's popularity you think is relevant. - [alexa rank]: https://www.alexa.com/siteinfo - placeholder: 'Example: The Alexa rank is 249,089. See https://www.alexa.com/siteinfo/simpleicons.org' + [Similarweb rank]: https://www.similarweb.com + + [Alexa rank]: https://www.alexa.com/siteinfo + placeholder: 'Example: The Similarweb rank is 261,758. See https://www.similarweb.com/website/simpleicons.org' validations: required: true diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b42ce3bb1..b6f9420ef 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,8 +7,8 @@ https://petershaggynoble.github.io/SI-Sandbox/preview/ --> **Issue:** -**Alexa rank:** - diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6d4dc3d40..07b36a314 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -43,7 +43,7 @@ We welcome icon requests. Before you submit a new issue please make sure the ico * Has not already been requested. If you find an existing issue or pull request for the brand you're looking for then please add a reaction or comment to show your support. * Is of a _popular_ brand: - - For websites, the [Alexa rank](https://www.alexa.com/siteinfo) should be less than 500k. + - For websites, the [Similarweb rank](https://www.similarweb.com) should be less than 500k. - Note that for brands that have already been added the threshold for continued inclusion rises to 750k. - For GitHub projects, the amount of "stars" should be above 5k. - For anything else, popularity will be judged on a case-by-case basis.