beenull/photoprism
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Videos: Improve code comments in index_mediafile.go #926 #3588 #3559

Browse source 
Signed-off-by: Michael Mayer <michael@photoprism.app>
This commit is contained in:
Michael Mayer 2023-08-18 08:57:22 +02:00
parent 32c0d0ae66
commit 69f15924ab
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
internal/photoprism/index_mediafile.go
View file

@ -648,8 +648,8 @@ func (ind *Index) UserMediaFile(m *MediaFile, o IndexOptions, originalName, phot
}
}
// Set video dimensions from primary file, if necessary.
// See also File.UpdateVideoInfos()
// Sets the video dimensions from the primary image if it could not be determined from the video metadata.
// If there is no primary image yet, File.UpdateVideoInfos() sets the fields in retrospect when there is one.
if file.FileWidth == 0 && primaryFile.FileWidth > 0 {
file.FileWidth = primaryFile.FileWidth
file.FileHeight = primaryFile.FileHeight
@ -657,8 +657,9 @@ func (ind *Index) UserMediaFile(m *MediaFile, o IndexOptions, originalName, phot
file.FilePortrait = primaryFile.FilePortrait
}
// Set video appearance from primary file, if necessary.
// See also File.UpdateVideoInfos()
// Set the appearance of the video from the primary file. In a future version, a still image extracted from the
// video could be used for this purpose if the primary image is not directly derived from the video file,
// e.g. in live photo stacks, see https://github.com/photoprism/photoprism/pull/3588#issuecomment-1683429455
if primaryFile.FileDiff > 0 {
file.FileMainColor = primaryFile.FileMainColor
file.FileColors = primaryFile.FileColors