From 69f15924abf3aacf20c5ea0a7410b77e34aa9d3a Mon Sep 17 00:00:00 2001 From: Michael Mayer Date: Fri, 18 Aug 2023 08:57:22 +0200 Subject: [PATCH] Videos: Improve code comments in index_mediafile.go #926 #3588 #3559 Signed-off-by: Michael Mayer --- internal/photoprism/index_mediafile.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/internal/photoprism/index_mediafile.go b/internal/photoprism/index_mediafile.go index 15208be72..b27059c31 100644 --- a/internal/photoprism/index_mediafile.go +++ b/internal/photoprism/index_mediafile.go @@ -648,8 +648,8 @@ func (ind *Index) UserMediaFile(m *MediaFile, o IndexOptions, originalName, phot } } - // Set video dimensions from primary file, if necessary. - // See also File.UpdateVideoInfos() + // Sets the video dimensions from the primary image if it could not be determined from the video metadata. + // If there is no primary image yet, File.UpdateVideoInfos() sets the fields in retrospect when there is one. if file.FileWidth == 0 && primaryFile.FileWidth > 0 { file.FileWidth = primaryFile.FileWidth file.FileHeight = primaryFile.FileHeight @@ -657,8 +657,9 @@ func (ind *Index) UserMediaFile(m *MediaFile, o IndexOptions, originalName, phot file.FilePortrait = primaryFile.FilePortrait } - // Set video appearance from primary file, if necessary. - // See also File.UpdateVideoInfos() + // Set the appearance of the video from the primary file. In a future version, a still image extracted from the + // video could be used for this purpose if the primary image is not directly derived from the video file, + // e.g. in live photo stacks, see https://github.com/photoprism/photoprism/pull/3588#issuecomment-1683429455 if primaryFile.FileDiff > 0 { file.FileMainColor = primaryFile.FileMainColor file.FileColors = primaryFile.FileColors