Manav Rathi
fb5ae3a2ac
Remove unnecessary check
...
rmdir docs already mention it'll only work on folders
Also tested on macOS with a node shell
> await fs.rmdir("/tmp/foo/bar/baz/quxx.txt")
Uncaught [Error: ENOTDIR: not a directory, rmdir '/tmp/foo/bar/baz/quxx.txt'] {
2024-04-14 17:55:40 +05:30
Manav Rathi
adb37f38e4
Shorten
2024-04-14 10:31:45 +05:30
Manav Rathi
14922b65f8
Inline
2024-04-14 10:28:27 +05:30
Manav Rathi
7438c3301e
Move mkdirIfNeeded into fs
2024-04-14 10:25:28 +05:30
Manav Rathi
0e8678715a
Remove layer
2024-04-14 10:03:16 +05:30
Manav Rathi
3824ebe91a
Remove exportService indirection
2024-04-14 09:57:58 +05:30
Manav Rathi
ea34eebfc9
Remove implicit electron dependency
2024-04-14 09:53:18 +05:30
Manav Rathi
eeb1952585
Use
2024-04-14 09:30:51 +05:30
Manav Rathi
72dd47fa7b
Audit rename
2024-04-14 09:27:52 +05:30
Manav Rathi
b977f982dd
[desktop] Fix export related IPC - Part 2/x ( #1436 )
2024-04-13 21:56:46 +05:30
Manav Rathi
38db03c3a0
Start giving it more power
2024-04-13 21:50:56 +05:30
Manav Rathi
e268b9204e
Inline
2024-04-13 21:46:34 +05:30
Manav Rathi
acd50bb172
Inline
2024-04-13 21:39:36 +05:30
Manav Rathi
28d559bd84
Hoist
2024-04-13 21:35:58 +05:30
Manav Rathi
e87c7ed108
Inline
2024-04-13 21:34:37 +05:30
Manav Rathi
67a81f8d86
Dedup
2024-04-13 21:31:36 +05:30
Manav Rathi
30f147ec5b
Update jsdoc
2024-04-13 21:26:00 +05:30
Manav Rathi
6829d0bf15
Remove unused
2024-04-13 21:24:52 +05:30
Manav Rathi
d03b265eb4
Captialize
...
We've been capitalizing the name at places where we can. This name is only used
when creating new exports, and shouldn't effect existing export, so it is safe
to change.
2024-04-13 21:21:48 +05:30
Manav Rathi
297ca09535
Refactor and extract
2024-04-13 21:20:20 +05:30
Manav Rathi
82bbb1c6dd
Cleanup and document
2024-04-13 21:06:47 +05:30
Manav Rathi
4fbfbf0aa0
Cleanup
2024-04-13 20:53:35 +05:30
Manav Rathi
56d04066ea
sfn
2024-04-13 20:38:29 +05:30
Manav Rathi
7838f7484d
Make explicit
2024-04-13 20:29:17 +05:30
Manav Rathi
a6887e3037
[web] Add ESLint to enforce HMR how vite likes it ( #1433 )
...
Configuration changes taken from the vite starter (react-ts).
From the [vite
docs](https://github.com/vitejs/vite-plugin-react-swc?tab=readme-ov-file#consistent-components-exports )
> For React refresh to work correctly, your file should only export
React components.
>
> If an incompatible change in exports is found, the module will be
invalidated. To make it easier to export simple constants alongside your
component the module is only invalidated when their value changes.
While we're not currently using vite for our main apps, it would be
worthwhile to write code in a way that a future migration to it is
painless if needed.
About the what and the why, the Gatsby docs are illuminating:
https://www.gatsbyjs.com/docs/reference/local-development/fast-refresh/#how-it-works
Some other refs:
- https://github.com/ArnaudBarre/eslint-plugin-react-refresh
-
https://github.com/vitejs/vite/discussions/4577#discussioncomment-1161007
- https://github.com/vitejs/vite-plugin-react/issues/34
2024-04-13 18:57:24 +05:30
Manav Rathi
c7757cb08e
Prune more stale overrides
2024-04-13 18:54:15 +05:30
Manav Rathi
ce642e12c1
Remove stale disables
2024-04-13 18:50:12 +05:30
Manav Rathi
e07559c8da
Fix oopsie
2024-04-13 18:41:47 +05:30
Manav Rathi
64231c73f1
[web] Add ESLint to enforce HMR how vite likes it
...
Configuration changes taken from the vite starter (react-ts).
From the vite docs (https://github.com/vitejs/vite-plugin-react-swc?tab=readme-ov-file#consistent-components-exports )
> For React refresh to work correctly, your file should only export React components.
>
> If an incompatible change in exports is found, the module will be invalidated.
> To make it easier to export simple constants alongside your component the module
> is only invalidated when their value changes.
While we're not currently using vite for our main apps, it would be worthwhile
to write code in a way that a future migration to it is painless if needed.
About the what and the why, the Gatsby docs are illuminating:
https://www.gatsbyjs.com/docs/reference/local-development/fast-refresh/#how-it-works
Some other refs:
- https://github.com/ArnaudBarre/eslint-plugin-react-refresh
- https://github.com/vitejs/vite/discussions/4577#discussioncomment-1161007
- https://github.com/vitejs/vite-plugin-react/issues/34
2024-04-13 18:38:24 +05:30
Manav Rathi
27fb43837b
[desktop] Fix export related IPC - Part 1/x ( #1432 )
2024-04-13 18:31:36 +05:30
Manav Rathi
4f764dc77c
Consolidate constants
2024-04-13 18:27:40 +05:30
Manav Rathi
63a2ca7606
Fix lint
2024-04-13 18:24:57 +05:30
Manav Rathi
eb995f4354
Split
2024-04-13 18:20:40 +05:30
Manav Rathi
37cb2aaaf9
Refactor
2024-04-13 18:09:32 +05:30
Manav Rathi
1ffa905f99
Inline 2
2024-04-13 17:00:50 +05:30
Manav Rathi
07fa5cb83d
Inline 2
2024-04-13 16:59:47 +05:30
Manav Rathi
c90ba63aad
Inline 1
2024-04-13 16:57:04 +05:30
Manav Rathi
284d7920b3
Inline 2
2024-04-13 16:54:26 +05:30
Manav Rathi
ca114a467d
Inline 1
2024-04-13 16:50:23 +05:30
Manav Rathi
f7e961e86b
Inline
2024-04-13 16:44:55 +05:30
Vishnu Mohandas
e72003c199
[mob][photos] Prepare for release v0.8.79 ( #1430 )
...
2024-04-13 15:09:12 +05:30
ashilkn
1a8ec9fb4c
[mob] minor change to change log
2024-04-13 15:02:43 +05:30
ashilkn
8fa18e1ffe
[mob] update change log
2024-04-13 13:37:03 +05:30
ashilkn
703ba5ad9b
[mob] bump up to v0.8.79
2024-04-13 13:22:38 +05:30
Manav Rathi
ba5383789a
[desktop] Add an OPFS based cache ( #1429 )
...
See the extensive documentation in `blob-cache.ts` for the why and the
how. Done basic sanity testing for normal flows, the beta ML flows still
need to be tested.
2024-04-13 13:19:37 +05:30
Manav Rathi
7deb0dca8e
Fix lint
2024-04-13 13:17:42 +05:30
Manav Rathi
f2d3ec74a1
Granular migration
2024-04-13 13:12:16 +05:30
Manav Rathi
0f3b28a425
Revert "Recreate ML db"
...
This partially reverts commit 95a0e80c5b
2024-04-13 12:56:21 +05:30
Manav Rathi
95a0e80c5b
Recreate ML db
2024-04-13 12:46:48 +05:30
Neeraj Gupta
555a960def
[auth] Potential fix for keyboard popup not working while focusing on… ( #1428 )
...
… search
## Description
## Tests
2024-04-13 12:15:49 +05:30
