Manav Rathi
18ac361688
Remove unused IPC method
2024-04-14 20:11:25 +05:30
Manav Rathi
87077417a2
Remove dup
2024-04-14 20:07:17 +05:30
Manav Rathi
d0ac3ea9ca
Remove newly dead code
2024-04-14 20:00:59 +05:30
Manav Rathi
a5f9fdd10d
Restructure selection
2024-04-14 19:59:13 +05:30
Manav Rathi
881a963fde
Inline
2024-04-14 19:46:26 +05:30
Manav Rathi
f9560ec533
Inline
2024-04-14 19:43:31 +05:30
Manav Rathi
22616bb77d
Remove top level error suppressors
2024-04-14 19:42:30 +05:30
Manav Rathi
4d19c46d7c
Replace exception handling for control flow
2024-04-14 19:39:35 +05:30
Manav Rathi
cc323905d5
Another
2024-04-14 19:33:49 +05:30
Manav Rathi
fca4b2aca6
Use also for the image
2024-04-14 19:29:22 +05:30
Manav Rathi
c4ac5e39a2
Refactor
2024-04-14 19:25:01 +05:30
Manav Rathi
28574e516d
[desktop] Fix export related IPC - Part 3/x ( #1439 )
2024-04-14 19:04:38 +05:30
Manav Rathi
1232c74b8b
[web] Fix CSS alignment issue on gallery page ( #1438 )
...
## Description
Ran ente.io locally on PC and found a CSS-alignment issue on the
`http://localhost:3000/gallery ` page.
The alignment issue was found when it was locally hosted and found when
'/gallery' was in an empty state.
The line - "Welcome to" followed by the image of 'ente' was not aligned.
It was fixed by adding the following line `vertical-align: middle;` to
the styled component.
> Please find below images showing the off-alignment and the rectified
image.
> Thank you ! to the team for considering
## Tests
### Before
### After
2024-04-14 19:01:44 +05:30
Manav Rathi
22f221d481
Extract
2024-04-14 18:36:36 +05:30
Manav Rathi
f5a4830a5a
Remove unnecessary check
...
e.g. macOS node shell
> await fs.rename("/tmp/foo/bar/quxx.txt", "/tmp/foo/a.txt")
[Error: ENOENT: no such file or directory, rename '/tmp/foo/bar/quxx.txt' -> '/tmp/foo/a.txt']
2024-04-14 18:28:10 +05:30
Manav Rathi
eb64a00ed2
Remove unnecessary checks
...
It is simpler for us to parallel the rm command than our bespoke variant.
2024-04-14 18:22:46 +05:30
Manav Rathi
59b9e3e586
Move into fs
2024-04-14 18:12:19 +05:30
Manav Rathi
0f1c2fa1cd
Remove unnecessary check
...
Mentioned in rmdir docs
Tested on macOS with a node shell
> await fs.rmdir("/tmp/foo/bar/baz")
Uncaught [Error: ENOTEMPTY: directory not empty, rmdir '/tmp/foo/bar/baz']
2024-04-14 18:06:49 +05:30
Manav Rathi
fb5ae3a2ac
Remove unnecessary check
...
rmdir docs already mention it'll only work on folders
Also tested on macOS with a node shell
> await fs.rmdir("/tmp/foo/bar/baz/quxx.txt")
Uncaught [Error: ENOTDIR: not a directory, rmdir '/tmp/foo/bar/baz/quxx.txt'] {
2024-04-14 17:55:40 +05:30
daviddeepan
2a9060bd39
css-alignment-issue-page-gallery
2024-04-14 13:53:00 +05:30
Vishnu Mohandas
db50d121e6
Update index.md
2024-04-14 11:30:47 +05:30
Manav Rathi
adb37f38e4
Shorten
2024-04-14 10:31:45 +05:30
Manav Rathi
14922b65f8
Inline
2024-04-14 10:28:27 +05:30
Manav Rathi
7438c3301e
Move mkdirIfNeeded into fs
2024-04-14 10:25:28 +05:30
Manav Rathi
0e8678715a
Remove layer
2024-04-14 10:03:16 +05:30
Manav Rathi
3824ebe91a
Remove exportService indirection
2024-04-14 09:57:58 +05:30
Manav Rathi
ea34eebfc9
Remove implicit electron dependency
2024-04-14 09:53:18 +05:30
Manav Rathi
eeb1952585
Use
2024-04-14 09:30:51 +05:30
Manav Rathi
72dd47fa7b
Audit rename
2024-04-14 09:27:52 +05:30
Manav Rathi
b977f982dd
[desktop] Fix export related IPC - Part 2/x ( #1436 )
2024-04-13 21:56:46 +05:30
Manav Rathi
38db03c3a0
Start giving it more power
2024-04-13 21:50:56 +05:30
Manav Rathi
e268b9204e
Inline
2024-04-13 21:46:34 +05:30
Manav Rathi
acd50bb172
Inline
2024-04-13 21:39:36 +05:30
Manav Rathi
28d559bd84
Hoist
2024-04-13 21:35:58 +05:30
Manav Rathi
e87c7ed108
Inline
2024-04-13 21:34:37 +05:30
Manav Rathi
67a81f8d86
Dedup
2024-04-13 21:31:36 +05:30
Manav Rathi
30f147ec5b
Update jsdoc
2024-04-13 21:26:00 +05:30
Manav Rathi
6829d0bf15
Remove unused
2024-04-13 21:24:52 +05:30
Manav Rathi
d03b265eb4
Captialize
...
We've been capitalizing the name at places where we can. This name is only used
when creating new exports, and shouldn't effect existing export, so it is safe
to change.
2024-04-13 21:21:48 +05:30
Manav Rathi
297ca09535
Refactor and extract
2024-04-13 21:20:20 +05:30
Manav Rathi
82bbb1c6dd
Cleanup and document
2024-04-13 21:06:47 +05:30
Manav Rathi
4fbfbf0aa0
Cleanup
2024-04-13 20:53:35 +05:30
Manav Rathi
56d04066ea
sfn
2024-04-13 20:38:29 +05:30
Manav Rathi
7838f7484d
Make explicit
2024-04-13 20:29:17 +05:30
Manav Rathi
a6887e3037
[web] Add ESLint to enforce HMR how vite likes it ( #1433 )
...
Configuration changes taken from the vite starter (react-ts).
From the [vite
docs](https://github.com/vitejs/vite-plugin-react-swc?tab=readme-ov-file#consistent-components-exports )
> For React refresh to work correctly, your file should only export
React components.
>
> If an incompatible change in exports is found, the module will be
invalidated. To make it easier to export simple constants alongside your
component the module is only invalidated when their value changes.
While we're not currently using vite for our main apps, it would be
worthwhile to write code in a way that a future migration to it is
painless if needed.
About the what and the why, the Gatsby docs are illuminating:
https://www.gatsbyjs.com/docs/reference/local-development/fast-refresh/#how-it-works
Some other refs:
- https://github.com/ArnaudBarre/eslint-plugin-react-refresh
-
https://github.com/vitejs/vite/discussions/4577#discussioncomment-1161007
- https://github.com/vitejs/vite-plugin-react/issues/34
2024-04-13 18:57:24 +05:30
Manav Rathi
c7757cb08e
Prune more stale overrides
2024-04-13 18:54:15 +05:30
Manav Rathi
ce642e12c1
Remove stale disables
2024-04-13 18:50:12 +05:30
Manav Rathi
e07559c8da
Fix oopsie
2024-04-13 18:41:47 +05:30
Manav Rathi
64231c73f1
[web] Add ESLint to enforce HMR how vite likes it
...
Configuration changes taken from the vite starter (react-ts).
From the vite docs (https://github.com/vitejs/vite-plugin-react-swc?tab=readme-ov-file#consistent-components-exports )
> For React refresh to work correctly, your file should only export React components.
>
> If an incompatible change in exports is found, the module will be invalidated.
> To make it easier to export simple constants alongside your component the module
> is only invalidated when their value changes.
While we're not currently using vite for our main apps, it would be worthwhile
to write code in a way that a future migration to it is painless if needed.
About the what and the why, the Gatsby docs are illuminating:
https://www.gatsbyjs.com/docs/reference/local-development/fast-refresh/#how-it-works
Some other refs:
- https://github.com/ArnaudBarre/eslint-plugin-react-refresh
- https://github.com/vitejs/vite/discussions/4577#discussioncomment-1161007
- https://github.com/vitejs/vite-plugin-react/issues/34
2024-04-13 18:38:24 +05:30
Manav Rathi
27fb43837b
[desktop] Fix export related IPC - Part 1/x ( #1432 )
2024-04-13 18:31:36 +05:30
