beenull/crowdsec
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

don't defer in a select

Browse source
This commit is contained in:
Sebastien Blot 2023-10-17 14:48:47 +02:00
parent 5781eb22ec
commit 1857ef4e74
No known key found for this signature in database
GPG key ID: DFC2902F40449F6A
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/acquisition/modules/loki/internal/lokiclient/loki_client.go
View file

@ -75,17 +75,19 @@ func (lc *LokiClient) queryRange(uri string, ctx context.Context, c chan *LokiQu
if err != nil { if err != nil {
return errors.Wrapf(err, "error querying range") return errors.Wrapf(err, "error querying range")
} }
defer resp.Body.Close() // Ensure the response body is always closed.
if resp.StatusCode != http.StatusOK { if resp.StatusCode != http.StatusOK {
body, _ := io.ReadAll(resp.Body) body, _ := io.ReadAll(resp.Body)
resp.Body.Close()
return errors.Wrapf(err, "bad HTTP response code: %d: %s", resp.StatusCode, string(body)) return errors.Wrapf(err, "bad HTTP response code: %d: %s", resp.StatusCode, string(body))
} }
var lq LokiQueryRangeResponse var lq LokiQueryRangeResponse
if err := json.NewDecoder(resp.Body).Decode(&lq); err != nil { if err := json.NewDecoder(resp.Body).Decode(&lq); err != nil {
resp.Body.Close()
return errors.Wrapf(err, "error decoding Loki response") return errors.Wrapf(err, "error decoding Loki response")
} }
resp.Body.Close()
lc.Logger.Tracef("Got response: %+v", lq) lc.Logger.Tracef("Got response: %+v", lq)
c <- &lq c <- &lq