From 1857ef4e74c8258adc9794c0ad321c1eaf9f107d Mon Sep 17 00:00:00 2001 From: Sebastien Blot Date: Tue, 17 Oct 2023 14:48:47 +0200 Subject: [PATCH] don't defer in a select --- .../modules/loki/internal/lokiclient/loki_client.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/acquisition/modules/loki/internal/lokiclient/loki_client.go b/pkg/acquisition/modules/loki/internal/lokiclient/loki_client.go index c60433ca6..d5cc54e3d 100644 --- a/pkg/acquisition/modules/loki/internal/lokiclient/loki_client.go +++ b/pkg/acquisition/modules/loki/internal/lokiclient/loki_client.go @@ -75,17 +75,19 @@ func (lc *LokiClient) queryRange(uri string, ctx context.Context, c chan *LokiQu if err != nil { return errors.Wrapf(err, "error querying range") } - defer resp.Body.Close() // Ensure the response body is always closed. if resp.StatusCode != http.StatusOK { body, _ := io.ReadAll(resp.Body) + resp.Body.Close() return errors.Wrapf(err, "bad HTTP response code: %d: %s", resp.StatusCode, string(body)) } var lq LokiQueryRangeResponse if err := json.NewDecoder(resp.Body).Decode(&lq); err != nil { + resp.Body.Close() return errors.Wrapf(err, "error decoding Loki response") } + resp.Body.Close() lc.Logger.Tracef("Got response: %+v", lq) c <- &lq