beenull/tellform
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

fixed desktop device detection

Browse source
This commit is contained in:
David Baldwynn 2017-03-06 13:21:21 -08:00
parent 91271686e8
commit 00054c9440
No known key found for this signature in database
GPG key ID: 15D1C13202224A9B
2 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
public/form_modules/forms/directives/analytics-service.client.directive.js
View file

@ -24,7 +24,7 @@
deviceType = 'tablet'; deviceType = 'tablet';
} else if (md.mobile()) { } else if (md.mobile()) {
deviceType = 'mobile'; deviceType = 'mobile';
} else if (window.screenX != 0) { } else if (!md.is('bot')) {
deviceType = 'desktop'; deviceType = 'desktop';
} }

16
public/modules/forms/admin/directives/edit-submissions-form.client.directive.js
View file

@ -53,6 +53,8 @@ angular.module('forms').directive('editSubmissionsFormDirective', ['$rootScope',
totalTime += $scope.table.rows[i].timeElapsed; totalTime += $scope.table.rows[i].timeElapsed;
} }
if(numSubmissions == 0) return 0;
return totalTime/numSubmissions; return totalTime/numSubmissions;
})(); })();
@ -83,14 +85,18 @@ angular.module('forms').directive('editSubmissionsFormDirective', ['$rootScope',
stats[deviceType].visits++; stats[deviceType].visits++;
stats[deviceType].total_time = stats[deviceType].total_time + visitor.timeElapsed; stats[deviceType].total_time = stats[deviceType].total_time + visitor.timeElapsed;
stats[deviceType].average_time = stats[deviceType].total_time / stats[deviceType].visits || 0;
stats[deviceType].average_time = stats[deviceType].total_time / stats[deviceType].visits;
if(!stats[deviceType].average_time) stats[deviceType].average_time = 0;
if (visitor.isSubmitted) stats[deviceType].responses++; if (visitor.isSubmitted) stats[deviceType].responses++;
stats[deviceType].completion = stats[deviceType].response / stats[deviceType].visits || 0; stats[deviceType].completion = stats[deviceType].responses / stats[deviceType].visits;
if(!stats[deviceType].completion) stats[deviceType].completion = 0;
} }
console.log("stats"); console.log("stats");
console.log(stats);
} }
return stats; return stats;
@ -133,9 +139,7 @@ angular.module('forms').directive('editSubmissionsFormDirective', ['$rootScope',
/* /*
* Form Submission Methods * Form Submission Methods
*/ */
//Fetch and display submissions of Form
//Delete selected submissions of Form //Delete selected submissions of Form
$scope.deleteSelectedSubmissions = function(){ $scope.deleteSelectedSubmissions = function(){