From cfd0eb0145de681548e9abdd7cb9c51c40ae84d5 Mon Sep 17 00:00:00 2001 From: dosse91 Date: Sat, 12 Oct 2019 08:18:37 +0200 Subject: [PATCH 1/3] Removed Firefox xhr_ulMultistream browser quirk because it was outdated --- doc.md | 1 - speedtest_worker.js | 4 ---- 2 files changed, 5 deletions(-) diff --git a/doc.md b/doc.md index edfd0ec..07258b2 100644 --- a/doc.md +++ b/doc.md @@ -367,7 +367,6 @@ __Advanced parameters:__ (Seriously, don't change these unless you know what you * __xhr_ulMultistream__: how many streams should be opened for the upload test * Default: `3` * Recommended: `>=1` - * Default override: 1 on Firefox if enable_quirks is true * __xhr_ul_blob_megabytes__: size in megabytes of the blobs sent during the upload test * Default: `20` * Default override: 4 on Chromium-based mobile browsers (limitation introduced around version 65). This will be forced diff --git a/speedtest_worker.js b/speedtest_worker.js index 814a2ad..43958d2 100644 --- a/speedtest_worker.js +++ b/speedtest_worker.js @@ -126,10 +126,6 @@ this.addEventListener("message", function(e) { if (settings.enable_quirks || (typeof s.enable_quirks !== "undefined" && s.enable_quirks)) { var ua = navigator.userAgent; if (/Firefox.(\d+\.\d+)/i.test(ua)) { - if (typeof s.xhr_ulMultistream === "undefined") { - // ff more precise with 1 upload stream - settings.xhr_ulMultistream = 1; - } if (typeof s.ping_allowPerformanceApi === "undefined") { // ff performance API sucks settings.ping_allowPerformanceApi = false; From 6a3bc067578dd023c0e8106cb1cfb3941bdc3c46 Mon Sep 17 00:00:00 2001 From: dosse91 Date: Fri, 13 Dec 2019 19:19:14 +0100 Subject: [PATCH 2/3] Fixed error in doc.md --- doc.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc.md b/doc.md index 07258b2..c82cafb 100644 --- a/doc.md +++ b/doc.md @@ -326,7 +326,7 @@ __Main parameters:__ * Default: `getIP.php` * __Important:__ path is relative to js file * __url_telemetry__: path to telemetry.php or replacement - * Default: `telemetry/telemetry.php` + * Default: `results/telemetry.php` * __Important:__ path is relative to js file * __Note:__ you can ignore this parameter if you're not using the telemetry * __telemetry_level__: The type of telemetry to use. See the telemetry section for more info about this From 5d9b44c77bd5a01a0fcff22f80a84fe8c92677e4 Mon Sep 17 00:00:00 2001 From: dosse91 Date: Mon, 17 Feb 2020 18:49:09 +0100 Subject: [PATCH 3/3] Fixed a bug where a variable wasn't initialized if enable_quirks was disabled --- speedtest_worker.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/speedtest_worker.js b/speedtest_worker.js index 43958d2..c91f506 100644 --- a/speedtest_worker.js +++ b/speedtest_worker.js @@ -122,9 +122,9 @@ this.addEventListener("message", function(e) { if (typeof settings[key] !== "undefined") settings[key] = s[key]; else twarn("Unknown setting ignored: " + key); } + var ua = navigator.userAgent; // quirks for specific browsers. apply only if not overridden. more may be added in future releases if (settings.enable_quirks || (typeof s.enable_quirks !== "undefined" && s.enable_quirks)) { - var ua = navigator.userAgent; if (/Firefox.(\d+\.\d+)/i.test(ua)) { if (typeof s.ping_allowPerformanceApi === "undefined") { // ff performance API sucks