From 9b8faee10dbdcf7fb8493d40ab387c11dc664556 Mon Sep 17 00:00:00 2001 From: Stefan Stidl Date: Sun, 5 Nov 2023 02:08:11 +0100 Subject: [PATCH 1/2] fix ipinfo parsing --- backend/getIP.php | 110 ++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 92 insertions(+), 18 deletions(-) diff --git a/backend/getIP.php b/backend/getIP.php index 0b6267d..7c57a93 100755 --- a/backend/getIP.php +++ b/backend/getIP.php @@ -76,7 +76,7 @@ function getIpInfoTokenString() return ''; } - return '?token='.$IPINFO_APIKEY; + return '?token=' . $IPINFO_APIKEY; } /** @@ -86,7 +86,7 @@ function getIpInfoTokenString() */ function getIspInfo($ip) { - $json = file_get_contents('https://ipinfo.io/'.$ip.'/json'.getIpInfoTokenString()); + $json = file_get_contents('https://ipinfo.io/' . $ip . '/json' . getIpInfoTokenString()); if (!is_string($json)) { return null; } @@ -106,17 +106,91 @@ function getIspInfo($ip) */ function getIsp($rawIspInfo) { - if ( - !is_array($rawIspInfo) - || !array_key_exists('org', $rawIspInfo) - || !is_string($rawIspInfo['org']) - || empty($rawIspInfo['org']) - ) { - return 'Unknown ISP'; + if (is_array($rawIspInfo)) { + /* variant with no token + has json like: + { + "ip": "xxx.xxx.xxx.xxx", + "hostname": "example.com", + "city": "Vienna", + "region": "Vienna", + "country": "AT", + "loc": "48.2085,16.3721", + "org": "ASxxxx T-Mobile Austria GmbH", + "postal": "nnnn", + "timezone": "Europe/Vienna", + "readme": "https://ipinfo.io/missingauth" + } + */ + if ( + array_key_exists('org', $rawIspInfo) + && is_string($rawIspInfo['org']) + && !empty($rawIspInfo['org']) + ) { + // Remove AS##### from ISP name, if present + return preg_replace('/AS\\d+\\s/', '', $rawIspInfo['org']); + } + + /* + variant with valid token has json: + { + "ip": "xxx.xxx.xxx.xxx", + "hostname": "example.com", + "city": "Vienna", + "region": "Vienna", + "country": "AT", + "loc": "48.2085,16.3721", + "postal": "1010", + "timezone": "Europe/Vienna", + "asn": { + "asn": "ASxxxx", + "name": "T-Mobile Austria GmbH", + "domain": "t-mobile.at", + "route": "xxx.xxx.xxx.xxx/xx", + "type": "isp" + }, + "company": { + "name": "XX", + "domain": "example.com", + "type": "isp" + }, + "privacy": { + "vpn": true, + "proxy": false, + "tor": false, + "relay": false, + "hosting": false, + "service": "" + }, + "abuse": { + "address": "...", + "country": "AT", + "email": "abuse@example.com", + "name": "XXX", + "network": "xxx.xxx.xxx.xxx-xxx.xxx.xxx.xxx", + "phone": "" + }, + "domains": { + "total": 0, + "domains": [ + + ] + } + } + */ + if ( + array_key_exists('asn', $rawIspInfo) + && is_string($rawIspInfo['asn']) + && !empty($rawIspInfo['asn']) + && array_key_exists('name', $rawIspInfo['asn']) + && is_string($rawIspInfo['asn']['name']) + ) { + // Remove AS##### from ISP name, if present + return $rawIspInfo['asn']['name']; + } } - // Remove AS##### from ISP name, if present - return preg_replace('/AS\\d+\\s/', '', $rawIspInfo['org']); + return 'Unknown ISP'; } /** @@ -135,7 +209,7 @@ function getServerLocation() return $serverLoc; } - $json = file_get_contents('https://ipinfo.io/json'.getIpInfoTokenString()); + $json = file_get_contents('https://ipinfo.io/json' . getIpInfoTokenString()); if (!is_string($json)) { return null; } @@ -151,7 +225,7 @@ function getServerLocation() } $serverLoc = $details['loc']; - $cacheData = " Date: Sun, 5 Nov 2023 02:27:49 +0100 Subject: [PATCH 2/2] fix regression on getIpinfo --- backend/getIP.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/getIP.php b/backend/getIP.php index 7c57a93..c7501c4 100755 --- a/backend/getIP.php +++ b/backend/getIP.php @@ -180,7 +180,7 @@ function getIsp($rawIspInfo) */ if ( array_key_exists('asn', $rawIspInfo) - && is_string($rawIspInfo['asn']) + && is_array($rawIspInfo['asn']) && !empty($rawIspInfo['asn']) && array_key_exists('name', $rawIspInfo['asn']) && is_string($rawIspInfo['asn']['name'])