From 0c4c8c15bdc3ed02e814e33d9a4fe9e64b26241a Mon Sep 17 00:00:00 2001 From: Federico Dossena Date: Sun, 30 Sep 2018 19:25:51 +0200 Subject: [PATCH 1/2] Added issue templates --- .github/ISSUE_TEMPLATE/bug_report.md | 28 +++++++++++++++++++++++ .github/ISSUE_TEMPLATE/feature_request.md | 17 ++++++++++++++ 2 files changed, 45 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/feature_request.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 0000000..f4804cb --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,28 @@ +--- +name: Bug report +about: Report a bug with this project. Don't use this if you need help configuring + it + +--- + +## Description +A short description of what's going on + +## Server +Every info you can provide about your server: web server, database, PHP version, ... as well as server-side speedtest settings +If possible, provide an URL to your speedtest so we can check it + +## Client +Browser, OS, type of connection, unusual software, ... + +## Steps to reproduce +* Do this +* Do that +* Bad stuff happens + +## Expected behaviour +What should have happened + +## Screenshots +If necessary, add screenshots of the test. +F12 > Network screenshots can be particularly useful diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 0000000..08d4db8 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,17 @@ +--- +name: Feature request +about: Suggest an idea for this project + +--- + +## Description +A short description of your idea + +## Why it should be implemented +Who it would benefit, ... + +## Optional: implementation suggestions +If you have experience in this field, feel free to give us suggestions + +## Optional: screenshots +Add some screenshots, mockups, ... if they help clarify what you want From 3a631e28883b543ce7865ae7232af281d5a623af Mon Sep 17 00:00:00 2001 From: Florian Kaiser Date: Wed, 17 Oct 2018 13:34:57 +0200 Subject: [PATCH 2/2] Add mysqli store_result() before bind_result() - fixes #167 (#168) --- telemetry/stats.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/telemetry/stats.php b/telemetry/stats.php index f6400ef..0d21b21 100644 --- a/telemetry/stats.php +++ b/telemetry/stats.php @@ -91,6 +91,7 @@ if($stats_password=="PASSWORD"){ $q=$conn->prepare("select id,timestamp,ip,ispinfo,ua,lang,dl,ul,ping,jitter,log,extra from speedtest_users where id=?"); $q->bind_param("i",$_POST["id"]); $q->execute(); + $q->store_result(); $q->bind_result($id,$timestamp,$ip,$ispinfo,$ua,$lang,$dl,$ul,$ping,$jitter,$log,$extra); } else if($db_type=="sqlite"||$db_type=="postgresql"){ $q=$conn->prepare("select id,timestamp,ip,ispinfo,ua,lang,dl,ul,ping,jitter,log,extra from speedtest_users where id=?"); @@ -100,6 +101,7 @@ if($stats_password=="PASSWORD"){ if($db_type=="mysql"){ $q=$conn->prepare("select id,timestamp,ip,ispinfo,ua,lang,dl,ul,ping,jitter,log,extra from speedtest_users order by timestamp desc limit 0,100"); $q->execute(); + $q->store_result(); $q->bind_result($id,$timestamp,$ip,$ispinfo,$ua,$lang,$dl,$ul,$ping,$jitter,$log,$extra); } else if($db_type=="sqlite"||$db_type=="postgresql"){ $q=$conn->prepare("select id,timestamp,ip,ispinfo,ua,lang,dl,ul,ping,jitter,log,extra from speedtest_users order by timestamp desc limit 0,100");