From de0368c20f507f398d72cd6847c00a61c6e7d6ab Mon Sep 17 00:00:00 2001 From: Son NK Date: Fri, 27 Dec 2019 17:36:35 +0100 Subject: [PATCH] remove redundant code --- app/auth/views/mfa.py | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/app/auth/views/mfa.py b/app/auth/views/mfa.py index 2e8e715f..cc21727d 100644 --- a/app/auth/views/mfa.py +++ b/app/auth/views/mfa.py @@ -29,24 +29,23 @@ def mfa(): if otp_token_form.validate_on_submit(): totp = pyotp.TOTP(user.otp_secret) - if otp_token_form.validate_on_submit(): - token = otp_token_form.token.data + token = otp_token_form.token.data - if totp.verify(token): - del session[MFA_USER_ID] + if totp.verify(token): + del session[MFA_USER_ID] - login_user(user) - flash(f"Welcome back {user.name}!") - - # User comes to login page from another page - if next_url: - LOG.debug("redirect user to %s", next_url) - return redirect(next_url) - else: - LOG.debug("redirect user to dashboard") - return redirect(url_for("dashboard.index")) + login_user(user) + flash(f"Welcome back {user.name}!") + # User comes to login page from another page + if next_url: + LOG.debug("redirect user to %s", next_url) + return redirect(next_url) else: - flash("Incorrect token", "warning") + LOG.debug("redirect user to dashboard") + return redirect(url_for("dashboard.index")) + + else: + flash("Incorrect token", "warning") return render_template("auth/mfa.html", otp_token_form=otp_token_form)