From 7a2fc007e8f34adb97993842784c2c23e961d158 Mon Sep 17 00:00:00 2001
From: Son NK <nguyenkims@hotmail.com>
Date: Sun, 26 Apr 2020 10:38:16 +0200
Subject: [PATCH] Accept "name" in PUT /api/aliases/:alias_id

---
 README.md               |  1 +
 app/api/views/alias.py  |  6 ++++++
 tests/api/test_alias.py | 24 ++++++++++++++++++++++++
 3 files changed, 31 insertions(+)

diff --git a/README.md b/README.md
index 601bbc91..3283c5e9 100644
--- a/README.md
+++ b/README.md
@@ -1046,6 +1046,7 @@ Input:
 - `alias_id` in url.
 - (optional) `note` in request body
 - (optional) `mailbox_id` in request body
+- (optional) `name` in request body
 
 Output:
 If success, return 200
diff --git a/app/api/views/alias.py b/app/api/views/alias.py
index b407d57d..a75d8b38 100644
--- a/app/api/views/alias.py
+++ b/app/api/views/alias.py
@@ -253,6 +253,7 @@ def update_alias(alias_id):
     Input:
         alias_id: in url
         note: in body
+        name: in body
     Output:
         200
     """
@@ -281,6 +282,11 @@ def update_alias(alias_id):
         alias.mailbox_id = mailbox_id
         changed = True
 
+    if "name" in data:
+        new_name = data.get("name")
+        alias.name = new_name
+        changed = True
+
     if changed:
         db.session.commit()
 
diff --git a/tests/api/test_alias.py b/tests/api/test_alias.py
index 7229f301..3992f831 100644
--- a/tests/api/test_alias.py
+++ b/tests/api/test_alias.py
@@ -333,6 +333,30 @@ def test_update_alias_mailbox(flask_client):
     assert r.status_code == 400
 
 
+def test_update_alias_name(flask_client):
+    user = User.create(
+        email="a@b.c", password="password", name="Test User", activated=True
+    )
+    db.session.commit()
+
+    # create api_key
+    api_key = ApiKey.create(user.id, "for test")
+    db.session.commit()
+
+    alias = Alias.create_new_random(user)
+    db.session.commit()
+
+    r = flask_client.put(
+        url_for("api.update_alias", alias_id=alias.id),
+        headers={"Authentication": api_key.code},
+        json={"name": "Test Name"},
+    )
+
+    assert r.status_code == 200
+    alias = Alias.get(alias.id)
+    assert alias.name == "Test Name"
+
+
 def test_alias_contacts(flask_client):
     user = User.create(
         email="a@b.c", password="password", name="Test User", activated=True