Support update mailbox_id in PUT /aliases/:aliasID
This commit is contained in:
parent
203eba9917
commit
489153a750
|
@ -1009,7 +1009,8 @@ Update alias note. In the future, the endpoint will support other updates (e.g.
|
||||||
Input:
|
Input:
|
||||||
- `Authentication` header that contains the api key
|
- `Authentication` header that contains the api key
|
||||||
- `alias_id` in url.
|
- `alias_id` in url.
|
||||||
- `note` in request body
|
- (optional) `note` in request body
|
||||||
|
- (optional) `mailbox_id` in request body
|
||||||
|
|
||||||
Output:
|
Output:
|
||||||
If success, return 200
|
If success, return 200
|
||||||
|
|
|
@ -19,7 +19,7 @@ from app.dashboard.views.alias_log import get_alias_log
|
||||||
from app.email_utils import parseaddr_unicode
|
from app.email_utils import parseaddr_unicode
|
||||||
from app.extensions import db
|
from app.extensions import db
|
||||||
from app.log import LOG
|
from app.log import LOG
|
||||||
from app.models import Alias, Contact
|
from app.models import Alias, Contact, Mailbox
|
||||||
from app.utils import random_string
|
from app.utils import random_string
|
||||||
|
|
||||||
|
|
||||||
|
@ -234,8 +234,6 @@ def update_alias(alias_id):
|
||||||
note: in body
|
note: in body
|
||||||
Output:
|
Output:
|
||||||
200
|
200
|
||||||
|
|
||||||
|
|
||||||
"""
|
"""
|
||||||
data = request.get_json()
|
data = request.get_json()
|
||||||
if not data:
|
if not data:
|
||||||
|
@ -247,11 +245,26 @@ def update_alias(alias_id):
|
||||||
if alias.user_id != user.id:
|
if alias.user_id != user.id:
|
||||||
return jsonify(error="Forbidden"), 403
|
return jsonify(error="Forbidden"), 403
|
||||||
|
|
||||||
|
|
||||||
|
changed = False
|
||||||
|
if "note" in data:
|
||||||
new_note = data.get("note")
|
new_note = data.get("note")
|
||||||
alias.note = new_note
|
alias.note = new_note
|
||||||
|
changed = True
|
||||||
|
|
||||||
|
if "mailbox_id" in data:
|
||||||
|
mailbox_id = int(data.get("mailbox_id"))
|
||||||
|
mailbox = Mailbox.get(mailbox_id)
|
||||||
|
if not mailbox or mailbox.user_id != user.id or not mailbox.verified:
|
||||||
|
return jsonify(error="Forbidden"), 400
|
||||||
|
|
||||||
|
alias.mailbox_id = mailbox_id
|
||||||
|
changed = True
|
||||||
|
|
||||||
|
if changed:
|
||||||
db.session.commit()
|
db.session.commit()
|
||||||
|
|
||||||
return jsonify(note=new_note), 200
|
return jsonify(ok=True), 200
|
||||||
|
|
||||||
|
|
||||||
@api_bp.route("/aliases/<int:alias_id>", methods=["GET"])
|
@api_bp.route("/aliases/<int:alias_id>", methods=["GET"])
|
||||||
|
@ -374,8 +387,6 @@ def delete_contact(contact_id):
|
||||||
contact_id: in url
|
contact_id: in url
|
||||||
Output:
|
Output:
|
||||||
200
|
200
|
||||||
|
|
||||||
|
|
||||||
"""
|
"""
|
||||||
user = g.user
|
user = g.user
|
||||||
contact = Contact.get(contact_id)
|
contact = Contact.get(contact_id)
|
||||||
|
|
|
@ -6,7 +6,7 @@ from flask import url_for
|
||||||
|
|
||||||
from app.config import PAGE_LIMIT
|
from app.config import PAGE_LIMIT
|
||||||
from app.extensions import db
|
from app.extensions import db
|
||||||
from app.models import User, ApiKey, Alias, Contact, EmailLog
|
from app.models import User, ApiKey, Alias, Contact, EmailLog, Mailbox
|
||||||
|
|
||||||
|
|
||||||
def test_get_aliases_error_without_pagination(flask_client):
|
def test_get_aliases_error_without_pagination(flask_client):
|
||||||
|
@ -292,7 +292,38 @@ def test_update_alias(flask_client):
|
||||||
)
|
)
|
||||||
|
|
||||||
assert r.status_code == 200
|
assert r.status_code == 200
|
||||||
assert r.json == {"note": "test note"}
|
|
||||||
|
|
||||||
|
def test_update_alias_mailbox(flask_client):
|
||||||
|
user = User.create(
|
||||||
|
email="a@b.c", password="password", name="Test User", activated=True
|
||||||
|
)
|
||||||
|
db.session.commit()
|
||||||
|
|
||||||
|
mb = Mailbox.create(user_id=user.id, email="ab@cd.com", verified=True)
|
||||||
|
|
||||||
|
# create api_key
|
||||||
|
api_key = ApiKey.create(user.id, "for test")
|
||||||
|
db.session.commit()
|
||||||
|
|
||||||
|
alias = Alias.create_new_random(user)
|
||||||
|
db.session.commit()
|
||||||
|
|
||||||
|
r = flask_client.put(
|
||||||
|
url_for("api.update_alias", alias_id=alias.id),
|
||||||
|
headers={"Authentication": api_key.code},
|
||||||
|
json={"mailbox_id": mb.id},
|
||||||
|
)
|
||||||
|
|
||||||
|
assert r.status_code == 200
|
||||||
|
|
||||||
|
# fail when update with non-existing mailbox
|
||||||
|
r = flask_client.put(
|
||||||
|
url_for("api.update_alias", alias_id=alias.id),
|
||||||
|
headers={"Authentication": api_key.code},
|
||||||
|
json={"mailbox_id": -1},
|
||||||
|
)
|
||||||
|
assert r.status_code == 400
|
||||||
|
|
||||||
|
|
||||||
def test_alias_contacts(flask_client):
|
def test_alias_contacts(flask_client):
|
||||||
|
|
Loading…
Reference in a new issue