Commit graph

12 commits

Author SHA1 Message Date
Eric Cornelissen 8b2ae9b780 Hotfix .svglintrc.js
There was a minor error in .svglintrc.js that caused it to silently
fail in the size and centered checks due to a mistake in the `isIgnored`
function.
2020-10-29 23:03:24 +02:00
David Beitey c290479a78
Update svglint ignore list, add ignore list updater (#3433)
This updates the ignore list as per #3250 and embeds code for updating
the ignore file when the environment variable `SI_UPDATE_IGNORE=true`
is set and the linter is run like so `SI_UPDATE_IGNORE=true npm run svglint`
-- running this command will display all remaining linting failures and
use these to update the ignore file.

This also:

* Normalises the top-level object key in the ignore file to match each
  linter name
* Sorts the ignore output on top-level key and icon name value to
  make output consistent
* Speeds up icon center checking if ignored
* Ignores icons in size linter if icon is otherwise ignored
2020-10-17 13:01:56 +02:00
Eric Cornelissen 7fb4ff6395
Fix low severity issues in the JavaScript (#3342) 2020-07-28 11:33:40 +01:00
David Beitey cc509d9246
Add svg linter to check center (#3250)
This adds a tolerance of +/- 0.001 to either the X or Y dimensions,
adjusting the existing ignore list and size linter to fit the new
structure of the ignore file.

See https://github.com/simple-icons/simple-icons/pull/3107#issuecomment-648089119
2020-07-10 11:06:08 +03:00
Peter Noble 6a2e8ca4a3
Remove extraneous spaces from icon markup (#3256)
* Remove extraneous spaces from icon markup

* Add linting check for excess whitespace
2020-07-05 15:57:00 +02:00
Eric Cornelissen 01221c047d
Add linting step for extraneous elements in SVGs (#3239)
* Add linting step for extraneous elements in SVGs

... such as a trailing "s" in the Quasar SVG (#3221)

* Remove trailing space from BMC Software icon

* Improve error message for violations

Co-authored-by: Peter Noble <PeterShaggyNoble@users.noreply.github.com>
Co-authored-by: Lucas Becker <runxel@users.noreply.github.com>
2020-06-22 18:24:56 +02:00
David Beitey 5da34c7efd
Add linter to check svg path dimensions (#3107)
* Add linter to check svg path dimensions

Float precision is set at 3 which is the default for svgo in .svgo.yml;
precision can be raised over time.

This adds an ignore file with the current paths of non-conforming icons.

This also changes the name of the icon title linter as well so it reads
more nicely than "custom".

* Update CONTRIBUTING GUIDELINES

Add a note on visual imperfections and viewbox problems due to 
optimizing.

Co-authored-by: Eric Cornelisesn <ericornelissen@gmail.com>
Co-authored-by: Peter Noble <PeterShaggyNoble@users.noreply.github.com>
2020-06-10 12:59:42 +03:00
Eric Cornelissen 287317b7b6 Lint the SVG's title content (#1508)
* Add custom SVGLint rule to lint the general <title> format

i.e. the <title> should be "[ICON_NAME] icon"

* Check if there exists an entry in simple-icons.json with the icon name

... found in the <title>

* Normalize all icons <title> value

* Fix mismatch between HTML's icon title and simple-icons.json title

... due to HTML special entities (such as `&amp;`). Affected icons:

- AT&T (AT&amp;T)
- Let's Encrypt (Let&apos;s Encrypt)

* Refactor .svglintrc.js

to make the code style more in line with scripts/prepublish.js

* Add SVG with invalid <title> format

* Add SVG with unknown title

* Revert 6912816 and f002504
2019-07-03 23:33:03 +02:00
David Klebanoff 1c0b2b1dbf Update SVG linting. Only single path SVGs allowed. (#1335)
* Update SVG linting. Only single path SVGs allowed.

* Update docs.
2019-03-28 21:40:31 +02:00
David Klebanoff 450cfbc9ad Update lint rules for SVG paths. (#1304) 2019-03-20 09:55:03 +02:00
Eric Cornelissen 4b882220ef Remove aria-labelledby and ids from SVGs (#1062)
* Remove `id` and `aria-labelledby` from all SVGs

* Update SVGLint configuration

* Remove `aria-labelledby` from documentation

* Remove `aria-labelledby` from website

because why not
2018-11-06 17:10:17 +01:00
Johan Fagerberg 289d1883a1 Add SVGLint (#922)
* Added SVGLint

* Added SVGLint to CI

* Upgraded Node version used by CI

* Upgraded SVGLint to latest version

* Moved SVGLint configuration file

* Upgraded SVGLint

1.0.1 -> 1.0.2
Adds support for globs on Windows

* Added SVGLint check for aria-labelledby and title ID
2018-08-16 11:33:32 +02:00