From 857338854945dc388ece7307cbfb38471f212f10 Mon Sep 17 00:00:00 2001 From: Adam Rusted Date: Tue, 20 Feb 2024 16:57:38 +0000 Subject: [PATCH] Add note about SimilarWeb Login to Icon Request Issue Template (#10429) --- .github/ISSUE_TEMPLATE/icon_request.yml | 3 +++ CONTRIBUTING.md | 11 ++++++++--- README.md | 2 +- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/icon_request.yml b/.github/ISSUE_TEMPLATE/icon_request.yml index a0e89e181..2a569c9d8 100644 --- a/.github/ISSUE_TEMPLATE/icon_request.yml +++ b/.github/ISSUE_TEMPLATE/icon_request.yml @@ -16,6 +16,9 @@ body: (including closed issues) before you continue. If you find one for the brand you're requesting then leave a comment on it or add a reaction. + > [!TIP] + > Similarweb is now trying to force users to log in in order to view statistics. You can bypass this by going directly to: + > `https://similarweb.com/website/google.com`, replacing `google.com` with the TLD you would like to get the stats on! [contributing guidelines]: https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6f83d6e68..0f0b747b5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -5,7 +5,7 @@ [![](https://img.shields.io/badge/dynamic/json?url=https%3A%2F%2Fapi.github.com%2Fsearch%2Fissues%3Fq%3Drepo%3Asimple-icons%2Fsimple-icons%2520is%3Aissue%2520is%3Aopen%2520label%3Ameta%2Cpackage%2520-linked%3Apr&query=%24.total_count&suffix=%20open&logo=typescript&logoColor=white&label=code%20issues&labelColor=3178C6&color=3178C6&style=flat-square)](https://github.com/simple-icons/simple-icons/issues?q=is%3Aissue+is%3Aopen+label%3Adocs%2Cmeta%2Cpackage+-linked%3Apr) [![](https://img.shields.io/badge/dynamic/json?url=https%3A%2F%2Fapi.github.com%2Fsearch%2Fissues%3Fq%3Drepo%3Asimple-icons%2Fsimple-icons%2520label%3Adocs%2520is%3Aopen%2520-linked%3Apr&query=%24.total_count&suffix=%20open&logo=markdown&label=docs%20issues&labelColor=343a40&color=343a40&logoColor=FFF&style=flat-square)](https://github.com/simple-icons/simple-icons/issues?q=is%3Aopen+is%3Aissue+label%3Adocs+-linked%3Apr) -> **Note**\ +> [!IMPORTANT]\ > We ask that all users read our [legal disclaimer](./DISCLAIMER.md) before contributing to Simple Icons. Simple Icons welcomes contributions and corrections. Before contributing, please make sure you have read the guidelines below. If you decide to contribute anything, please follow the steps below. If you're new to _git_ and/or _GitHub_, we suggest you go through [the GitHub Guides](https://guides.github.com/introduction/flow/). @@ -80,6 +80,10 @@ If you are in doubt, feel free to submit it and we'll have a look. ### Assessing Popularity +> [!TIP]\ +> Similarweb is now trying to force users to log in in order to view statistics. You can bypass this by going directly to: +> `https://similarweb.com/website/google.com`, replacing `google.com` with the TLD you would like to get the stats on! + To be considered popular enough to be within our scope, a brand must be in existence for at least one year (from date of first stable release, where applicable) and meet one of the following metrics of popularity, in order of preference: 1. Its website's Similarweb global rank is in the top 500k. @@ -112,7 +116,7 @@ To be considered popular enough to be within our scope, a brand must be in exist If all else fails, though, feel free to make a good case for the popularity of the brand you're requesting on any other grounds, provided it can be backed up with verifiable data. Example: a car manufacturer's own website falls outside our scope but a major dealership dealing exclusively or primarily in that brand falls within our scope - in that case we'd accept the manufacturer as being popular. If you can provide a _particularly_ good metric that can be applied to other brands then it will be added to this list. -> [!NOTE] +> [!NOTE]\ > All metrics & cut-offs above are subject to ongoing review and potential change. These current metrics were devised in order to no longer rely on GitHub stars as an indication of a project's popularity. But, for projects that only exist on GitHub, we do still need some way of assessing their popularity so, until we can come up with a better way to do so, we have kept stars for the time being but will not be putting as much weight on them as in the past. If you know of a better way of assessing the popularity of a GitHub project then please create an issue for discussion. ### Opening an Issue @@ -129,7 +133,8 @@ If you have an affiliation to the brand you are requesting that allows you to sp ## Adding or Updating an Icon -**Note**: If you decide to add an icon without requesting it first, the requirements above still apply. +> [!NOTE]\ +> If you decide to add an icon without requesting it first, the requirements above still apply. ### 1. Identify Official Logos and Colors diff --git a/README.md b/README.md index 5bd3698ce..6660d5e35 100644 --- a/README.md +++ b/README.md @@ -17,7 +17,7 @@ Over 3000 Free SVG icons for popular brands. See them all on one page at [!NOTE]\ +> [!IMPORTANT]\ > We ask that all users read our [legal disclaimer](https://github.com/simple-icons/simple-icons/blob/develop/DISCLAIMER.md) before using icons from Simple Icons. ### General Usage