Settings: Enable delete feature by default #3801

Signed-off-by: Michael Mayer <michael@photoprism.app>

internal/api/batch_test.go

@@ -265,12 +265,12 @@ func TestBatchPhotosApprove(t *testing.T) {
 }
 
 func TestBatchPhotosDelete(t *testing.T) {
-	t.Run("feature disabled", func(t *testing.T) {
+	t.Run("ErrNoItemsSelected", func(t *testing.T) {
 		app, router, _ := NewApiTest()
 		BatchPhotosDelete(router)
 		r := PerformRequestWithBody(app, "POST", "/api/v1/batch/photos/delete", `{"photos": []}`)
 		val := gjson.Get(r.Body.String(), "error")
-		assert.Equal(t, i18n.Msg(i18n.ErrFeatureDisabled), val.String())
-		assert.Equal(t, http.StatusForbidden, r.Code)
+		assert.Equal(t, i18n.Msg(i18n.ErrNoItemsSelected), val.String())
+		assert.Equal(t, http.StatusBadRequest, r.Code)
 	})
 }

internal/config/client_config_test.go

@@ -101,7 +101,7 @@ func TestConfig_ClientRoleConfig(t *testing.T) {
 			Account:   true,
 			Albums:    true,
 			Archive:   true,
-			Delete:    false,
+			Delete:    true,
 			Download:  true,
 			Edit:      true,
 			Estimates: true,
@@ -226,7 +226,7 @@ func TestConfig_ClientSessionConfig(t *testing.T) {
 		assert.True(t, f.Upload)
 		assert.True(t, f.Download)
 		assert.True(t, f.Services)
-		assert.False(t, f.Delete)
+		assert.True(t, f.Delete)
 		assert.True(t, f.Import)
 		assert.True(t, f.Library)
 		assert.True(t, f.Logs)
@@ -317,7 +317,7 @@ func TestConfig_ClientSessionConfig(t *testing.T) {
 		assert.True(t, f.Upload)
 		assert.True(t, f.Download)
 		assert.True(t, f.Services)
-		assert.False(t, f.Delete)
+		assert.True(t, f.Delete)
 		assert.True(t, f.Import)
 		assert.True(t, f.Library)
 		assert.True(t, f.Logs)

internal/customize/acl_test.go

@@ -18,7 +18,7 @@ func TestSettings_ApplyACL(t *testing.T) {
 			Account:   true,
 			Albums:    true,
 			Archive:   true,
-			Delete:    false,
+			Delete:    true,
 			Download:  true,
 			Edit:      true,
 			Estimates: true,

internal/customize/settings.go

@@ -77,7 +77,7 @@ func NewSettings(theme, lang string) *Settings {
 			Settings:  true,
 			Services:  true,
 			Account:   true,
-			Delete:    false,
+			Delete:    true,
 		},
 		Import: ImportSettings{
 			Path: RootPath,

internal/customize/testdata/settings.yml

@@ -13,7 +13,7 @@ Features:
   Account: true
   Albums: true
   Archive: true
-  Delete: false
+  Delete: true
   Download: true
   Edit: true
   Estimates: true