diff --git a/pkg/txt/separator_test.go b/pkg/txt/separator_test.go new file mode 100644 index 000000000..0e4919a82 --- /dev/null +++ b/pkg/txt/separator_test.go @@ -0,0 +1,34 @@ +package txt + +import ( + "testing" + + "github.com/stretchr/testify/assert" +) + +func TestIsSeparator(t *testing.T) { + t.Run("rune A", func(t *testing.T) { + assert.Equal(t, false, isSeparator('A')) + }) + t.Run("rune 99", func(t *testing.T) { + assert.Equal(t, false, isSeparator('9')) + }) + t.Run("rune /", func(t *testing.T) { + assert.Equal(t, true, isSeparator('/')) + }) + t.Run("rune \\", func(t *testing.T) { + assert.Equal(t, true, isSeparator('\\')) + }) + t.Run("rune ♥ ", func(t *testing.T) { + assert.Equal(t, false, isSeparator('♥')) + }) + t.Run("rune space", func(t *testing.T) { + assert.Equal(t, true, isSeparator(' ')) + }) + t.Run("rune '", func(t *testing.T) { + assert.Equal(t, false, isSeparator('\'')) + }) + t.Run("rune ý", func(t *testing.T) { + assert.Equal(t, false, isSeparator('ý')) + }) +} diff --git a/pkg/txt/shortwords.go b/pkg/txt/shortwords.go index e9e3770ee..c13979510 100644 --- a/pkg/txt/shortwords.go +++ b/pkg/txt/shortwords.go @@ -1397,6 +1397,7 @@ var ShortWords = map[string]bool{ "low": true, "lox": true, "lp": true, + "lpg": true, "lpm": true, "lr": true, "ls": true, diff --git a/pkg/txt/smallwords.go b/pkg/txt/smallwords.go index 6ad37a7fc..08e609062 100644 --- a/pkg/txt/smallwords.go +++ b/pkg/txt/smallwords.go @@ -35,6 +35,7 @@ var SmallWords = map[string]bool{ "und": true, "uns": true, "des": true, + "van": true, "von": true, "für": true, "ein": true, diff --git a/pkg/txt/title.go b/pkg/txt/title.go index f77430e40..52ca7db88 100644 --- a/pkg/txt/title.go +++ b/pkg/txt/title.go @@ -29,7 +29,7 @@ func Title(s string) string { if match, ok := SpecialWords[search]; ok { words[i] = strings.Replace(strings.ToLower(w), search, match, 1) - } else if i > 0 && SmallWords[search] { + } else if i > 0 && SmallWords[search] == true { words[i] = strings.ToLower(w) } else { prev := ' ' diff --git a/pkg/txt/uppercase_test.go b/pkg/txt/title_test.go similarity index 69% rename from pkg/txt/uppercase_test.go rename to pkg/txt/title_test.go index 6a738d39a..c18dd06a9 100644 --- a/pkg/txt/uppercase_test.go +++ b/pkg/txt/title_test.go @@ -6,48 +6,6 @@ import ( "github.com/stretchr/testify/assert" ) -func TestIsSeparator(t *testing.T) { - t.Run("rune A", func(t *testing.T) { - assert.Equal(t, false, isSeparator('A')) - }) - t.Run("rune 99", func(t *testing.T) { - assert.Equal(t, false, isSeparator('9')) - }) - t.Run("rune /", func(t *testing.T) { - assert.Equal(t, true, isSeparator('/')) - }) - t.Run("rune \\", func(t *testing.T) { - assert.Equal(t, true, isSeparator('\\')) - }) - t.Run("rune ♥ ", func(t *testing.T) { - assert.Equal(t, false, isSeparator('♥')) - }) - t.Run("rune space", func(t *testing.T) { - assert.Equal(t, true, isSeparator(' ')) - }) - t.Run("rune '", func(t *testing.T) { - assert.Equal(t, false, isSeparator('\'')) - }) - t.Run("rune ý", func(t *testing.T) { - assert.Equal(t, false, isSeparator('ý')) - }) -} - -func TestUcFirst(t *testing.T) { - t.Run("photo-lover", func(t *testing.T) { - assert.Equal(t, "Photo-lover", UpperFirst("photo-lover")) - }) - t.Run("cat", func(t *testing.T) { - assert.Equal(t, "Cat", UpperFirst("Cat")) - }) - t.Run("KwaZulu natal", func(t *testing.T) { - assert.Equal(t, "KwaZulu Natal", Title("KwaZulu natal")) - }) - t.Run("empty string", func(t *testing.T) { - assert.Equal(t, "", UpperFirst("")) - }) -} - func TestTitle(t *testing.T) { t.Run("Cour d'Honneur", func(t *testing.T) { assert.Equal(t, "Cour d'Honneur", Title("Cour d'Honneur")) @@ -107,4 +65,7 @@ func TestTitle(t *testing.T) { t.Run("NYC", func(t *testing.T) { assert.Equal(t, "NYC, NY - LonDon, UK - NYC, NY and London, UK.", Title("NYC, NY - LonDon, UK - Nyc, Ny and London, Uk.")) }) + t.Run("KoosVanDriemond", func(t *testing.T) { + assert.Equal(t, "Koos van Driemond", Title("Koos van Driemond")) + }) } diff --git a/pkg/txt/uppercase.go b/pkg/txt/upperfirst.go similarity index 100% rename from pkg/txt/uppercase.go rename to pkg/txt/upperfirst.go diff --git a/pkg/txt/upperfirst_test.go b/pkg/txt/upperfirst_test.go new file mode 100644 index 000000000..3adcec60a --- /dev/null +++ b/pkg/txt/upperfirst_test.go @@ -0,0 +1,22 @@ +package txt + +import ( + "testing" + + "github.com/stretchr/testify/assert" +) + +func TestUcFirst(t *testing.T) { + t.Run("photo-lover", func(t *testing.T) { + assert.Equal(t, "Photo-lover", UpperFirst("photo-lover")) + }) + t.Run("cat", func(t *testing.T) { + assert.Equal(t, "Cat", UpperFirst("Cat")) + }) + t.Run("KwaZulu natal", func(t *testing.T) { + assert.Equal(t, "KwaZulu natal", UpperFirst("KwaZulu natal")) + }) + t.Run("empty string", func(t *testing.T) { + assert.Equal(t, "", UpperFirst("")) + }) +}