From c72ddbedcb6afb0e4c207e83d81b537d8303fd45 Mon Sep 17 00:00:00 2001
From: Theresa Gresch <theresagresch@gmail.com>
Date: Tue, 20 Oct 2020 10:07:27 +0200
Subject: [PATCH] Backend: Add unit tests

---
 internal/entity/file_test.go   | 10 ----------
 internal/entity/photo_test.go  | 11 -----------
 internal/form/feedback_test.go | 17 +++++++++++++++++
 internal/meta/keywords_test.go | 10 ++++++++++
 internal/meta/sanitize_test.go | 16 ++++++++++++++++
 internal/query/errors_test.go  | 27 ++++++++++++++++++++++-----
 6 files changed, 65 insertions(+), 26 deletions(-)
 create mode 100644 internal/form/feedback_test.go

diff --git a/internal/entity/file_test.go b/internal/entity/file_test.go
index a13d40105..b00a9a598 100644
--- a/internal/entity/file_test.go
+++ b/internal/entity/file_test.go
@@ -260,16 +260,6 @@ func TestFile_Panorama(t *testing.T) {
 	})
 }
 
-/*func TestFile_PrimaryFile(t *testing.T) {
-	t.Run("return primary file", func(t *testing.T) {
-		file, err := PrimaryFile("pt9jtdre2lvl0y11")
-		if err != nil {
-			t.Fatal(err)
-		}
-		assert.Equal(t, "ft8es39w45bnlqdw", file.FileUID)
-	})
-}*/
-
 func TestFile_Delete(t *testing.T) {
 	t.Run("permanently", func(t *testing.T) {
 		file := &File{FileType: "jpg", FileSize: 500, FileName: "ToBePermanentlyDeleted", FileRoot: "", PhotoID: 5678}
diff --git a/internal/entity/photo_test.go b/internal/entity/photo_test.go
index 2b5efb138..8f3947865 100644
--- a/internal/entity/photo_test.go
+++ b/internal/entity/photo_test.go
@@ -899,14 +899,3 @@ func TestPhoto_Links(t *testing.T) {
 		assert.Equal(t, "7jxf3jfn2k", links[0].LinkToken)
 	})
 }
-
-/*func TestPhoto_PrimaryFile(t *testing.T) {
-	t.Run("return", func(t *testing.T) {
-		photo := PhotoFixtures.Pointer("Photo04")
-		file, err := photo.PrimaryFile()
-		if err != nil {
-			t.Fatal(err)
-		}
-		assert.Equal(t, "ft8es39w45bnlqdw", file.FileUID)
-	})
-}*/
diff --git a/internal/form/feedback_test.go b/internal/form/feedback_test.go
new file mode 100644
index 000000000..7de7942ed
--- /dev/null
+++ b/internal/form/feedback_test.go
@@ -0,0 +1,17 @@
+package form
+
+import (
+	"github.com/stretchr/testify/assert"
+	"testing"
+)
+
+func TestFeedback_Empty(t *testing.T) {
+	t.Run("true", func(t *testing.T) {
+		feedback := Feedback{}
+		assert.True(t, feedback.Empty())
+	})
+	t.Run("false", func(t *testing.T) {
+		feedback := Feedback{Message: "I found a bug", Category: "Bug Report", UserEmail: "test@test.com"}
+		assert.False(t, feedback.Empty())
+	})
+}
diff --git a/internal/meta/keywords_test.go b/internal/meta/keywords_test.go
index dae3861e3..1b90feb95 100644
--- a/internal/meta/keywords_test.go
+++ b/internal/meta/keywords_test.go
@@ -52,4 +52,14 @@ func TestData_AutoAddKeywords(t *testing.T) {
 
 		assert.Equal(t, "", data.Keywords)
 	})
+
+	t.Run("ignore because too short", func(t *testing.T) {
+		data := NewData()
+
+		assert.Equal(t, "", data.Keywords)
+
+		data.AutoAddKeywords("es")
+
+		assert.Equal(t, "", data.Keywords)
+	})
 }
diff --git a/internal/meta/sanitize_test.go b/internal/meta/sanitize_test.go
index 4f58194c4..0bfe76c92 100644
--- a/internal/meta/sanitize_test.go
+++ b/internal/meta/sanitize_test.go
@@ -137,3 +137,19 @@ func TestSanitizeDescription(t *testing.T) {
 		}
 	})
 }
+
+func TestSanitizeUID(t *testing.T) {
+	t.Run("77d9a719ede3f95915abd081d7b7cb2c", func(t *testing.T) {
+		result := SanitizeUID("77d9a719ede3f95915abd081d7b7CB2c")
+		assert.Equal(t, "77d9a719ede3f95915abd081d7b7cb2c", result)
+	})
+	t.Run("77d", func(t *testing.T) {
+		result := SanitizeUID("77d")
+		assert.Equal(t, "", result)
+	})
+	t.Run(":77d9a719ede3f95915abd081d7b7cb2c", func(t *testing.T) {
+		result := SanitizeUID(":77d9a719ede3f95915abd081d7b7CB2c")
+		assert.Equal(t, "77d9a719ede3f95915abd081d7b7cb2c", result)
+	})
+
+}
diff --git a/internal/query/errors_test.go b/internal/query/errors_test.go
index a6e9aeb45..378ed25f3 100644
--- a/internal/query/errors_test.go
+++ b/internal/query/errors_test.go
@@ -6,9 +6,26 @@ import (
 )
 
 func TestErrors(t *testing.T) {
-	errors, err := Errors(1000, 0, "notexistingErrorString")
-	if err != nil {
-		t.Fatal(err)
-	}
-	assert.Empty(t, errors)
+	t.Run("not existing", func(t *testing.T) {
+		errors, err := Errors(1000, 0, "notexistingErrorString")
+		if err != nil {
+			t.Fatal(err)
+		}
+		assert.Empty(t, errors)
+	})
+	t.Run("error", func(t *testing.T) {
+		errors, err := Errors(1000, 0, "error")
+		if err != nil {
+			t.Fatal(err)
+		}
+		assert.Empty(t, errors)
+	})
+	t.Run("warning", func(t *testing.T) {
+		errors, err := Errors(1000, 0, "warning")
+		if err != nil {
+			t.Fatal(err)
+		}
+		assert.Empty(t, errors)
+	})
+
 }