3765 lines
110 KiB
Diff
3765 lines
110 KiB
Diff
|
From c10c028151ea853e1529ad7d828a9600b4060825 Mon Sep 17 00:00:00 2001
|
||
|
From: Daniel Scally <djrscally@gmail.com>
|
||
|
Date: Mon, 22 Feb 2021 13:07:30 +0000
|
||
|
Subject: [PATCH] ACPI: scan: Extend acpi_walk_dep_device_list()
|
||
|
|
||
|
The acpi_walk_dep_device_list() is not as generalisable as its name
|
||
|
implies, serving only to decrement the dependency count for each
|
||
|
dependent device of the input. Extend the function to instead accept
|
||
|
a callback which can be applied to all the dependencies in acpi_dep_list.
|
||
|
Replace all existing calls to the function with calls to a wrapper, passing
|
||
|
a callback that applies the same dependency reduction.
|
||
|
|
||
|
Suggested-by: Rafael J. Wysocki <rafael@kernel.org>
|
||
|
Signed-off-by: Daniel Scally <djrscally@gmail.com>
|
||
|
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
|
||
|
Acked-by: Wolfram Sang <wsa@kernel.org> # for changing I2C core
|
||
|
Patchset: cameras
|
||
|
---
|
||
|
drivers/acpi/ec.c | 2 +-
|
||
|
drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 2 +-
|
||
|
drivers/acpi/scan.c | 58 +++++++++++++------
|
||
|
drivers/gpio/gpiolib-acpi.c | 2 +-
|
||
|
drivers/i2c/i2c-core-acpi.c | 2 +-
|
||
|
drivers/platform/surface/aggregator/core.c | 2 +-
|
||
|
drivers/platform/surface/surface3_power.c | 2 +-
|
||
|
.../platform/surface/surface_acpi_notify.c | 2 +-
|
||
|
include/acpi/acpi_bus.h | 7 +++
|
||
|
include/linux/acpi.h | 4 +-
|
||
|
10 files changed, 57 insertions(+), 26 deletions(-)
|
||
|
|
||
|
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
|
||
|
index 13565629ce0a..a258db713bd2 100644
|
||
|
--- a/drivers/acpi/ec.c
|
||
|
+++ b/drivers/acpi/ec.c
|
||
|
@@ -1627,7 +1627,7 @@ static int acpi_ec_add(struct acpi_device *device)
|
||
|
WARN(!ret, "Could not request EC cmd io port 0x%lx", ec->command_addr);
|
||
|
|
||
|
/* Reprobe devices depending on the EC */
|
||
|
- acpi_walk_dep_device_list(ec->handle);
|
||
|
+ acpi_dev_flag_dependency_met(ec->handle);
|
||
|
|
||
|
acpi_handle_debug(ec->handle, "enumerated.\n");
|
||
|
return 0;
|
||
|
diff --git a/drivers/acpi/pmic/intel_pmic_chtdc_ti.c b/drivers/acpi/pmic/intel_pmic_chtdc_ti.c
|
||
|
index a5101b07611a..59cca504325e 100644
|
||
|
--- a/drivers/acpi/pmic/intel_pmic_chtdc_ti.c
|
||
|
+++ b/drivers/acpi/pmic/intel_pmic_chtdc_ti.c
|
||
|
@@ -117,7 +117,7 @@ static int chtdc_ti_pmic_opregion_probe(struct platform_device *pdev)
|
||
|
return err;
|
||
|
|
||
|
/* Re-enumerate devices depending on PMIC */
|
||
|
- acpi_walk_dep_device_list(ACPI_HANDLE(pdev->dev.parent));
|
||
|
+ acpi_dev_flag_dependency_met(ACPI_HANDLE(pdev->dev.parent));
|
||
|
return 0;
|
||
|
}
|
||
|
|
||
|
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
|
||
|
index 6efe7edd7b1e..44e4783d8e95 100644
|
||
|
--- a/drivers/acpi/scan.c
|
||
|
+++ b/drivers/acpi/scan.c
|
||
|
@@ -47,12 +47,6 @@ static DEFINE_MUTEX(acpi_hp_context_lock);
|
||
|
*/
|
||
|
static u64 spcr_uart_addr;
|
||
|
|
||
|
-struct acpi_dep_data {
|
||
|
- struct list_head node;
|
||
|
- acpi_handle supplier;
|
||
|
- acpi_handle consumer;
|
||
|
-};
|
||
|
-
|
||
|
void acpi_scan_lock_acquire(void)
|
||
|
{
|
||
|
mutex_lock(&acpi_scan_lock);
|
||
|
@@ -2141,30 +2135,58 @@ static void acpi_bus_attach(struct acpi_device *device, bool first_pass)
|
||
|
device->handler->hotplug.notify_online(device);
|
||
|
}
|
||
|
|
||
|
-void acpi_walk_dep_device_list(acpi_handle handle)
|
||
|
+static int __acpi_dev_flag_dependency_met(struct acpi_dep_data *dep,
|
||
|
+ void *data)
|
||
|
{
|
||
|
- struct acpi_dep_data *dep, *tmp;
|
||
|
struct acpi_device *adev;
|
||
|
|
||
|
+ acpi_bus_get_device(dep->consumer, &adev);
|
||
|
+
|
||
|
+ if (adev) {
|
||
|
+ adev->dep_unmet--;
|
||
|
+ if (!adev->dep_unmet)
|
||
|
+ acpi_bus_attach(adev, true);
|
||
|
+ }
|
||
|
+
|
||
|
+ list_del(&dep->node);
|
||
|
+ kfree(dep);
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+void acpi_walk_dep_device_list(acpi_handle handle,
|
||
|
+ int (*callback)(struct acpi_dep_data *, void *),
|
||
|
+ void *data)
|
||
|
+{
|
||
|
+ struct acpi_dep_data *dep, *tmp;
|
||
|
+ int ret;
|
||
|
+
|
||
|
mutex_lock(&acpi_dep_list_lock);
|
||
|
list_for_each_entry_safe(dep, tmp, &acpi_dep_list, node) {
|
||
|
if (dep->supplier == handle) {
|
||
|
- acpi_bus_get_device(dep->consumer, &adev);
|
||
|
-
|
||
|
- if (adev) {
|
||
|
- adev->dep_unmet--;
|
||
|
- if (!adev->dep_unmet)
|
||
|
- acpi_bus_attach(adev, true);
|
||
|
- }
|
||
|
-
|
||
|
- list_del(&dep->node);
|
||
|
- kfree(dep);
|
||
|
+ ret = callback(dep, data);
|
||
|
+ if (ret)
|
||
|
+ break;
|
||
|
}
|
||
|
}
|
||
|
mutex_unlock(&acpi_dep_list_lock);
|
||
|
}
|
||
|
EXPORT_SYMBOL_GPL(acpi_walk_dep_device_list);
|
||
|
|
||
|
+/**
|
||
|
+ * acpi_dev_flag_dependency_met() - Inform consumers of @handle that the device
|
||
|
+ * is now active
|
||
|
+ * @handle: acpi_handle for the supplier device
|
||
|
+ *
|
||
|
+ * This function walks through the dependencies list and informs each consumer
|
||
|
+ * of @handle that their dependency upon it is now met. Devices with no more
|
||
|
+ * unmet dependencies will be attached to the acpi bus.
|
||
|
+ */
|
||
|
+void acpi_dev_flag_dependency_met(acpi_handle handle)
|
||
|
+{
|
||
|
+ acpi_walk_dep_device_list(handle, __acpi_dev_flag_dependency_met, NULL);
|
||
|
+}
|
||
|
+EXPORT_SYMBOL_GPL(acpi_dev_flag_dependency_met);
|
||
|
+
|
||
|
/**
|
||
|
* acpi_bus_scan - Add ACPI device node objects in a given namespace scope.
|
||
|
* @handle: Root of the namespace scope to scan.
|
||
|
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
|
||
|
index 1aacd2a5a1fd..4a16e0d9b257 100644
|
||
|
--- a/drivers/gpio/gpiolib-acpi.c
|
||
|
+++ b/drivers/gpio/gpiolib-acpi.c
|
||
|
@@ -1263,7 +1263,7 @@ void acpi_gpiochip_add(struct gpio_chip *chip)
|
||
|
|
||
|
acpi_gpiochip_request_regions(acpi_gpio);
|
||
|
acpi_gpiochip_scan_gpios(acpi_gpio);
|
||
|
- acpi_walk_dep_device_list(handle);
|
||
|
+ acpi_dev_flag_dependency_met(handle);
|
||
|
}
|
||
|
|
||
|
void acpi_gpiochip_remove(struct gpio_chip *chip)
|
||
|
diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c
|
||
|
index deceed0d76c6..1e7ae3421de1 100644
|
||
|
--- a/drivers/i2c/i2c-core-acpi.c
|
||
|
+++ b/drivers/i2c/i2c-core-acpi.c
|
||
|
@@ -279,7 +279,7 @@ void i2c_acpi_register_devices(struct i2c_adapter *adap)
|
||
|
if (!handle)
|
||
|
return;
|
||
|
|
||
|
- acpi_walk_dep_device_list(handle);
|
||
|
+ acpi_dev_flag_dependency_met(handle);
|
||
|
}
|
||
|
|
||
|
static const struct acpi_device_id i2c_acpi_force_400khz_device_ids[] = {
|
||
|
diff --git a/drivers/platform/surface/aggregator/core.c b/drivers/platform/surface/aggregator/core.c
|
||
|
index 8dc2c267bcd6..f8c691720caf 100644
|
||
|
--- a/drivers/platform/surface/aggregator/core.c
|
||
|
+++ b/drivers/platform/surface/aggregator/core.c
|
||
|
@@ -706,7 +706,7 @@ static int ssam_serial_hub_probe(struct serdev_device *serdev)
|
||
|
* For now let's thus default power/wakeup to false.
|
||
|
*/
|
||
|
device_set_wakeup_capable(&serdev->dev, true);
|
||
|
- acpi_walk_dep_device_list(ssh);
|
||
|
+ acpi_dev_flag_dependency_met(ssh);
|
||
|
|
||
|
return 0;
|
||
|
|
||
|
diff --git a/drivers/platform/surface/surface3_power.c b/drivers/platform/surface/surface3_power.c
|
||
|
index cc4f9cba6856..ad895285d3e9 100644
|
||
|
--- a/drivers/platform/surface/surface3_power.c
|
||
|
+++ b/drivers/platform/surface/surface3_power.c
|
||
|
@@ -478,7 +478,7 @@ static int mshw0011_install_space_handler(struct i2c_client *client)
|
||
|
return -ENOMEM;
|
||
|
}
|
||
|
|
||
|
- acpi_walk_dep_device_list(handle);
|
||
|
+ acpi_dev_flag_dependency_met(handle);
|
||
|
return 0;
|
||
|
}
|
||
|
|
||
|
diff --git a/drivers/platform/surface/surface_acpi_notify.c b/drivers/platform/surface/surface_acpi_notify.c
|
||
|
index ef9c1f8e8336..e18dc4e30af2 100644
|
||
|
--- a/drivers/platform/surface/surface_acpi_notify.c
|
||
|
+++ b/drivers/platform/surface/surface_acpi_notify.c
|
||
|
@@ -835,7 +835,7 @@ static int san_probe(struct platform_device *pdev)
|
||
|
if (status)
|
||
|
goto err_install_dev;
|
||
|
|
||
|
- acpi_walk_dep_device_list(san);
|
||
|
+ acpi_dev_flag_dependency_met(san);
|
||
|
return 0;
|
||
|
|
||
|
err_install_dev:
|
||
|
diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
|
||
|
index f28b097c658f..128eec2a26f6 100644
|
||
|
--- a/include/acpi/acpi_bus.h
|
||
|
+++ b/include/acpi/acpi_bus.h
|
||
|
@@ -279,6 +279,12 @@ struct acpi_device_power {
|
||
|
struct acpi_device_power_state states[ACPI_D_STATE_COUNT]; /* Power states (D0-D3Cold) */
|
||
|
};
|
||
|
|
||
|
+struct acpi_dep_data {
|
||
|
+ struct list_head node;
|
||
|
+ acpi_handle supplier;
|
||
|
+ acpi_handle consumer;
|
||
|
+};
|
||
|
+
|
||
|
/* Performance Management */
|
||
|
|
||
|
struct acpi_device_perf_flags {
|
||
|
@@ -684,6 +690,7 @@ static inline bool acpi_device_can_poweroff(struct acpi_device *adev)
|
||
|
|
||
|
bool acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2, const char *uid2);
|
||
|
|
||
|
+void acpi_dev_flag_dependency_met(acpi_handle handle);
|
||
|
struct acpi_device *
|
||
|
acpi_dev_get_next_match_dev(struct acpi_device *adev, const char *hid, const char *uid, s64 hrv);
|
||
|
struct acpi_device *
|
||
|
diff --git a/include/linux/acpi.h b/include/linux/acpi.h
|
||
|
index 3bdcfc4401b7..b560e47b700c 100644
|
||
|
--- a/include/linux/acpi.h
|
||
|
+++ b/include/linux/acpi.h
|
||
|
@@ -666,7 +666,9 @@ extern bool acpi_driver_match_device(struct device *dev,
|
||
|
const struct device_driver *drv);
|
||
|
int acpi_device_uevent_modalias(struct device *, struct kobj_uevent_env *);
|
||
|
int acpi_device_modalias(struct device *, char *, int);
|
||
|
-void acpi_walk_dep_device_list(acpi_handle handle);
|
||
|
+void acpi_walk_dep_device_list(acpi_handle handle,
|
||
|
+ int (*callback)(struct acpi_dep_data *, void *),
|
||
|
+ void *data);
|
||
|
|
||
|
struct platform_device *acpi_create_platform_device(struct acpi_device *,
|
||
|
struct property_entry *);
|
||
|
--
|
||
|
2.31.1
|
||
|
|
||
|
From 48ca31919b84fcc1456e0f86292b95bda1a74b81 Mon Sep 17 00:00:00 2001
|
||
|
From: Daniel Scally <djrscally@gmail.com>
|
||
|
Date: Mon, 22 Feb 2021 13:07:31 +0000
|
||
|
Subject: [PATCH] ACPI: scan: Add function to fetch dependent of acpi device
|
||
|
|
||
|
In some ACPI tables we encounter, devices use the _DEP method to assert
|
||
|
a dependence on other ACPI devices as opposed to the OpRegions that the
|
||
|
specification intends. We need to be able to find those devices "from"
|
||
|
the dependee, so add a callback and a wrapper to walk over the
|
||
|
acpi_dep_list and return the dependent ACPI device.
|
||
|
|
||
|
Signed-off-by: Daniel Scally <djrscally@gmail.com>
|
||
|
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
|
||
|
Patchset: cameras
|
||
|
---
|
||
|
drivers/acpi/scan.c | 34 ++++++++++++++++++++++++++++++++++
|
||
|
include/acpi/acpi_bus.h | 1 +
|
||
|
2 files changed, 35 insertions(+)
|
||
|
|
||
|
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
|
||
|
index 44e4783d8e95..a4735a479249 100644
|
||
|
--- a/drivers/acpi/scan.c
|
||
|
+++ b/drivers/acpi/scan.c
|
||
|
@@ -2135,6 +2135,21 @@ static void acpi_bus_attach(struct acpi_device *device, bool first_pass)
|
||
|
device->handler->hotplug.notify_online(device);
|
||
|
}
|
||
|
|
||
|
+static int __acpi_dev_get_dependent_dev(struct acpi_dep_data *dep, void *data)
|
||
|
+{
|
||
|
+ struct acpi_device *adev;
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ ret = acpi_bus_get_device(dep->consumer, &adev);
|
||
|
+ if (ret)
|
||
|
+ /* If we don't find an adev then we want to continue parsing */
|
||
|
+ return 0;
|
||
|
+
|
||
|
+ *(struct acpi_device **)data = adev;
|
||
|
+
|
||
|
+ return 1;
|
||
|
+}
|
||
|
+
|
||
|
static int __acpi_dev_flag_dependency_met(struct acpi_dep_data *dep,
|
||
|
void *data)
|
||
|
{
|
||
|
@@ -2187,6 +2202,25 @@ void acpi_dev_flag_dependency_met(acpi_handle handle)
|
||
|
}
|
||
|
EXPORT_SYMBOL_GPL(acpi_dev_flag_dependency_met);
|
||
|
|
||
|
+/**
|
||
|
+ * acpi_dev_get_dependent_dev - Return ACPI device dependent on @adev
|
||
|
+ * @adev: Pointer to the dependee device
|
||
|
+ *
|
||
|
+ * Returns the first &struct acpi_device which declares itself dependent on
|
||
|
+ * @adev via the _DEP buffer, parsed from the acpi_dep_list.
|
||
|
+ */
|
||
|
+struct acpi_device *
|
||
|
+acpi_dev_get_dependent_dev(struct acpi_device *supplier)
|
||
|
+{
|
||
|
+ struct acpi_device *adev = NULL;
|
||
|
+
|
||
|
+ acpi_walk_dep_device_list(supplier->handle,
|
||
|
+ __acpi_dev_get_dependent_dev, &adev);
|
||
|
+
|
||
|
+ return adev;
|
||
|
+}
|
||
|
+EXPORT_SYMBOL_GPL(acpi_dev_get_dependent_dev);
|
||
|
+
|
||
|
/**
|
||
|
* acpi_bus_scan - Add ACPI device node objects in a given namespace scope.
|
||
|
* @handle: Root of the namespace scope to scan.
|
||
|
diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
|
||
|
index 128eec2a26f6..d00dec1ad9fb 100644
|
||
|
--- a/include/acpi/acpi_bus.h
|
||
|
+++ b/include/acpi/acpi_bus.h
|
||
|
@@ -691,6 +691,7 @@ static inline bool acpi_device_can_poweroff(struct acpi_device *adev)
|
||
|
bool acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2, const char *uid2);
|
||
|
|
||
|
void acpi_dev_flag_dependency_met(acpi_handle handle);
|
||
|
+struct acpi_device *acpi_dev_get_dependent_dev(struct acpi_device *supplier);
|
||
|
struct acpi_device *
|
||
|
acpi_dev_get_next_match_dev(struct acpi_device *adev, const char *hid, const char *uid, s64 hrv);
|
||
|
struct acpi_device *
|
||
|
--
|
||
|
2.31.1
|
||
|
|
||
|
From c861065d78420ea39fec121e4cd9081fde790aa8 Mon Sep 17 00:00:00 2001
|
||
|
From: Daniel Scally <djrscally@gmail.com>
|
||
|
Date: Mon, 22 Feb 2021 13:07:32 +0000
|
||
|
Subject: [PATCH] i2c: core: Add a format macro for I2C device names
|
||
|
|
||
|
Some places in the kernel allow users to map resources to a device
|
||
|
using device name (for example, in the struct gpiod_lookup_table).
|
||
|
Currently this involves waiting for the I2C client to have been registered
|
||
|
so we can use dev_name(&client->dev). We want to add a function to allow
|
||
|
users to refer to an I2C device by name before it has been instantiated,
|
||
|
so create a macro for the format that's accessible outside the I2C layer
|
||
|
and use it in i2c_dev_set_name().
|
||
|
|
||
|
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
|
||
|
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
|
||
|
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
|
||
|
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
|
||
|
Signed-off-by: Daniel Scally <djrscally@gmail.com>
|
||
|
Acked-by: Wolfram Sang <wsa@kernel.org> # for changing I2C core
|
||
|
Patchset: cameras
|
||
|
---
|
||
|
drivers/i2c/i2c-core-base.c | 4 ++--
|
||
|
include/linux/i2c.h | 3 +++
|
||
|
2 files changed, 5 insertions(+), 2 deletions(-)
|
||
|
|
||
|
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
|
||
|
index f21362355973..e2cf16f27d65 100644
|
||
|
--- a/drivers/i2c/i2c-core-base.c
|
||
|
+++ b/drivers/i2c/i2c-core-base.c
|
||
|
@@ -812,12 +812,12 @@ static void i2c_dev_set_name(struct i2c_adapter *adap,
|
||
|
struct acpi_device *adev = ACPI_COMPANION(&client->dev);
|
||
|
|
||
|
if (info && info->dev_name) {
|
||
|
- dev_set_name(&client->dev, "i2c-%s", info->dev_name);
|
||
|
+ dev_set_name(&client->dev, I2C_DEV_NAME_FORMAT, info->dev_name);
|
||
|
return;
|
||
|
}
|
||
|
|
||
|
if (adev) {
|
||
|
- dev_set_name(&client->dev, "i2c-%s", acpi_dev_name(adev));
|
||
|
+ dev_set_name(&client->dev, I2C_DEV_NAME_FORMAT, acpi_dev_name(adev));
|
||
|
return;
|
||
|
}
|
||
|
|
||
|
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
|
||
|
index 56622658b215..4d40a4b46810 100644
|
||
|
--- a/include/linux/i2c.h
|
||
|
+++ b/include/linux/i2c.h
|
||
|
@@ -39,6 +39,9 @@ enum i2c_slave_event;
|
||
|
typedef int (*i2c_slave_cb_t)(struct i2c_client *client,
|
||
|
enum i2c_slave_event event, u8 *val);
|
||
|
|
||
|
+/* I2C Device Name Format - to maintain consistency outside the i2c layer */
|
||
|
+#define I2C_DEV_NAME_FORMAT "i2c-%s"
|
||
|
+
|
||
|
/* I2C Frequency Modes */
|
||
|
#define I2C_MAX_STANDARD_MODE_FREQ 100000
|
||
|
#define I2C_MAX_FAST_MODE_FREQ 400000
|
||
|
--
|
||
|
2.31.1
|
||
|
|
||
|
From e39f06db39a488efd95244f07c02672e510edc25 Mon Sep 17 00:00:00 2001
|
||
|
From: Daniel Scally <djrscally@gmail.com>
|
||
|
Date: Mon, 22 Feb 2021 13:07:33 +0000
|
||
|
Subject: [PATCH] gpiolib: acpi: Export acpi_get_gpiod()
|
||
|
|
||
|
I need to be able to translate GPIO resources in an ACPI device's _CRS
|
||
|
into GPIO descriptor array. Those are represented in _CRS as a pathname
|
||
|
to a GPIO device plus the pin's index number: this function is perfect
|
||
|
for that purpose.
|
||
|
|
||
|
As it's currently only used internally within the GPIO layer, provide and
|
||
|
export a wrapper function that additionally holds a reference to the GPIO
|
||
|
device.
|
||
|
|
||
|
Signed-off-by: Daniel Scally <djrscally@gmail.com>
|
||
|
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
|
||
|
Patchset: cameras
|
||
|
---
|
||
|
drivers/gpio/gpiolib-acpi.c | 36 +++++++++++++++++++++++++++++++----
|
||
|
include/linux/gpio/consumer.h | 7 +++++++
|
||
|
2 files changed, 39 insertions(+), 4 deletions(-)
|
||
|
|
||
|
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
|
||
|
index 4a16e0d9b257..5f99d698f60d 100644
|
||
|
--- a/drivers/gpio/gpiolib-acpi.c
|
||
|
+++ b/drivers/gpio/gpiolib-acpi.c
|
||
|
@@ -102,7 +102,8 @@ static int acpi_gpiochip_find(struct gpio_chip *gc, void *data)
|
||
|
}
|
||
|
|
||
|
/**
|
||
|
- * acpi_get_gpiod() - Translate ACPI GPIO pin to GPIO descriptor usable with GPIO API
|
||
|
+ * __acpi_get_gpiod() - Translate ACPI GPIO pin to GPIO descriptor usable with
|
||
|
+ * GPIO API
|
||
|
* @path: ACPI GPIO controller full path name, (e.g. "\\_SB.GPO1")
|
||
|
* @pin: ACPI GPIO pin number (0-based, controller-relative)
|
||
|
*
|
||
|
@@ -111,7 +112,7 @@ static int acpi_gpiochip_find(struct gpio_chip *gc, void *data)
|
||
|
* controller does not have GPIO chip registered at the moment. This is to
|
||
|
* support probe deferral.
|
||
|
*/
|
||
|
-static struct gpio_desc *acpi_get_gpiod(char *path, int pin)
|
||
|
+static struct gpio_desc *__acpi_get_gpiod(char *path, int pin)
|
||
|
{
|
||
|
struct gpio_chip *chip;
|
||
|
acpi_handle handle;
|
||
|
@@ -128,6 +129,33 @@ static struct gpio_desc *acpi_get_gpiod(char *path, int pin)
|
||
|
return gpiochip_get_desc(chip, pin);
|
||
|
}
|
||
|
|
||
|
+/**
|
||
|
+ * acpi_get_gpiod() - Translate ACPI GPIO pin to GPIO descriptor usable with
|
||
|
+ * GPIO API, and hold a refcount to the GPIO device.
|
||
|
+ * @path: ACPI GPIO controller full path name, (e.g. "\\_SB.GPO1")
|
||
|
+ * @pin: ACPI GPIO pin number (0-based, controller-relative)
|
||
|
+ * @label: Label to pass to gpiod_request()
|
||
|
+ *
|
||
|
+ * This function is a simple pass-through to __acpi_get_gpiod(), except that as
|
||
|
+ * it is intended for use outside of the GPIO layer (in a similar fashion to
|
||
|
+ * gpiod_get_index() for example) it also holds a reference to the GPIO device.
|
||
|
+ */
|
||
|
+struct gpio_desc *acpi_get_gpiod(char *path, int pin, char *label)
|
||
|
+{
|
||
|
+ struct gpio_desc *gpio = __acpi_get_gpiod(path, pin);
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ if (IS_ERR(gpio))
|
||
|
+ return gpio;
|
||
|
+
|
||
|
+ ret = gpiod_request(gpio, label);
|
||
|
+ if (ret)
|
||
|
+ return ERR_PTR(ret);
|
||
|
+
|
||
|
+ return gpio;
|
||
|
+}
|
||
|
+EXPORT_SYMBOL_GPL(acpi_get_gpiod);
|
||
|
+
|
||
|
static irqreturn_t acpi_gpio_irq_handler(int irq, void *data)
|
||
|
{
|
||
|
struct acpi_gpio_event *event = data;
|
||
|
@@ -693,8 +721,8 @@ static int acpi_populate_gpio_lookup(struct acpi_resource *ares, void *data)
|
||
|
if (lookup->info.quirks & ACPI_GPIO_QUIRK_ABSOLUTE_NUMBER)
|
||
|
desc = gpio_to_desc(agpio->pin_table[pin_index]);
|
||
|
else
|
||
|
- desc = acpi_get_gpiod(agpio->resource_source.string_ptr,
|
||
|
- agpio->pin_table[pin_index]);
|
||
|
+ desc = __acpi_get_gpiod(agpio->resource_source.string_ptr,
|
||
|
+ agpio->pin_table[pin_index]);
|
||
|
lookup->desc = desc;
|
||
|
lookup->info.pin_config = agpio->pin_config;
|
||
|
lookup->info.debounce = agpio->debounce_timeout;
|
||
|
diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
|
||
|
index c73b25bc9213..e26fb586b6c8 100644
|
||
|
--- a/include/linux/gpio/consumer.h
|
||
|
+++ b/include/linux/gpio/consumer.h
|
||
|
@@ -692,6 +692,8 @@ int devm_acpi_dev_add_driver_gpios(struct device *dev,
|
||
|
const struct acpi_gpio_mapping *gpios);
|
||
|
void devm_acpi_dev_remove_driver_gpios(struct device *dev);
|
||
|
|
||
|
+struct gpio_desc *acpi_get_gpiod(char *path, int pin, char *label);
|
||
|
+
|
||
|
#else /* CONFIG_GPIOLIB && CONFIG_ACPI */
|
||
|
|
||
|
struct acpi_device;
|
||
|
@@ -710,6 +712,11 @@ static inline int devm_acpi_dev_add_driver_gpios(struct device *dev,
|
||
|
}
|
||
|
static inline void devm_acpi_dev_remove_driver_gpios(struct device *dev) {}
|
||
|
|
||
|
+struct gpio_desc *acpi_get_gpiod(char *path, int pin, char *label)
|
||
|
+{
|
||
|
+ return NULL;
|
||
|
+}
|
||
|
+
|
||
|
#endif /* CONFIG_GPIOLIB && CONFIG_ACPI */
|
||
|
|
||
|
|
||
|
--
|
||
|
2.31.1
|
||
|
|
||
|
From 478ecf8703bdcda8aab6cffc6a25b853fe00556f Mon Sep 17 00:00:00 2001
|
||
|
From: Daniel Scally <djrscally@gmail.com>
|
||
|
Date: Mon, 22 Feb 2021 13:07:34 +0000
|
||
|
Subject: [PATCH] platform/x86: Add intel_skl_int3472 driver
|
||
|
|
||
|
ACPI devices with _HID INT3472 are currently matched to the tps68470
|
||
|
driver, however this does not cover all situations in which that _HID
|
||
|
occurs. We've encountered three possibilities:
|
||
|
|
||
|
1. On Chrome OS devices, an ACPI device with _HID INT3472 (representing
|
||
|
a physical TPS68470 device) that requires a GPIO and OpRegion driver
|
||
|
2. On devices designed for Windows, an ACPI device with _HID INT3472
|
||
|
(again representing a physical TPS68470 device) which requires GPIO,
|
||
|
Clock and Regulator drivers.
|
||
|
3. On other devices designed for Windows, an ACPI device with _HID
|
||
|
INT3472 which does **not** represent a physical TPS68470, and is instead
|
||
|
used as a dummy device to group some system GPIO lines which are meant
|
||
|
to be consumed by the sensor that is dependent on this entry.
|
||
|
|
||
|
This commit adds a new module, registering a platform driver to deal
|
||
|
with the 3rd scenario plus an i2c driver to deal with #1 and #2, by
|
||
|
querying the CLDB buffer found against INT3472 entries to determine
|
||
|
which is most appropriate.
|
||
|
|
||
|
Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
|
||
|
Signed-off-by: Daniel Scally <djrscally@gmail.com>
|
||
|
Patchset: cameras
|
||
|
---
|
||
|
MAINTAINERS | 5 +
|
||
|
drivers/platform/x86/Kconfig | 2 +
|
||
|
drivers/platform/x86/Makefile | 1 +
|
||
|
drivers/platform/x86/intel-int3472/Kconfig | 31 +
|
||
|
drivers/platform/x86/intel-int3472/Makefile | 4 +
|
||
|
.../intel-int3472/intel_skl_int3472_common.c | 106 ++++
|
||
|
.../intel-int3472/intel_skl_int3472_common.h | 110 ++++
|
||
|
.../intel_skl_int3472_discrete.c | 592 ++++++++++++++++++
|
||
|
.../intel_skl_int3472_tps68470.c | 113 ++++
|
||
|
9 files changed, 964 insertions(+)
|
||
|
create mode 100644 drivers/platform/x86/intel-int3472/Kconfig
|
||
|
create mode 100644 drivers/platform/x86/intel-int3472/Makefile
|
||
|
create mode 100644 drivers/platform/x86/intel-int3472/intel_skl_int3472_common.c
|
||
|
create mode 100644 drivers/platform/x86/intel-int3472/intel_skl_int3472_common.h
|
||
|
create mode 100644 drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c
|
||
|
create mode 100644 drivers/platform/x86/intel-int3472/intel_skl_int3472_tps68470.c
|
||
|
|
||
|
diff --git a/MAINTAINERS b/MAINTAINERS
|
||
|
index 710617e26f3e..2a421d2e4b07 100644
|
||
|
--- a/MAINTAINERS
|
||
|
+++ b/MAINTAINERS
|
||
|
@@ -9191,6 +9191,11 @@ S: Maintained
|
||
|
F: arch/x86/include/asm/intel_scu_ipc.h
|
||
|
F: drivers/platform/x86/intel_scu_*
|
||
|
|
||
|
+INTEL SKYLAKE INT3472 ACPI DEVICE DRIVER
|
||
|
+M: Daniel Scally <djrscally@gmail.com>
|
||
|
+S: Maintained
|
||
|
+F: drivers/platform/x86/intel-int3472/intel_skl_int3472_*
|
||
|
+
|
||
|
INTEL SPEED SELECT TECHNOLOGY
|
||
|
M: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
|
||
|
L: platform-driver-x86@vger.kernel.org
|
||
|
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
|
||
|
index 461ec61530eb..51b258120c50 100644
|
||
|
--- a/drivers/platform/x86/Kconfig
|
||
|
+++ b/drivers/platform/x86/Kconfig
|
||
|
@@ -674,6 +674,8 @@ config INTEL_CHT_INT33FE
|
||
|
device and CONFIG_TYPEC_FUSB302=m and CONFIG_BATTERY_MAX17042=m
|
||
|
for Type-C device.
|
||
|
|
||
|
+source "drivers/platform/x86/intel-int3472/Kconfig"
|
||
|
+
|
||
|
config INTEL_HID_EVENT
|
||
|
tristate "INTEL HID Event"
|
||
|
depends on ACPI
|
||
|
diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile
|
||
|
index 60d554073749..4cbcff47a571 100644
|
||
|
--- a/drivers/platform/x86/Makefile
|
||
|
+++ b/drivers/platform/x86/Makefile
|
||
|
@@ -72,6 +72,7 @@ obj-$(CONFIG_INTEL_HID_EVENT) += intel-hid.o
|
||
|
obj-$(CONFIG_INTEL_INT0002_VGPIO) += intel_int0002_vgpio.o
|
||
|
obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.o
|
||
|
obj-$(CONFIG_INTEL_OAKTRAIL) += intel_oaktrail.o
|
||
|
+obj-$(CONFIG_INTEL_SKL_INT3472) += intel-int3472/
|
||
|
obj-$(CONFIG_INTEL_VBTN) += intel-vbtn.o
|
||
|
|
||
|
# MSI
|
||
|
diff --git a/drivers/platform/x86/intel-int3472/Kconfig b/drivers/platform/x86/intel-int3472/Kconfig
|
||
|
new file mode 100644
|
||
|
index 000000000000..b94622245c21
|
||
|
--- /dev/null
|
||
|
+++ b/drivers/platform/x86/intel-int3472/Kconfig
|
||
|
@@ -0,0 +1,31 @@
|
||
|
+config INTEL_SKL_INT3472
|
||
|
+ tristate "Intel SkyLake ACPI INT3472 Driver"
|
||
|
+ depends on ACPI
|
||
|
+ depends on REGULATOR
|
||
|
+ depends on GPIOLIB
|
||
|
+ depends on COMMON_CLK && CLKDEV_LOOKUP
|
||
|
+ depends on I2C
|
||
|
+ select MFD_CORE
|
||
|
+ select REGMAP_I2C
|
||
|
+ help
|
||
|
+ This driver adds support for the INT3472 ACPI devices found on some
|
||
|
+ Intel SkyLake devices.
|
||
|
+
|
||
|
+ The INT3472 is an Intel camera power controller, a logical device
|
||
|
+ found on some Skylake-based systems that can map to different
|
||
|
+ hardware devices depending on the platform. On machines
|
||
|
+ designed for Chrome OS, it maps to a TPS68470 camera PMIC. On
|
||
|
+ machines designed for Windows, it maps to either a TP68470
|
||
|
+ camera PMIC, a uP6641Q sensor PMIC, or a set of discrete GPIOs
|
||
|
+ and power gates.
|
||
|
+
|
||
|
+ If your device was designed for Chrome OS, this driver will provide
|
||
|
+ an ACPI OpRegion, which must be available before any of the devices
|
||
|
+ using it are probed. For this reason, you should select Y if your
|
||
|
+ device was designed for ChromeOS. For the same reason the
|
||
|
+ I2C_DESIGNWARE_PLATFORM option must be set to Y too.
|
||
|
+
|
||
|
+ Say Y or M here if you have a SkyLake device designed for use
|
||
|
+ with Windows or ChromeOS. Say N here if you are not sure.
|
||
|
+
|
||
|
+ The module will be named "intel-skl-int3472"
|
||
|
diff --git a/drivers/platform/x86/intel-int3472/Makefile b/drivers/platform/x86/intel-int3472/Makefile
|
||
|
new file mode 100644
|
||
|
index 000000000000..c887ee7d52ca
|
||
|
--- /dev/null
|
||
|
+++ b/drivers/platform/x86/intel-int3472/Makefile
|
||
|
@@ -0,0 +1,4 @@
|
||
|
+obj-$(CONFIG_INTEL_SKL_INT3472) += intel_skl_int3472.o
|
||
|
+intel_skl_int3472-objs := intel_skl_int3472_common.o \
|
||
|
+ intel_skl_int3472_discrete.o \
|
||
|
+ intel_skl_int3472_tps68470.o
|
||
|
diff --git a/drivers/platform/x86/intel-int3472/intel_skl_int3472_common.c b/drivers/platform/x86/intel-int3472/intel_skl_int3472_common.c
|
||
|
new file mode 100644
|
||
|
index 000000000000..f61166b6c497
|
||
|
--- /dev/null
|
||
|
+++ b/drivers/platform/x86/intel-int3472/intel_skl_int3472_common.c
|
||
|
@@ -0,0 +1,106 @@
|
||
|
+// SPDX-License-Identifier: GPL-2.0
|
||
|
+/* Author: Dan Scally <djrscally@gmail.com> */
|
||
|
+
|
||
|
+#include <linux/acpi.h>
|
||
|
+#include <linux/i2c.h>
|
||
|
+#include <linux/platform_device.h>
|
||
|
+#include <linux/slab.h>
|
||
|
+
|
||
|
+#include "intel_skl_int3472_common.h"
|
||
|
+
|
||
|
+union acpi_object *skl_int3472_get_acpi_buffer(struct acpi_device *adev,
|
||
|
+ char *id)
|
||
|
+{
|
||
|
+ struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
|
||
|
+ acpi_handle handle = adev->handle;
|
||
|
+ union acpi_object *obj;
|
||
|
+ acpi_status status;
|
||
|
+
|
||
|
+ status = acpi_evaluate_object(handle, id, NULL, &buffer);
|
||
|
+ if (ACPI_FAILURE(status))
|
||
|
+ return ERR_PTR(-ENODEV);
|
||
|
+
|
||
|
+ obj = buffer.pointer;
|
||
|
+ if (!obj)
|
||
|
+ return ERR_PTR(-ENODEV);
|
||
|
+
|
||
|
+ if (obj->type != ACPI_TYPE_BUFFER) {
|
||
|
+ dev_err(&adev->dev, "%s object is not an ACPI buffer\n", id);
|
||
|
+ kfree(obj);
|
||
|
+ return ERR_PTR(-EINVAL);
|
||
|
+ }
|
||
|
+
|
||
|
+ return obj;
|
||
|
+}
|
||
|
+
|
||
|
+int skl_int3472_fill_cldb(struct acpi_device *adev, struct int3472_cldb *cldb)
|
||
|
+{
|
||
|
+ union acpi_object *obj;
|
||
|
+ int ret = 0;
|
||
|
+
|
||
|
+ obj = skl_int3472_get_acpi_buffer(adev, "CLDB");
|
||
|
+ if (IS_ERR(obj))
|
||
|
+ return PTR_ERR(obj);
|
||
|
+
|
||
|
+ if (obj->buffer.length > sizeof(*cldb)) {
|
||
|
+ dev_err(&adev->dev, "The CLDB buffer is too large\n");
|
||
|
+ ret = -EINVAL;
|
||
|
+ goto out_free_obj;
|
||
|
+ }
|
||
|
+
|
||
|
+ memcpy(cldb, obj->buffer.pointer, obj->buffer.length);
|
||
|
+
|
||
|
+out_free_obj:
|
||
|
+ kfree(obj);
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static const struct acpi_device_id int3472_device_id[] = {
|
||
|
+ { "INT3472", 0 },
|
||
|
+ { }
|
||
|
+};
|
||
|
+MODULE_DEVICE_TABLE(acpi, int3472_device_id);
|
||
|
+
|
||
|
+static struct platform_driver int3472_discrete = {
|
||
|
+ .driver = {
|
||
|
+ .name = "int3472-discrete",
|
||
|
+ .acpi_match_table = int3472_device_id,
|
||
|
+ },
|
||
|
+ .probe = skl_int3472_discrete_probe,
|
||
|
+ .remove = skl_int3472_discrete_remove,
|
||
|
+};
|
||
|
+
|
||
|
+static struct i2c_driver int3472_tps68470 = {
|
||
|
+ .driver = {
|
||
|
+ .name = "int3472-tps68470",
|
||
|
+ .acpi_match_table = int3472_device_id,
|
||
|
+ },
|
||
|
+ .probe_new = skl_int3472_tps68470_probe,
|
||
|
+};
|
||
|
+
|
||
|
+static int skl_int3472_init(void)
|
||
|
+{
|
||
|
+ int ret = 0;
|
||
|
+
|
||
|
+ ret = platform_driver_register(&int3472_discrete);
|
||
|
+ if (ret)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ ret = i2c_register_driver(THIS_MODULE, &int3472_tps68470);
|
||
|
+ if (ret)
|
||
|
+ platform_driver_unregister(&int3472_discrete);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+module_init(skl_int3472_init);
|
||
|
+
|
||
|
+static void skl_int3472_exit(void)
|
||
|
+{
|
||
|
+ platform_driver_unregister(&int3472_discrete);
|
||
|
+ i2c_del_driver(&int3472_tps68470);
|
||
|
+}
|
||
|
+module_exit(skl_int3472_exit);
|
||
|
+
|
||
|
+MODULE_DESCRIPTION("Intel SkyLake INT3472 ACPI Device Driver");
|
||
|
+MODULE_AUTHOR("Daniel Scally <djrscally@gmail.com>");
|
||
|
+MODULE_LICENSE("GPL v2");
|
||
|
diff --git a/drivers/platform/x86/intel-int3472/intel_skl_int3472_common.h b/drivers/platform/x86/intel-int3472/intel_skl_int3472_common.h
|
||
|
new file mode 100644
|
||
|
index 000000000000..9169356cd522
|
||
|
--- /dev/null
|
||
|
+++ b/drivers/platform/x86/intel-int3472/intel_skl_int3472_common.h
|
||
|
@@ -0,0 +1,110 @@
|
||
|
+/* SPDX-License-Identifier: GPL-2.0 */
|
||
|
+/* Author: Dan Scally <djrscally@gmail.com> */
|
||
|
+
|
||
|
+#ifndef _INTEL_SKL_INT3472_H
|
||
|
+#define _INTEL_SKL_INT3472_H
|
||
|
+
|
||
|
+#include <linux/clk-provider.h>
|
||
|
+#include <linux/gpio/machine.h>
|
||
|
+#include <linux/regulator/driver.h>
|
||
|
+#include <linux/regulator/machine.h>
|
||
|
+#include <linux/types.h>
|
||
|
+
|
||
|
+/* PMIC GPIO Types */
|
||
|
+#define INT3472_GPIO_TYPE_RESET 0x00
|
||
|
+#define INT3472_GPIO_TYPE_POWERDOWN 0x01
|
||
|
+#define INT3472_GPIO_TYPE_POWER_ENABLE 0x0b
|
||
|
+#define INT3472_GPIO_TYPE_CLK_ENABLE 0x0c
|
||
|
+#define INT3472_GPIO_TYPE_PRIVACY_LED 0x0d
|
||
|
+
|
||
|
+#define INT3472_PDEV_MAX_NAME_LEN 23
|
||
|
+#define INT3472_MAX_SENSOR_GPIOS 3
|
||
|
+
|
||
|
+#define GPIO_REGULATOR_NAME_LENGTH 21
|
||
|
+#define GPIO_REGULATOR_SUPPLY_NAME_LENGTH 9
|
||
|
+
|
||
|
+#define CIO2_SENSOR_SSDB_MCLKSPEED_OFFSET 86
|
||
|
+
|
||
|
+#define INT3472_REGULATOR(_name, _supply, _ops) \
|
||
|
+ (const struct regulator_desc) { \
|
||
|
+ .name = _name, \
|
||
|
+ .supply_name = _supply, \
|
||
|
+ .type = REGULATOR_VOLTAGE, \
|
||
|
+ .ops = _ops, \
|
||
|
+ .owner = THIS_MODULE, \
|
||
|
+ }
|
||
|
+
|
||
|
+#define to_int3472_clk(hw) \
|
||
|
+ container_of(hw, struct int3472_gpio_clock, clk_hw)
|
||
|
+
|
||
|
+#define to_int3472_device(clk) \
|
||
|
+ container_of(clk, struct int3472_discrete_device, clock)
|
||
|
+
|
||
|
+struct platform_device;
|
||
|
+struct i2c_client;
|
||
|
+struct acpi_device;
|
||
|
+
|
||
|
+struct int3472_cldb {
|
||
|
+ u8 version;
|
||
|
+ /*
|
||
|
+ * control logic type
|
||
|
+ * 0: UNKNOWN
|
||
|
+ * 1: DISCRETE(CRD-D)
|
||
|
+ * 2: PMIC TPS68470
|
||
|
+ * 3: PMIC uP6641
|
||
|
+ */
|
||
|
+ u8 control_logic_type;
|
||
|
+ u8 control_logic_id;
|
||
|
+ u8 sensor_card_sku;
|
||
|
+ u8 reserved[28];
|
||
|
+};
|
||
|
+
|
||
|
+struct int3472_gpio_function_remap {
|
||
|
+ char *documented;
|
||
|
+ char *actual;
|
||
|
+};
|
||
|
+
|
||
|
+struct int3472_sensor_config {
|
||
|
+ const char *sensor_module_name;
|
||
|
+ struct regulator_consumer_supply supply_map;
|
||
|
+ const struct int3472_gpio_function_remap *function_maps;
|
||
|
+};
|
||
|
+
|
||
|
+struct int3472_discrete_device {
|
||
|
+ struct acpi_device *adev;
|
||
|
+ struct device *dev;
|
||
|
+ struct acpi_device *sensor;
|
||
|
+ const char *sensor_name;
|
||
|
+
|
||
|
+ struct int3472_sensor_config *sensor_config;
|
||
|
+
|
||
|
+ struct int3472_gpio_regulator {
|
||
|
+ char regulator_name[GPIO_REGULATOR_NAME_LENGTH];
|
||
|
+ char supply_name[GPIO_REGULATOR_SUPPLY_NAME_LENGTH];
|
||
|
+ struct gpio_desc *gpio;
|
||
|
+ struct regulator_dev *rdev;
|
||
|
+ struct regulator_desc rdesc;
|
||
|
+ } regulator;
|
||
|
+
|
||
|
+ struct int3472_gpio_clock {
|
||
|
+ struct clk *clk;
|
||
|
+ struct clk_hw clk_hw;
|
||
|
+ struct clk_lookup *cl;
|
||
|
+ struct gpio_desc *ena_gpio;
|
||
|
+ struct gpio_desc *led_gpio;
|
||
|
+ u32 frequency;
|
||
|
+ } clock;
|
||
|
+
|
||
|
+ unsigned int n_gpios; /* how many GPIOs have we seen */
|
||
|
+ unsigned int n_sensor_gpios; /* how many have we mapped to sensor */
|
||
|
+ struct gpiod_lookup_table gpios;
|
||
|
+};
|
||
|
+
|
||
|
+int skl_int3472_discrete_probe(struct platform_device *pdev);
|
||
|
+int skl_int3472_discrete_remove(struct platform_device *pdev);
|
||
|
+int skl_int3472_tps68470_probe(struct i2c_client *client);
|
||
|
+union acpi_object *skl_int3472_get_acpi_buffer(struct acpi_device *adev,
|
||
|
+ char *id);
|
||
|
+int skl_int3472_fill_cldb(struct acpi_device *adev, struct int3472_cldb *cldb);
|
||
|
+
|
||
|
+#endif
|
||
|
diff --git a/drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c b/drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c
|
||
|
new file mode 100644
|
||
|
index 000000000000..40652161bbbf
|
||
|
--- /dev/null
|
||
|
+++ b/drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c
|
||
|
@@ -0,0 +1,592 @@
|
||
|
+// SPDX-License-Identifier: GPL-2.0
|
||
|
+/* Author: Dan Scally <djrscally@gmail.com> */
|
||
|
+
|
||
|
+#include <linux/acpi.h>
|
||
|
+#include <linux/clkdev.h>
|
||
|
+#include <linux/gpio/consumer.h>
|
||
|
+#include <linux/i2c.h>
|
||
|
+#include <linux/kernel.h>
|
||
|
+#include <linux/module.h>
|
||
|
+#include <linux/overflow.h>
|
||
|
+#include <linux/platform_device.h>
|
||
|
+#include <linux/regulator/driver.h>
|
||
|
+#include <linux/slab.h>
|
||
|
+
|
||
|
+#include "intel_skl_int3472_common.h"
|
||
|
+
|
||
|
+/*
|
||
|
+ * 79234640-9e10-4fea-a5c1-b5aa8b19756f
|
||
|
+ * This _DSM GUID returns information about the GPIO lines mapped to a
|
||
|
+ * discrete INT3472 device. Function number 1 returns a count of the GPIO
|
||
|
+ * lines that are mapped. Subsequent functions return 32 bit ints encoding
|
||
|
+ * information about the GPIO line, including its purpose.
|
||
|
+ */
|
||
|
+static const guid_t int3472_gpio_guid =
|
||
|
+ GUID_INIT(0x79234640, 0x9e10, 0x4fea,
|
||
|
+ 0xa5, 0xc1, 0xb5, 0xaa, 0x8b, 0x19, 0x75, 0x6f);
|
||
|
+
|
||
|
+/*
|
||
|
+ * 822ace8f-2814-4174-a56b-5f029fe079ee
|
||
|
+ * This _DSM GUID returns a string from the sensor device, which acts as a
|
||
|
+ * module identifier.
|
||
|
+ */
|
||
|
+static const guid_t cio2_sensor_module_guid =
|
||
|
+ GUID_INIT(0x822ace8f, 0x2814, 0x4174,
|
||
|
+ 0xa5, 0x6b, 0x5f, 0x02, 0x9f, 0xe0, 0x79, 0xee);
|
||
|
+
|
||
|
+/*
|
||
|
+ * Here follows platform specific mapping information that we can pass to
|
||
|
+ * the functions mapping resources to the sensors. Where the sensors have
|
||
|
+ * a power enable pin defined in DSDT we need to provide a supply name so
|
||
|
+ * the sensor drivers can find the regulator. The device name will be derived
|
||
|
+ * from the sensor's ACPI device within the code. Optionally, we can provide a
|
||
|
+ * NULL terminated array of function name mappings to deal with any platform
|
||
|
+ * specific deviations from the documented behaviour of GPIOs.
|
||
|
+ *
|
||
|
+ * Map a GPIO function name to NULL to prevent the driver from mapping that
|
||
|
+ * GPIO at all.
|
||
|
+ */
|
||
|
+
|
||
|
+static const struct int3472_gpio_function_remap ov2680_gpio_function_remaps[] = {
|
||
|
+ { "reset", NULL },
|
||
|
+ { "powerdown", "reset" },
|
||
|
+ { }
|
||
|
+};
|
||
|
+
|
||
|
+static struct int3472_sensor_config int3472_sensor_configs[] = {
|
||
|
+ /* Lenovo Miix 510-12ISK - OV2680, Front */
|
||
|
+ { "GNDF140809R", { 0 }, ov2680_gpio_function_remaps},
|
||
|
+ /* Lenovo Miix 510-12ISK - OV5648, Rear */
|
||
|
+ { "GEFF150023R", REGULATOR_SUPPLY("avdd", NULL), NULL},
|
||
|
+ /* Surface Go 1&2 - OV5693, Front */
|
||
|
+ { "YHCU", REGULATOR_SUPPLY("avdd", NULL), NULL},
|
||
|
+};
|
||
|
+
|
||
|
+/*
|
||
|
+ * The regulators have to have .ops to be valid, but the only ops we actually
|
||
|
+ * support are .enable and .disable which are handled via .ena_gpiod. Pass an
|
||
|
+ * empty struct to clear the check without lying about capabilities.
|
||
|
+ */
|
||
|
+static const struct regulator_ops int3472_gpio_regulator_ops = { 0 };
|
||
|
+
|
||
|
+static int skl_int3472_clk_prepare(struct clk_hw *hw)
|
||
|
+{
|
||
|
+ struct int3472_gpio_clock *clk = to_int3472_clk(hw);
|
||
|
+
|
||
|
+ gpiod_set_value(clk->ena_gpio, 1);
|
||
|
+ if (clk->led_gpio)
|
||
|
+ gpiod_set_value(clk->led_gpio, 1);
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static void skl_int3472_clk_unprepare(struct clk_hw *hw)
|
||
|
+{
|
||
|
+ struct int3472_gpio_clock *clk = to_int3472_clk(hw);
|
||
|
+
|
||
|
+ gpiod_set_value(clk->ena_gpio, 0);
|
||
|
+ if (clk->led_gpio)
|
||
|
+ gpiod_set_value(clk->led_gpio, 0);
|
||
|
+}
|
||
|
+
|
||
|
+static int skl_int3472_clk_enable(struct clk_hw *hw)
|
||
|
+{
|
||
|
+ /*
|
||
|
+ * We're just turning a GPIO on to enable, which operation has the
|
||
|
+ * potential to sleep. Given enable cannot sleep, but prepare can,
|
||
|
+ * we toggle the GPIO in prepare instead. Thus, nothing to do here.
|
||
|
+ */
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static void skl_int3472_clk_disable(struct clk_hw *hw)
|
||
|
+{
|
||
|
+ /* Likewise, nothing to do here... */
|
||
|
+}
|
||
|
+
|
||
|
+static unsigned int skl_int3472_get_clk_frequency(struct int3472_discrete_device *int3472)
|
||
|
+{
|
||
|
+ union acpi_object *obj;
|
||
|
+ unsigned int ret = 0;
|
||
|
+
|
||
|
+ obj = skl_int3472_get_acpi_buffer(int3472->sensor, "SSDB");
|
||
|
+ if (IS_ERR(obj))
|
||
|
+ return 0; /* report rate as 0 on error */
|
||
|
+
|
||
|
+ if (obj->buffer.length < CIO2_SENSOR_SSDB_MCLKSPEED_OFFSET + sizeof(u32)) {
|
||
|
+ dev_err(int3472->dev, "The buffer is too small\n");
|
||
|
+ goto out_free_buff;
|
||
|
+ }
|
||
|
+
|
||
|
+ ret = *(u32 *)(obj->buffer.pointer + CIO2_SENSOR_SSDB_MCLKSPEED_OFFSET);
|
||
|
+
|
||
|
+out_free_buff:
|
||
|
+ kfree(obj);
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static unsigned long skl_int3472_clk_recalc_rate(struct clk_hw *hw,
|
||
|
+ unsigned long parent_rate)
|
||
|
+{
|
||
|
+ struct int3472_gpio_clock *clk = to_int3472_clk(hw);
|
||
|
+ struct int3472_discrete_device *int3472 = to_int3472_device(clk);
|
||
|
+
|
||
|
+ return int3472->clock.frequency;
|
||
|
+}
|
||
|
+
|
||
|
+static const struct clk_ops skl_int3472_clock_ops = {
|
||
|
+ .prepare = skl_int3472_clk_prepare,
|
||
|
+ .unprepare = skl_int3472_clk_unprepare,
|
||
|
+ .enable = skl_int3472_clk_enable,
|
||
|
+ .disable = skl_int3472_clk_disable,
|
||
|
+ .recalc_rate = skl_int3472_clk_recalc_rate,
|
||
|
+};
|
||
|
+
|
||
|
+static struct int3472_sensor_config *
|
||
|
+skl_int3472_get_sensor_module_config(struct int3472_discrete_device *int3472)
|
||
|
+{
|
||
|
+ struct int3472_sensor_config *ret;
|
||
|
+ union acpi_object *obj;
|
||
|
+ unsigned int i;
|
||
|
+
|
||
|
+ obj = acpi_evaluate_dsm_typed(int3472->sensor->handle,
|
||
|
+ &cio2_sensor_module_guid, 0x00,
|
||
|
+ 0x01, NULL, ACPI_TYPE_STRING);
|
||
|
+
|
||
|
+ if (!obj) {
|
||
|
+ dev_err(int3472->dev,
|
||
|
+ "Failed to get sensor module string from _DSM\n");
|
||
|
+ return ERR_PTR(-ENODEV);
|
||
|
+ }
|
||
|
+
|
||
|
+ if (obj->string.type != ACPI_TYPE_STRING) {
|
||
|
+ dev_err(int3472->dev,
|
||
|
+ "Sensor _DSM returned a non-string value\n");
|
||
|
+ ret = ERR_PTR(-EINVAL);
|
||
|
+ goto out_free_obj;
|
||
|
+ }
|
||
|
+
|
||
|
+ ret = NULL;
|
||
|
+ for (i = 0; i < ARRAY_SIZE(int3472_sensor_configs); i++) {
|
||
|
+ if (!strcmp(int3472_sensor_configs[i].sensor_module_name,
|
||
|
+ obj->string.pointer)) {
|
||
|
+ ret = &int3472_sensor_configs[i];
|
||
|
+ break;
|
||
|
+ }
|
||
|
+ }
|
||
|
+
|
||
|
+out_free_obj:
|
||
|
+ ACPI_FREE(obj);
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int skl_int3472_map_gpio_to_sensor(struct int3472_discrete_device *int3472,
|
||
|
+ struct acpi_resource *ares,
|
||
|
+ char *func, u32 polarity)
|
||
|
+{
|
||
|
+ char *path = ares->data.gpio.resource_source.string_ptr;
|
||
|
+ const struct int3472_sensor_config *sensor_config;
|
||
|
+ struct gpiod_lookup *table_entry;
|
||
|
+ struct acpi_device *adev;
|
||
|
+ acpi_handle handle;
|
||
|
+ acpi_status status;
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ if (int3472->n_sensor_gpios >= INT3472_MAX_SENSOR_GPIOS) {
|
||
|
+ dev_warn(int3472->dev, "Too many GPIOs mapped\n");
|
||
|
+ return -EINVAL;
|
||
|
+ }
|
||
|
+
|
||
|
+ sensor_config = int3472->sensor_config;
|
||
|
+ if (!IS_ERR_OR_NULL(sensor_config) && sensor_config->function_maps) {
|
||
|
+ const struct int3472_gpio_function_remap *remap =
|
||
|
+ sensor_config->function_maps;
|
||
|
+
|
||
|
+ for (; remap->documented; ++remap)
|
||
|
+ if (!strcmp(func, remap->documented)) {
|
||
|
+ func = remap->actual;
|
||
|
+ break;
|
||
|
+ }
|
||
|
+ }
|
||
|
+
|
||
|
+ /* Functions mapped to NULL should not be mapped to the sensor */
|
||
|
+ if (!func)
|
||
|
+ return 0;
|
||
|
+
|
||
|
+ status = acpi_get_handle(NULL, path, &handle);
|
||
|
+ if (ACPI_FAILURE(status))
|
||
|
+ return -EINVAL;
|
||
|
+
|
||
|
+ ret = acpi_bus_get_device(handle, &adev);
|
||
|
+ if (ret)
|
||
|
+ return -ENODEV;
|
||
|
+
|
||
|
+ table_entry = &int3472->gpios.table[int3472->n_sensor_gpios];
|
||
|
+ table_entry->key = acpi_dev_name(adev);
|
||
|
+ table_entry->chip_hwnum = ares->data.gpio.pin_table[0];
|
||
|
+ table_entry->con_id = func;
|
||
|
+ table_entry->idx = 0;
|
||
|
+ table_entry->flags = polarity;
|
||
|
+
|
||
|
+ int3472->n_sensor_gpios++;
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static int skl_int3472_map_gpio_to_clk(struct int3472_discrete_device *int3472,
|
||
|
+ struct acpi_resource *ares, u8 type)
|
||
|
+{
|
||
|
+ char *path = ares->data.gpio.resource_source.string_ptr;
|
||
|
+ struct gpio_desc *gpio;
|
||
|
+
|
||
|
+ switch (type) {
|
||
|
+ case INT3472_GPIO_TYPE_CLK_ENABLE:
|
||
|
+ gpio = acpi_get_gpiod(path, ares->data.gpio.pin_table[0],
|
||
|
+ "int3472,clk-enable");
|
||
|
+ if (IS_ERR(gpio))
|
||
|
+ return (PTR_ERR(gpio));
|
||
|
+
|
||
|
+ int3472->clock.ena_gpio = gpio;
|
||
|
+ break;
|
||
|
+ case INT3472_GPIO_TYPE_PRIVACY_LED:
|
||
|
+ gpio = acpi_get_gpiod(path, ares->data.gpio.pin_table[0],
|
||
|
+ "int3472,privacy-led");
|
||
|
+ if (IS_ERR(gpio))
|
||
|
+ return (PTR_ERR(gpio));
|
||
|
+
|
||
|
+ int3472->clock.led_gpio = gpio;
|
||
|
+ break;
|
||
|
+ default:
|
||
|
+ dev_err(int3472->dev, "Invalid GPIO type 0x%hx for clock\n",
|
||
|
+ type);
|
||
|
+ break;
|
||
|
+ }
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static int skl_int3472_register_clock(struct int3472_discrete_device *int3472)
|
||
|
+{
|
||
|
+ struct clk_init_data init = {
|
||
|
+ .ops = &skl_int3472_clock_ops,
|
||
|
+ .flags = CLK_GET_RATE_NOCACHE,
|
||
|
+ };
|
||
|
+ int ret = 0;
|
||
|
+
|
||
|
+ init.name = kasprintf(GFP_KERNEL, "%s-clk",
|
||
|
+ acpi_dev_name(int3472->adev));
|
||
|
+ if (!init.name)
|
||
|
+ return -ENOMEM;
|
||
|
+
|
||
|
+ int3472->clock.frequency = skl_int3472_get_clk_frequency(int3472);
|
||
|
+
|
||
|
+ int3472->clock.clk_hw.init = &init;
|
||
|
+ int3472->clock.clk = clk_register(&int3472->adev->dev,
|
||
|
+ &int3472->clock.clk_hw);
|
||
|
+ if (IS_ERR(int3472->clock.clk)) {
|
||
|
+ ret = PTR_ERR(int3472->clock.clk);
|
||
|
+ goto out_free_init_name;
|
||
|
+ }
|
||
|
+
|
||
|
+ int3472->clock.cl = clkdev_create(int3472->clock.clk, NULL,
|
||
|
+ int3472->sensor_name);
|
||
|
+ if (!int3472->clock.cl) {
|
||
|
+ ret = -ENOMEM;
|
||
|
+ goto err_unregister_clk;
|
||
|
+ }
|
||
|
+
|
||
|
+ goto out_free_init_name;
|
||
|
+
|
||
|
+err_unregister_clk:
|
||
|
+ clk_unregister(int3472->clock.clk);
|
||
|
+out_free_init_name:
|
||
|
+ kfree(init.name);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int skl_int3472_register_regulator(struct int3472_discrete_device *int3472,
|
||
|
+ struct acpi_resource *ares)
|
||
|
+{
|
||
|
+ char *path = ares->data.gpio.resource_source.string_ptr;
|
||
|
+ struct int3472_sensor_config *sensor_config;
|
||
|
+ struct regulator_init_data init_data = { };
|
||
|
+ struct regulator_config cfg = { };
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ sensor_config = int3472->sensor_config;
|
||
|
+ if (IS_ERR_OR_NULL(sensor_config)) {
|
||
|
+ dev_err(int3472->dev, "No sensor module config\n");
|
||
|
+ return PTR_ERR(sensor_config);
|
||
|
+ }
|
||
|
+
|
||
|
+ if (!sensor_config->supply_map.supply) {
|
||
|
+ dev_err(int3472->dev, "No supply name defined\n");
|
||
|
+ return -ENODEV;
|
||
|
+ }
|
||
|
+
|
||
|
+ init_data.constraints.valid_ops_mask = REGULATOR_CHANGE_STATUS;
|
||
|
+ init_data.num_consumer_supplies = 1;
|
||
|
+ sensor_config->supply_map.dev_name = int3472->sensor_name;
|
||
|
+ init_data.consumer_supplies = &sensor_config->supply_map;
|
||
|
+
|
||
|
+ snprintf(int3472->regulator.regulator_name,
|
||
|
+ sizeof(int3472->regulator.regulator_name), "%s-regulator",
|
||
|
+ acpi_dev_name(int3472->adev));
|
||
|
+ snprintf(int3472->regulator.supply_name,
|
||
|
+ GPIO_REGULATOR_SUPPLY_NAME_LENGTH, "supply-0");
|
||
|
+
|
||
|
+ int3472->regulator.rdesc = INT3472_REGULATOR(
|
||
|
+ int3472->regulator.regulator_name,
|
||
|
+ int3472->regulator.supply_name,
|
||
|
+ &int3472_gpio_regulator_ops);
|
||
|
+
|
||
|
+ int3472->regulator.gpio = acpi_get_gpiod(path,
|
||
|
+ ares->data.gpio.pin_table[0],
|
||
|
+ "int3472,regulator");
|
||
|
+ if (IS_ERR(int3472->regulator.gpio)) {
|
||
|
+ dev_err(int3472->dev, "Failed to get regulator GPIO lines\n");
|
||
|
+ return PTR_ERR(int3472->regulator.gpio);
|
||
|
+ }
|
||
|
+
|
||
|
+ cfg.dev = &int3472->adev->dev;
|
||
|
+ cfg.init_data = &init_data;
|
||
|
+ cfg.ena_gpiod = int3472->regulator.gpio;
|
||
|
+
|
||
|
+ int3472->regulator.rdev = regulator_register(&int3472->regulator.rdesc,
|
||
|
+ &cfg);
|
||
|
+ if (IS_ERR(int3472->regulator.rdev)) {
|
||
|
+ ret = PTR_ERR(int3472->regulator.rdev);
|
||
|
+ goto err_free_gpio;
|
||
|
+ }
|
||
|
+
|
||
|
+ return 0;
|
||
|
+
|
||
|
+err_free_gpio:
|
||
|
+ gpiod_put(int3472->regulator.gpio);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+/**
|
||
|
+ * skl_int3472_handle_gpio_resources: Map PMIC resources to consuming sensor
|
||
|
+ * @ares: A pointer to a &struct acpi_resource
|
||
|
+ * @data: A pointer to a &struct int3472_discrete_device
|
||
|
+ *
|
||
|
+ * This function handles GPIO resources that are against an INT3472
|
||
|
+ * ACPI device, by checking the value of the corresponding _DSM entry.
|
||
|
+ * This will return a 32bit int, where the lowest byte represents the
|
||
|
+ * function of the GPIO pin:
|
||
|
+ *
|
||
|
+ * 0x00 Reset
|
||
|
+ * 0x01 Power down
|
||
|
+ * 0x0b Power enable
|
||
|
+ * 0x0c Clock enable
|
||
|
+ * 0x0d Privacy LED
|
||
|
+ *
|
||
|
+ * There are some known platform specific quirks where that does not quite
|
||
|
+ * hold up; for example where a pin with type 0x01 (Power down) is mapped to
|
||
|
+ * a sensor pin that performs a reset function or entries in _CRS and _DSM that
|
||
|
+ * do not actually correspond to a physical connection. These will be handled
|
||
|
+ * by the mapping sub-functions.
|
||
|
+ *
|
||
|
+ * GPIOs will either be mapped directly to the sensor device or else used
|
||
|
+ * to create clocks and regulators via the usual frameworks.
|
||
|
+ *
|
||
|
+ * Return:
|
||
|
+ * * 0 - When all resources found are handled properly.
|
||
|
+ * * -EINVAL - If the resource is not a GPIO IO resource
|
||
|
+ * * -ENODEV - If the resource has no corresponding _DSM entry
|
||
|
+ * * -Other - Errors propagated from one of the sub-functions.
|
||
|
+ */
|
||
|
+static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,
|
||
|
+ void *data)
|
||
|
+{
|
||
|
+ struct int3472_discrete_device *int3472 = data;
|
||
|
+ u16 pin = ares->data.gpio.pin_table[0];
|
||
|
+ union acpi_object *obj;
|
||
|
+ char *err_msg;
|
||
|
+ int ret = 0;
|
||
|
+ u8 type;
|
||
|
+
|
||
|
+ if (ares->type != ACPI_RESOURCE_TYPE_GPIO ||
|
||
|
+ ares->data.gpio.connection_type != ACPI_RESOURCE_GPIO_TYPE_IO)
|
||
|
+ return 1; /* Deliberately positive so parsing continues */
|
||
|
+
|
||
|
+ /*
|
||
|
+ * n_gpios + 2 because the index of this _DSM function is 1-based and
|
||
|
+ * the first function is just a count.
|
||
|
+ */
|
||
|
+ obj = acpi_evaluate_dsm_typed(int3472->adev->handle,
|
||
|
+ &int3472_gpio_guid, 0x00,
|
||
|
+ int3472->n_gpios + 2,
|
||
|
+ NULL, ACPI_TYPE_INTEGER);
|
||
|
+
|
||
|
+ if (!obj) {
|
||
|
+ dev_warn(int3472->dev, "No _DSM entry for GPIO pin %u\n", pin);
|
||
|
+ return 1;
|
||
|
+ }
|
||
|
+
|
||
|
+ type = obj->integer.value & 0xff;
|
||
|
+
|
||
|
+ switch (type) {
|
||
|
+ case INT3472_GPIO_TYPE_RESET:
|
||
|
+ ret = skl_int3472_map_gpio_to_sensor(int3472, ares, "reset",
|
||
|
+ GPIO_ACTIVE_LOW);
|
||
|
+ if (ret)
|
||
|
+ err_msg = "Failed to map reset pin to sensor\n";
|
||
|
+
|
||
|
+ break;
|
||
|
+ case INT3472_GPIO_TYPE_POWERDOWN:
|
||
|
+ ret = skl_int3472_map_gpio_to_sensor(int3472, ares,
|
||
|
+ "powerdown",
|
||
|
+ GPIO_ACTIVE_LOW);
|
||
|
+ if (ret)
|
||
|
+ err_msg = "Failed to map powerdown pin to sensor\n";
|
||
|
+
|
||
|
+ break;
|
||
|
+ case INT3472_GPIO_TYPE_CLK_ENABLE:
|
||
|
+ case INT3472_GPIO_TYPE_PRIVACY_LED:
|
||
|
+ ret = skl_int3472_map_gpio_to_clk(int3472, ares, type);
|
||
|
+ if (ret)
|
||
|
+ err_msg = "Failed to map GPIO to clock\n";
|
||
|
+
|
||
|
+ break;
|
||
|
+ case INT3472_GPIO_TYPE_POWER_ENABLE:
|
||
|
+ ret = skl_int3472_register_regulator(int3472, ares);
|
||
|
+ if (ret)
|
||
|
+ err_msg = "Failed to map regulator to sensor\n";
|
||
|
+
|
||
|
+ break;
|
||
|
+ default:
|
||
|
+ dev_warn(int3472->dev,
|
||
|
+ "GPIO type 0x%02x unknown; the sensor may not work\n",
|
||
|
+ type);
|
||
|
+ ret = 1;
|
||
|
+ break;
|
||
|
+ }
|
||
|
+
|
||
|
+ if (ret < 0 && ret != -EPROBE_DEFER)
|
||
|
+ dev_err(int3472->dev, err_msg);
|
||
|
+
|
||
|
+ int3472->n_gpios++;
|
||
|
+ ACPI_FREE(obj);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int skl_int3472_parse_crs(struct int3472_discrete_device *int3472)
|
||
|
+{
|
||
|
+ struct list_head resource_list;
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ INIT_LIST_HEAD(&resource_list);
|
||
|
+
|
||
|
+ int3472->sensor_config = skl_int3472_get_sensor_module_config(int3472);
|
||
|
+
|
||
|
+ ret = acpi_dev_get_resources(int3472->adev, &resource_list,
|
||
|
+ skl_int3472_handle_gpio_resources,
|
||
|
+ int3472);
|
||
|
+ if (ret)
|
||
|
+ goto out_free_res_list;
|
||
|
+
|
||
|
+ if (int3472->clock.ena_gpio) {
|
||
|
+ ret = skl_int3472_register_clock(int3472);
|
||
|
+ if (ret)
|
||
|
+ goto out_free_res_list;
|
||
|
+ } else {
|
||
|
+ if (int3472->clock.led_gpio)
|
||
|
+ dev_warn(int3472->dev,
|
||
|
+ "No clk GPIO. The privacy LED won't work\n");
|
||
|
+ }
|
||
|
+
|
||
|
+ int3472->gpios.dev_id = int3472->sensor_name;
|
||
|
+ gpiod_add_lookup_table(&int3472->gpios);
|
||
|
+
|
||
|
+out_free_res_list:
|
||
|
+ acpi_dev_free_resource_list(&resource_list);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+int skl_int3472_discrete_probe(struct platform_device *pdev)
|
||
|
+{
|
||
|
+ struct acpi_device *adev = ACPI_COMPANION(&pdev->dev);
|
||
|
+ struct int3472_discrete_device *int3472;
|
||
|
+ struct int3472_cldb cldb;
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ ret = skl_int3472_fill_cldb(adev, &cldb);
|
||
|
+ if (ret) {
|
||
|
+ dev_err(&pdev->dev, "Couldn't fill CLDB structure\n");
|
||
|
+ return ret;
|
||
|
+ }
|
||
|
+
|
||
|
+ if (cldb.control_logic_type != 1) {
|
||
|
+ dev_err(&pdev->dev, "Unsupported control logic type %u\n",
|
||
|
+ cldb.control_logic_type);
|
||
|
+ return -EINVAL;
|
||
|
+ }
|
||
|
+
|
||
|
+ /* Max num GPIOs we've seen plus a terminator */
|
||
|
+ int3472 = kzalloc(struct_size(int3472, gpios.table,
|
||
|
+ INT3472_MAX_SENSOR_GPIOS + 1), GFP_KERNEL);
|
||
|
+ if (!int3472)
|
||
|
+ return -ENOMEM;
|
||
|
+
|
||
|
+ int3472->adev = adev;
|
||
|
+ int3472->dev = &pdev->dev;
|
||
|
+ platform_set_drvdata(pdev, int3472);
|
||
|
+
|
||
|
+ int3472->sensor = acpi_dev_get_dependent_dev(adev);
|
||
|
+ if (IS_ERR_OR_NULL(int3472->sensor)) {
|
||
|
+ dev_err(&pdev->dev,
|
||
|
+ "INT3472 seems to have no dependents.\n");
|
||
|
+ ret = -ENODEV;
|
||
|
+ goto err_free_int3472;
|
||
|
+ }
|
||
|
+ get_device(&int3472->sensor->dev);
|
||
|
+
|
||
|
+ int3472->sensor_name = kasprintf(GFP_KERNEL, I2C_DEV_NAME_FORMAT,
|
||
|
+ acpi_dev_name(int3472->sensor));
|
||
|
+
|
||
|
+ ret = skl_int3472_parse_crs(int3472);
|
||
|
+ if (ret) {
|
||
|
+ skl_int3472_discrete_remove(pdev);
|
||
|
+ return ret;
|
||
|
+ }
|
||
|
+
|
||
|
+ return 0;
|
||
|
+
|
||
|
+err_free_int3472:
|
||
|
+ kfree(int3472);
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+int skl_int3472_discrete_remove(struct platform_device *pdev)
|
||
|
+{
|
||
|
+ struct int3472_discrete_device *int3472 = platform_get_drvdata(pdev);
|
||
|
+
|
||
|
+ if (int3472->gpios.dev_id)
|
||
|
+ gpiod_remove_lookup_table(&int3472->gpios);
|
||
|
+
|
||
|
+ if (!IS_ERR(int3472->regulator.rdev))
|
||
|
+ regulator_unregister(int3472->regulator.rdev);
|
||
|
+
|
||
|
+ if (!IS_ERR(int3472->clock.clk))
|
||
|
+ clk_unregister(int3472->clock.clk);
|
||
|
+
|
||
|
+ if (int3472->clock.cl)
|
||
|
+ clkdev_drop(int3472->clock.cl);
|
||
|
+
|
||
|
+ gpiod_put(int3472->regulator.gpio);
|
||
|
+ gpiod_put(int3472->clock.ena_gpio);
|
||
|
+ gpiod_put(int3472->clock.led_gpio);
|
||
|
+
|
||
|
+ acpi_dev_put(int3472->sensor);
|
||
|
+
|
||
|
+ kfree(int3472->sensor_name);
|
||
|
+ kfree(int3472);
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
diff --git a/drivers/platform/x86/intel-int3472/intel_skl_int3472_tps68470.c b/drivers/platform/x86/intel-int3472/intel_skl_int3472_tps68470.c
|
||
|
new file mode 100644
|
||
|
index 000000000000..d0d2391e263f
|
||
|
--- /dev/null
|
||
|
+++ b/drivers/platform/x86/intel-int3472/intel_skl_int3472_tps68470.c
|
||
|
@@ -0,0 +1,113 @@
|
||
|
+// SPDX-License-Identifier: GPL-2.0
|
||
|
+/* Author: Dan Scally <djrscally@gmail.com> */
|
||
|
+
|
||
|
+#include <linux/i2c.h>
|
||
|
+#include <linux/mfd/core.h>
|
||
|
+#include <linux/mfd/tps68470.h>
|
||
|
+#include <linux/platform_device.h>
|
||
|
+#include <linux/regmap.h>
|
||
|
+
|
||
|
+#include "intel_skl_int3472_common.h"
|
||
|
+
|
||
|
+static const struct mfd_cell tps68470_c[] = {
|
||
|
+ { .name = "tps68470-gpio" },
|
||
|
+ { .name = "tps68470_pmic_opregion" },
|
||
|
+};
|
||
|
+
|
||
|
+static const struct mfd_cell tps68470_w[] = {
|
||
|
+ { .name = "tps68470-gpio" },
|
||
|
+ { .name = "tps68470-clk" },
|
||
|
+ { .name = "tps68470-regulator"},
|
||
|
+};
|
||
|
+
|
||
|
+static const struct regmap_config tps68470_regmap_config = {
|
||
|
+ .reg_bits = 8,
|
||
|
+ .val_bits = 8,
|
||
|
+ .max_register = TPS68470_REG_MAX,
|
||
|
+};
|
||
|
+
|
||
|
+static int tps68470_chip_init(struct device *dev, struct regmap *regmap)
|
||
|
+{
|
||
|
+ unsigned int version;
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ /* Force software reset */
|
||
|
+ ret = regmap_write(regmap, TPS68470_REG_RESET, TPS68470_REG_RESET_MASK);
|
||
|
+ if (ret)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ ret = regmap_read(regmap, TPS68470_REG_REVID, &version);
|
||
|
+ if (ret) {
|
||
|
+ dev_err(dev, "Failed to read revision register: %d\n", ret);
|
||
|
+ return ret;
|
||
|
+ }
|
||
|
+
|
||
|
+ dev_info(dev, "TPS68470 REVID: 0x%02x\n", version);
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+int skl_int3472_tps68470_probe(struct i2c_client *client)
|
||
|
+{
|
||
|
+ struct acpi_device *adev = ACPI_COMPANION(&client->dev);
|
||
|
+ struct int3472_cldb cldb = { 0 };
|
||
|
+ bool cldb_present = true;
|
||
|
+ struct regmap *regmap;
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ regmap = devm_regmap_init_i2c(client, &tps68470_regmap_config);
|
||
|
+ if (IS_ERR(regmap)) {
|
||
|
+ dev_err(&client->dev, "Failed to create regmap: %ld\n",
|
||
|
+ PTR_ERR(regmap));
|
||
|
+ return PTR_ERR(regmap);
|
||
|
+ }
|
||
|
+
|
||
|
+ i2c_set_clientdata(client, regmap);
|
||
|
+
|
||
|
+ ret = tps68470_chip_init(&client->dev, regmap);
|
||
|
+ if (ret < 0) {
|
||
|
+ dev_err(&client->dev, "TPS68470 init error %d\n", ret);
|
||
|
+ return ret;
|
||
|
+ }
|
||
|
+
|
||
|
+ /*
|
||
|
+ * Check CLDB buffer against the PMIC's adev. If present, then we check
|
||
|
+ * the value of control_logic_type field and follow one of the
|
||
|
+ * following scenarios:
|
||
|
+ *
|
||
|
+ * 1. No CLDB - likely ACPI tables designed for ChromeOS. We
|
||
|
+ * create platform devices for the GPIOs and OpRegion drivers.
|
||
|
+ *
|
||
|
+ * 2. CLDB, with control_logic_type = 2 - probably ACPI tables
|
||
|
+ * made for Windows 2-in-1 platforms. Register pdevs for GPIO,
|
||
|
+ * Clock and Regulator drivers to bind to.
|
||
|
+ *
|
||
|
+ * 3. Any other value in control_logic_type, we should never have
|
||
|
+ * gotten to this point; fail probe and return.
|
||
|
+ */
|
||
|
+ ret = skl_int3472_fill_cldb(adev, &cldb);
|
||
|
+ if (!ret && cldb.control_logic_type != 2) {
|
||
|
+ dev_err(&client->dev, "Unsupported control logic type %u\n",
|
||
|
+ cldb.control_logic_type);
|
||
|
+ return -EINVAL;
|
||
|
+ }
|
||
|
+
|
||
|
+ if (ret)
|
||
|
+ cldb_present = false;
|
||
|
+
|
||
|
+ if (cldb_present)
|
||
|
+ ret = devm_mfd_add_devices(&client->dev, PLATFORM_DEVID_NONE,
|
||
|
+ tps68470_w, ARRAY_SIZE(tps68470_w),
|
||
|
+ NULL, 0, NULL);
|
||
|
+ else
|
||
|
+ ret = devm_mfd_add_devices(&client->dev, PLATFORM_DEVID_NONE,
|
||
|
+ tps68470_c, ARRAY_SIZE(tps68470_c),
|
||
|
+ NULL, 0, NULL);
|
||
|
+
|
||
|
+ if (ret) {
|
||
|
+ dev_err(&client->dev, "Failed to add MFD devices\n");
|
||
|
+ return ret;
|
||
|
+ }
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
--
|
||
|
2.31.1
|
||
|
|
||
|
From 6c66649aaf0b322f3c0041bd3204d7d485a7d91f Mon Sep 17 00:00:00 2001
|
||
|
From: Daniel Scally <djrscally@gmail.com>
|
||
|
Date: Mon, 22 Feb 2021 13:07:35 +0000
|
||
|
Subject: [PATCH] mfd: tps68470: Remove tps68470 MFD driver
|
||
|
|
||
|
This driver only covered one scenario in which ACPI devices with _HID
|
||
|
INT3472 are found, and its functionality has been taken over by the
|
||
|
intel-skl-int3472 module, so remove it.
|
||
|
|
||
|
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
|
||
|
Signed-off-by: Daniel Scally <djrscally@gmail.com>
|
||
|
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
|
||
|
Acked-by: Lee Jones <lee.jones@linaro.org>
|
||
|
Patchset: cameras
|
||
|
---
|
||
|
drivers/acpi/pmic/Kconfig | 2 +-
|
||
|
drivers/gpio/Kconfig | 2 +-
|
||
|
drivers/mfd/Kconfig | 18 --------
|
||
|
drivers/mfd/Makefile | 1 -
|
||
|
drivers/mfd/tps68470.c | 97 ---------------------------------------
|
||
|
5 files changed, 2 insertions(+), 118 deletions(-)
|
||
|
delete mode 100644 drivers/mfd/tps68470.c
|
||
|
|
||
|
diff --git a/drivers/acpi/pmic/Kconfig b/drivers/acpi/pmic/Kconfig
|
||
|
index 56bbcb2ce61b..f84b8f6038dc 100644
|
||
|
--- a/drivers/acpi/pmic/Kconfig
|
||
|
+++ b/drivers/acpi/pmic/Kconfig
|
||
|
@@ -52,7 +52,7 @@ endif # PMIC_OPREGION
|
||
|
|
||
|
config TPS68470_PMIC_OPREGION
|
||
|
bool "ACPI operation region support for TPS68470 PMIC"
|
||
|
- depends on MFD_TPS68470
|
||
|
+ depends on INTEL_SKL_INT3472
|
||
|
help
|
||
|
This config adds ACPI operation region support for TI TPS68470 PMIC.
|
||
|
TPS68470 device is an advanced power management unit that powers
|
||
|
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
|
||
|
index e3607ec4c2e8..269d88c7d5a5 100644
|
||
|
--- a/drivers/gpio/Kconfig
|
||
|
+++ b/drivers/gpio/Kconfig
|
||
|
@@ -1345,7 +1345,7 @@ config GPIO_TPS65912
|
||
|
|
||
|
config GPIO_TPS68470
|
||
|
bool "TPS68470 GPIO"
|
||
|
- depends on MFD_TPS68470
|
||
|
+ depends on INTEL_SKL_INT3472
|
||
|
help
|
||
|
Select this option to enable GPIO driver for the TPS68470
|
||
|
chip family.
|
||
|
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
|
||
|
index b74efa469e90..8a112a194c3b 100644
|
||
|
--- a/drivers/mfd/Kconfig
|
||
|
+++ b/drivers/mfd/Kconfig
|
||
|
@@ -1511,24 +1511,6 @@ config MFD_TPS65217
|
||
|
This driver can also be built as a module. If so, the module
|
||
|
will be called tps65217.
|
||
|
|
||
|
-config MFD_TPS68470
|
||
|
- bool "TI TPS68470 Power Management / LED chips"
|
||
|
- depends on ACPI && PCI && I2C=y
|
||
|
- depends on I2C_DESIGNWARE_PLATFORM=y
|
||
|
- select MFD_CORE
|
||
|
- select REGMAP_I2C
|
||
|
- help
|
||
|
- If you say yes here you get support for the TPS68470 series of
|
||
|
- Power Management / LED chips.
|
||
|
-
|
||
|
- These include voltage regulators, LEDs and other features
|
||
|
- that are often used in portable devices.
|
||
|
-
|
||
|
- This option is a bool as it provides an ACPI operation
|
||
|
- region, which must be available before any of the devices
|
||
|
- using this are probed. This option also configures the
|
||
|
- designware-i2c driver to be built-in, for the same reason.
|
||
|
-
|
||
|
config MFD_TI_LP873X
|
||
|
tristate "TI LP873X Power Management IC"
|
||
|
depends on I2C
|
||
|
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
|
||
|
index 834f5463af28..daccc3475de5 100644
|
||
|
--- a/drivers/mfd/Makefile
|
||
|
+++ b/drivers/mfd/Makefile
|
||
|
@@ -105,7 +105,6 @@ obj-$(CONFIG_MFD_TPS65910) += tps65910.o
|
||
|
obj-$(CONFIG_MFD_TPS65912) += tps65912-core.o
|
||
|
obj-$(CONFIG_MFD_TPS65912_I2C) += tps65912-i2c.o
|
||
|
obj-$(CONFIG_MFD_TPS65912_SPI) += tps65912-spi.o
|
||
|
-obj-$(CONFIG_MFD_TPS68470) += tps68470.o
|
||
|
obj-$(CONFIG_MFD_TPS80031) += tps80031.o
|
||
|
obj-$(CONFIG_MENELAUS) += menelaus.o
|
||
|
|
||
|
diff --git a/drivers/mfd/tps68470.c b/drivers/mfd/tps68470.c
|
||
|
deleted file mode 100644
|
||
|
index 4a4df4ffd18c..000000000000
|
||
|
--- a/drivers/mfd/tps68470.c
|
||
|
+++ /dev/null
|
||
|
@@ -1,97 +0,0 @@
|
||
|
-// SPDX-License-Identifier: GPL-2.0
|
||
|
-/*
|
||
|
- * TPS68470 chip Parent driver
|
||
|
- *
|
||
|
- * Copyright (C) 2017 Intel Corporation
|
||
|
- *
|
||
|
- * Authors:
|
||
|
- * Rajmohan Mani <rajmohan.mani@intel.com>
|
||
|
- * Tianshu Qiu <tian.shu.qiu@intel.com>
|
||
|
- * Jian Xu Zheng <jian.xu.zheng@intel.com>
|
||
|
- * Yuning Pu <yuning.pu@intel.com>
|
||
|
- */
|
||
|
-
|
||
|
-#include <linux/acpi.h>
|
||
|
-#include <linux/delay.h>
|
||
|
-#include <linux/i2c.h>
|
||
|
-#include <linux/init.h>
|
||
|
-#include <linux/mfd/core.h>
|
||
|
-#include <linux/mfd/tps68470.h>
|
||
|
-#include <linux/regmap.h>
|
||
|
-
|
||
|
-static const struct mfd_cell tps68470s[] = {
|
||
|
- { .name = "tps68470-gpio" },
|
||
|
- { .name = "tps68470_pmic_opregion" },
|
||
|
-};
|
||
|
-
|
||
|
-static const struct regmap_config tps68470_regmap_config = {
|
||
|
- .reg_bits = 8,
|
||
|
- .val_bits = 8,
|
||
|
- .max_register = TPS68470_REG_MAX,
|
||
|
-};
|
||
|
-
|
||
|
-static int tps68470_chip_init(struct device *dev, struct regmap *regmap)
|
||
|
-{
|
||
|
- unsigned int version;
|
||
|
- int ret;
|
||
|
-
|
||
|
- /* Force software reset */
|
||
|
- ret = regmap_write(regmap, TPS68470_REG_RESET, TPS68470_REG_RESET_MASK);
|
||
|
- if (ret)
|
||
|
- return ret;
|
||
|
-
|
||
|
- ret = regmap_read(regmap, TPS68470_REG_REVID, &version);
|
||
|
- if (ret) {
|
||
|
- dev_err(dev, "Failed to read revision register: %d\n", ret);
|
||
|
- return ret;
|
||
|
- }
|
||
|
-
|
||
|
- dev_info(dev, "TPS68470 REVID: 0x%x\n", version);
|
||
|
-
|
||
|
- return 0;
|
||
|
-}
|
||
|
-
|
||
|
-static int tps68470_probe(struct i2c_client *client)
|
||
|
-{
|
||
|
- struct device *dev = &client->dev;
|
||
|
- struct regmap *regmap;
|
||
|
- int ret;
|
||
|
-
|
||
|
- regmap = devm_regmap_init_i2c(client, &tps68470_regmap_config);
|
||
|
- if (IS_ERR(regmap)) {
|
||
|
- dev_err(dev, "devm_regmap_init_i2c Error %ld\n",
|
||
|
- PTR_ERR(regmap));
|
||
|
- return PTR_ERR(regmap);
|
||
|
- }
|
||
|
-
|
||
|
- i2c_set_clientdata(client, regmap);
|
||
|
-
|
||
|
- ret = tps68470_chip_init(dev, regmap);
|
||
|
- if (ret < 0) {
|
||
|
- dev_err(dev, "TPS68470 Init Error %d\n", ret);
|
||
|
- return ret;
|
||
|
- }
|
||
|
-
|
||
|
- ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, tps68470s,
|
||
|
- ARRAY_SIZE(tps68470s), NULL, 0, NULL);
|
||
|
- if (ret < 0) {
|
||
|
- dev_err(dev, "devm_mfd_add_devices failed: %d\n", ret);
|
||
|
- return ret;
|
||
|
- }
|
||
|
-
|
||
|
- return 0;
|
||
|
-}
|
||
|
-
|
||
|
-static const struct acpi_device_id tps68470_acpi_ids[] = {
|
||
|
- {"INT3472"},
|
||
|
- {},
|
||
|
-};
|
||
|
-
|
||
|
-static struct i2c_driver tps68470_driver = {
|
||
|
- .driver = {
|
||
|
- .name = "tps68470",
|
||
|
- .acpi_match_table = tps68470_acpi_ids,
|
||
|
- },
|
||
|
- .probe_new = tps68470_probe,
|
||
|
-};
|
||
|
-builtin_i2c_driver(tps68470_driver);
|
||
|
--
|
||
|
2.31.1
|
||
|
|
||
|
From c71b895f160e1a133b5648ba0efe2aceb1c0a3a8 Mon Sep 17 00:00:00 2001
|
||
|
From: Daniel Scally <djrscally@gmail.com>
|
||
|
Date: Mon, 5 Apr 2021 23:56:53 +0100
|
||
|
Subject: [PATCH] media: ipu3-cio2: Toggle sensor streaming in pm runtime ops
|
||
|
|
||
|
The .suspend() and .resume() runtime_pm operations for the ipu3-cio2
|
||
|
driver currently do not handle the sensor's stream. Setting .s_stream() on
|
||
|
or off for the sensor subdev means that sensors will pause and resume the
|
||
|
stream at the appropriate time even if their drivers don't implement those
|
||
|
operations.
|
||
|
|
||
|
Signed-off-by: Daniel Scally <djrscally@gmail.com>
|
||
|
Patchset: cameras
|
||
|
---
|
||
|
drivers/media/pci/intel/ipu3/ipu3-cio2-main.c | 15 ++++++++++++++-
|
||
|
1 file changed, 14 insertions(+), 1 deletion(-)
|
||
|
|
||
|
diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c b/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c
|
||
|
index 6e8c0c230e11..21e4d0358cdc 100644
|
||
|
--- a/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c
|
||
|
+++ b/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c
|
||
|
@@ -1973,12 +1973,19 @@ static int __maybe_unused cio2_suspend(struct device *dev)
|
||
|
struct pci_dev *pci_dev = to_pci_dev(dev);
|
||
|
struct cio2_device *cio2 = pci_get_drvdata(pci_dev);
|
||
|
struct cio2_queue *q = cio2->cur_queue;
|
||
|
+ int r;
|
||
|
|
||
|
dev_dbg(dev, "cio2 suspend\n");
|
||
|
if (!cio2->streaming)
|
||
|
return 0;
|
||
|
|
||
|
/* Stop stream */
|
||
|
+ r = v4l2_subdev_call(q->sensor, video, s_stream, 0);
|
||
|
+ if (r) {
|
||
|
+ dev_err(dev, "failed to stop sensor streaming\n");
|
||
|
+ return r;
|
||
|
+ }
|
||
|
+
|
||
|
cio2_hw_exit(cio2, q);
|
||
|
synchronize_irq(pci_dev->irq);
|
||
|
|
||
|
@@ -2013,8 +2020,14 @@ static int __maybe_unused cio2_resume(struct device *dev)
|
||
|
}
|
||
|
|
||
|
r = cio2_hw_init(cio2, q);
|
||
|
- if (r)
|
||
|
+ if (r) {
|
||
|
dev_err(dev, "fail to init cio2 hw\n");
|
||
|
+ return r;
|
||
|
+ }
|
||
|
+
|
||
|
+ r = v4l2_subdev_call(q->sensor, video, s_stream, 1);
|
||
|
+ if (r)
|
||
|
+ dev_err(dev, "fail to start sensor streaming\n");
|
||
|
|
||
|
return r;
|
||
|
}
|
||
|
--
|
||
|
2.31.1
|
||
|
|
||
|
From 8432e3e455f946d974d66de60b0b8a397c02ef3d Mon Sep 17 00:00:00 2001
|
||
|
From: Daniel Scally <djrscally@gmail.com>
|
||
|
Date: Mon, 5 Apr 2021 23:56:54 +0100
|
||
|
Subject: [PATCH] media: i2c: Add support for ov5693 sensor
|
||
|
|
||
|
The OV5693 is a 5 Mpx CMOS image sensor, connected via MIPI CSI-2. The
|
||
|
chip is capable of a single lane configuration, but currently only two
|
||
|
lanes are supported.
|
||
|
|
||
|
Most of the sensor's features are supported, with the main exception
|
||
|
being the lens correction algorithm.
|
||
|
|
||
|
The driver provides all mandatory, optional and recommended V4L2 controls
|
||
|
for maximum compatibility with libcamera.
|
||
|
|
||
|
Signed-off-by: Daniel Scally <djrscally@gmail.com>
|
||
|
Patchset: cameras
|
||
|
---
|
||
|
MAINTAINERS | 7 +
|
||
|
drivers/media/i2c/Kconfig | 11 +
|
||
|
drivers/media/i2c/Makefile | 1 +
|
||
|
drivers/media/i2c/ov5693.c | 1557 ++++++++++++++++++++++++++++++++++++
|
||
|
4 files changed, 1576 insertions(+)
|
||
|
create mode 100644 drivers/media/i2c/ov5693.c
|
||
|
|
||
|
diff --git a/MAINTAINERS b/MAINTAINERS
|
||
|
index 2a421d2e4b07..b270caa6f766 100644
|
||
|
--- a/MAINTAINERS
|
||
|
+++ b/MAINTAINERS
|
||
|
@@ -13276,6 +13276,13 @@ S: Maintained
|
||
|
T: git git://linuxtv.org/media_tree.git
|
||
|
F: drivers/media/i2c/ov5675.c
|
||
|
|
||
|
+OMNIVISION OV5693 SENSOR DRIVER
|
||
|
+M: Daniel Scally <djrscally@gmail.com>
|
||
|
+L: linux-media@vger.kernel.org
|
||
|
+S: Maintained
|
||
|
+T: git git://linuxtv.org/media_tree.git
|
||
|
+F: drivers/media/i2c/ov5693.c
|
||
|
+
|
||
|
OMNIVISION OV5695 SENSOR DRIVER
|
||
|
M: Shunqian Zheng <zhengsq@rock-chips.com>
|
||
|
L: linux-media@vger.kernel.org
|
||
|
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
|
||
|
index 462c0e059754..2893e74af99a 100644
|
||
|
--- a/drivers/media/i2c/Kconfig
|
||
|
+++ b/drivers/media/i2c/Kconfig
|
||
|
@@ -999,6 +999,17 @@ config VIDEO_OV5675
|
||
|
To compile this driver as a module, choose M here: the
|
||
|
module will be called ov5675.
|
||
|
|
||
|
+config VIDEO_OV5693
|
||
|
+ tristate "OmniVision OV5693 sensor support"
|
||
|
+ depends on I2C && VIDEO_V4L2
|
||
|
+ select V4L2_FWNODE
|
||
|
+ help
|
||
|
+ This is a Video4Linux2 sensor driver for the OmniVision
|
||
|
+ OV5693 camera.
|
||
|
+
|
||
|
+ To compile this driver as a module, choose M here: the
|
||
|
+ module will be called ov5693.
|
||
|
+
|
||
|
config VIDEO_OV5695
|
||
|
tristate "OmniVision OV5695 sensor support"
|
||
|
depends on I2C && VIDEO_V4L2
|
||
|
diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
|
||
|
index 0c067beca066..7d0884bc89f1 100644
|
||
|
--- a/drivers/media/i2c/Makefile
|
||
|
+++ b/drivers/media/i2c/Makefile
|
||
|
@@ -75,6 +75,7 @@ obj-$(CONFIG_VIDEO_OV5647) += ov5647.o
|
||
|
obj-$(CONFIG_VIDEO_OV5648) += ov5648.o
|
||
|
obj-$(CONFIG_VIDEO_OV5670) += ov5670.o
|
||
|
obj-$(CONFIG_VIDEO_OV5675) += ov5675.o
|
||
|
+obj-$(CONFIG_VIDEO_OV5693) += ov5693.o
|
||
|
obj-$(CONFIG_VIDEO_OV5695) += ov5695.o
|
||
|
obj-$(CONFIG_VIDEO_OV6650) += ov6650.o
|
||
|
obj-$(CONFIG_VIDEO_OV7251) += ov7251.o
|
||
|
diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c
|
||
|
new file mode 100644
|
||
|
index 000000000000..da2ca99a7ad3
|
||
|
--- /dev/null
|
||
|
+++ b/drivers/media/i2c/ov5693.c
|
||
|
@@ -0,0 +1,1557 @@
|
||
|
+// SPDX-License-Identifier: GPL-2.0
|
||
|
+/*
|
||
|
+ * Copyright (c) 2013 Intel Corporation. All Rights Reserved.
|
||
|
+ *
|
||
|
+ * Adapted from the atomisp-ov5693 driver, with contributions from:
|
||
|
+ *
|
||
|
+ * Daniel Scally
|
||
|
+ * Jean-Michel Hautbois
|
||
|
+ * Fabian Wuthrich
|
||
|
+ * Tsuchiya Yuto
|
||
|
+ * Jordan Hand
|
||
|
+ * Jake Day
|
||
|
+ */
|
||
|
+
|
||
|
+#include <asm/unaligned.h>
|
||
|
+#include <linux/acpi.h>
|
||
|
+#include <linux/clk.h>
|
||
|
+#include <linux/delay.h>
|
||
|
+#include <linux/device.h>
|
||
|
+#include <linux/i2c.h>
|
||
|
+#include <linux/module.h>
|
||
|
+#include <linux/pm_runtime.h>
|
||
|
+#include <linux/regulator/consumer.h>
|
||
|
+#include <linux/slab.h>
|
||
|
+#include <linux/types.h>
|
||
|
+#include <media/v4l2-ctrls.h>
|
||
|
+#include <media/v4l2-device.h>
|
||
|
+#include <media/v4l2-fwnode.h>
|
||
|
+
|
||
|
+/* System Control */
|
||
|
+#define OV5693_SW_RESET_REG 0x0103
|
||
|
+#define OV5693_SW_STREAM_REG 0x0100
|
||
|
+#define OV5693_START_STREAMING 0x01
|
||
|
+#define OV5693_STOP_STREAMING 0x00
|
||
|
+#define OV5693_SW_RESET 0x01
|
||
|
+
|
||
|
+#define OV5693_REG_CHIP_ID_H 0x300a
|
||
|
+#define OV5693_REG_CHIP_ID_L 0x300b
|
||
|
+/* Yes, this is right. The datasheet for the OV5693 gives its ID as 0x5690 */
|
||
|
+#define OV5693_CHIP_ID 0x5690
|
||
|
+
|
||
|
+/* Exposure */
|
||
|
+#define OV5693_EXPOSURE_L_CTRL_HH_REG 0x3500
|
||
|
+#define OV5693_EXPOSURE_L_CTRL_H_REG 0x3501
|
||
|
+#define OV5693_EXPOSURE_L_CTRL_L_REG 0x3502
|
||
|
+#define OV5693_EXPOSURE_CTRL_HH(v) (((v) & GENMASK(14, 12)) >> 12)
|
||
|
+#define OV5693_EXPOSURE_CTRL_H(v) (((v) & GENMASK(11, 4)) >> 4)
|
||
|
+#define OV5693_EXPOSURE_CTRL_L(v) (((v) & GENMASK(3, 0)) << 4)
|
||
|
+#define OV5693_INTEGRATION_TIME_MARGIN 8
|
||
|
+#define OV5693_EXPOSURE_MIN 1
|
||
|
+#define OV5693_EXPOSURE_STEP 1
|
||
|
+
|
||
|
+/* Analogue Gain */
|
||
|
+#define OV5693_GAIN_CTRL_H_REG 0x350a
|
||
|
+#define OV5693_GAIN_CTRL_H(v) (((v) >> 4) & GENMASK(2, 0))
|
||
|
+#define OV5693_GAIN_CTRL_L_REG 0x350b
|
||
|
+#define OV5693_GAIN_CTRL_L(v) (((v) << 4) & GENMASK(7, 4))
|
||
|
+#define OV5693_GAIN_MIN 1
|
||
|
+#define OV5693_GAIN_MAX 127
|
||
|
+#define OV5693_GAIN_DEF 8
|
||
|
+#define OV5693_GAIN_STEP 1
|
||
|
+
|
||
|
+/* Digital Gain */
|
||
|
+#define OV5693_MWB_RED_GAIN_H_REG 0x3400
|
||
|
+#define OV5693_MWB_RED_GAIN_L_REG 0x3401
|
||
|
+#define OV5693_MWB_GREEN_GAIN_H_REG 0x3402
|
||
|
+#define OV5693_MWB_GREEN_GAIN_L_REG 0x3403
|
||
|
+#define OV5693_MWB_BLUE_GAIN_H_REG 0x3404
|
||
|
+#define OV5693_MWB_BLUE_GAIN_L_REG 0x3405
|
||
|
+#define OV5693_MWB_GAIN_H_CTRL(v) (((v) >> 8) & GENMASK(3, 0))
|
||
|
+#define OV5693_MWB_GAIN_L_CTRL(v) ((v) & GENMASK(7, 0))
|
||
|
+#define OV5693_MWB_GAIN_MAX 0x0fff
|
||
|
+#define OV5693_DIGITAL_GAIN_MIN 1
|
||
|
+#define OV5693_DIGITAL_GAIN_MAX 4095
|
||
|
+#define OV5693_DIGITAL_GAIN_DEF 1024
|
||
|
+#define OV5693_DIGITAL_GAIN_STEP 1
|
||
|
+
|
||
|
+/* Timing and Format */
|
||
|
+#define OV5693_CROP_START_X_H_REG 0x3800
|
||
|
+#define OV5693_CROP_START_X_H(v) (((v) & GENMASK(12, 8)) >> 8)
|
||
|
+#define OV5693_CROP_START_X_L_REG 0x3801
|
||
|
+#define OV5693_CROP_START_X_L(v) ((v) & GENMASK(7, 0))
|
||
|
+
|
||
|
+#define OV5693_CROP_START_Y_H_REG 0x3802
|
||
|
+#define OV5693_CROP_START_Y_H(v) (((v) & GENMASK(11, 8)) >> 8)
|
||
|
+#define OV5693_CROP_START_Y_L_REG 0x3803
|
||
|
+#define OV5693_CROP_START_Y_L(v) ((v) & GENMASK(7, 0))
|
||
|
+
|
||
|
+#define OV5693_CROP_END_X_H_REG 0x3804
|
||
|
+#define OV5693_CROP_END_X_H(v) (((v) & GENMASK(12, 8)) >> 8)
|
||
|
+#define OV5693_CROP_END_X_L_REG 0x3805
|
||
|
+#define OV5693_CROP_END_X_L(v) ((v) & GENMASK(7, 0))
|
||
|
+
|
||
|
+#define OV5693_CROP_END_Y_H_REG 0x3806
|
||
|
+#define OV5693_CROP_END_Y_H(v) (((v) & GENMASK(11, 8)) >> 8)
|
||
|
+#define OV5693_CROP_END_Y_L_REG 0x3807
|
||
|
+#define OV5693_CROP_END_Y_L(v) ((v) & GENMASK(7, 0))
|
||
|
+
|
||
|
+#define OV5693_OUTPUT_SIZE_X_H_REG 0x3808
|
||
|
+#define OV5693_OUTPUT_SIZE_X_H(v) (((v) & GENMASK(15, 8)) >> 8)
|
||
|
+#define OV5693_OUTPUT_SIZE_X_L_REG 0x3809
|
||
|
+#define OV5693_OUTPUT_SIZE_X_L(v) ((v) & GENMASK(7, 0))
|
||
|
+
|
||
|
+#define OV5693_OUTPUT_SIZE_Y_H_REG 0x380a
|
||
|
+#define OV5693_OUTPUT_SIZE_Y_H(v) (((v) & GENMASK(15, 8)) >> 8)
|
||
|
+#define OV5693_OUTPUT_SIZE_Y_L_REG 0x380b
|
||
|
+#define OV5693_OUTPUT_SIZE_Y_L(v) ((v) & GENMASK(7, 0))
|
||
|
+
|
||
|
+#define OV5693_TIMING_HTS_H_REG 0x380c
|
||
|
+#define OV5693_TIMING_HTS_H(v) (((v) & GENMASK(15, 8)) >> 8)
|
||
|
+#define OV5693_TIMING_HTS_L_REG 0x380d
|
||
|
+#define OV5693_TIMING_HTS_L(v) ((v) & GENMASK(7, 0))
|
||
|
+#define OV5693_FIXED_PPL 2688U
|
||
|
+
|
||
|
+#define OV5693_TIMING_VTS_H_REG 0x380e
|
||
|
+#define OV5693_TIMING_VTS_H(v) (((v) & GENMASK(15, 8)) >> 8)
|
||
|
+#define OV5693_TIMING_VTS_L_REG 0x380f
|
||
|
+#define OV5693_TIMING_VTS_L(v) ((v) & GENMASK(7, 0))
|
||
|
+#define OV5693_TIMING_MAX_VTS 0xffff
|
||
|
+#define OV5693_TIMING_MIN_VTS 0x04
|
||
|
+
|
||
|
+#define OV5693_OFFSET_START_X_H_REG 0x3810
|
||
|
+#define OV5693_OFFSET_START_X_H(v) (((v) & GENMASK(15, 8)) >> 8)
|
||
|
+#define OV5693_OFFSET_START_X_L_REG 0x3811
|
||
|
+#define OV5693_OFFSET_START_X_L(v) ((v) & GENMASK(7, 0))
|
||
|
+
|
||
|
+#define OV5693_OFFSET_START_Y_H_REG 0x3812
|
||
|
+#define OV5693_OFFSET_START_Y_H(v) (((v) & GENMASK(15, 8)) >> 8)
|
||
|
+#define OV5693_OFFSET_START_Y_L_REG 0x3813
|
||
|
+#define OV5693_OFFSET_START_Y_L(v) ((v) & GENMASK(7, 0))
|
||
|
+
|
||
|
+#define OV5693_SUB_INC_X_REG 0x3814
|
||
|
+#define OV5693_SUB_INC_Y_REG 0x3815
|
||
|
+
|
||
|
+#define OV5693_FORMAT1_REG 0x3820
|
||
|
+#define OV5693_FORMAT1_FLIP_VERT_ISP_EN BIT(2)
|
||
|
+#define OV5693_FORMAT1_FLIP_VERT_SENSOR_EN BIT(1)
|
||
|
+#define OV5693_FORMAT1_VBIN_EN BIT(0)
|
||
|
+#define OV5693_FORMAT2_REG 0x3821
|
||
|
+#define OV5693_FORMAT2_HDR_EN BIT(7)
|
||
|
+#define OV5693_FORMAT2_FLIP_HORZ_ISP_EN BIT(2)
|
||
|
+#define OV5693_FORMAT2_FLIP_HORZ_SENSOR_EN BIT(1)
|
||
|
+#define OV5693_FORMAT2_HBIN_EN BIT(0)
|
||
|
+
|
||
|
+#define OV5693_ISP_CTRL2_REG 0x5002
|
||
|
+#define OV5693_ISP_SCALE_ENABLE BIT(7)
|
||
|
+
|
||
|
+/* Pixel Array */
|
||
|
+#define OV5693_NATIVE_WIDTH 2624
|
||
|
+#define OV5693_NATIVE_HEIGHT 1956
|
||
|
+#define OV5693_NATIVE_START_LEFT 0
|
||
|
+#define OV5693_NATIVE_START_TOP 0
|
||
|
+#define OV5693_ACTIVE_WIDTH 2592
|
||
|
+#define OV5693_ACTIVE_HEIGHT 1944
|
||
|
+#define OV5693_ACTIVE_START_LEFT 16
|
||
|
+#define OV5693_ACTIVE_START_TOP 6
|
||
|
+#define OV5693_MIN_CROP_WIDTH 2
|
||
|
+#define OV5693_MIN_CROP_HEIGHT 2
|
||
|
+
|
||
|
+/* Test Pattern */
|
||
|
+#define OV5693_TEST_PATTERN_REG 0x5e00
|
||
|
+#define OV5693_TEST_PATTERN_ENABLE BIT(7)
|
||
|
+#define OV5693_TEST_PATTERN_ROLLING BIT(6)
|
||
|
+#define OV5693_TEST_PATTERN_RANDOM 0x01
|
||
|
+#define OV5693_TEST_PATTERN_BARS 0x00
|
||
|
+
|
||
|
+/* System Frequencies */
|
||
|
+#define OV5693_XVCLK_FREQ 19200000
|
||
|
+#define OV5693_LINK_FREQ_400MHZ 400000000
|
||
|
+#define OV5693_PIXEL_RATE 160000000
|
||
|
+
|
||
|
+/* Miscellaneous */
|
||
|
+#define OV5693_NUM_SUPPLIES 2
|
||
|
+
|
||
|
+#define to_ov5693_sensor(x) container_of(x, struct ov5693_device, sd)
|
||
|
+
|
||
|
+struct ov5693_reg {
|
||
|
+ u16 reg;
|
||
|
+ u8 val;
|
||
|
+};
|
||
|
+
|
||
|
+struct ov5693_reg_list {
|
||
|
+ u32 num_regs;
|
||
|
+ const struct ov5693_reg *regs;
|
||
|
+};
|
||
|
+
|
||
|
+struct ov5693_device {
|
||
|
+ struct i2c_client *client;
|
||
|
+ struct device *dev;
|
||
|
+
|
||
|
+ /* Protect against concurrent changes to controls */
|
||
|
+ struct mutex lock;
|
||
|
+
|
||
|
+ struct gpio_desc *reset;
|
||
|
+ struct gpio_desc *powerdown;
|
||
|
+ struct regulator_bulk_data supplies[OV5693_NUM_SUPPLIES];
|
||
|
+ struct clk *clk;
|
||
|
+
|
||
|
+ struct ov5693_mode {
|
||
|
+ struct v4l2_rect crop;
|
||
|
+ struct v4l2_mbus_framefmt format;
|
||
|
+ bool binning_x;
|
||
|
+ bool binning_y;
|
||
|
+ unsigned int inc_x_odd;
|
||
|
+ unsigned int inc_y_odd;
|
||
|
+ unsigned int vts;
|
||
|
+ } mode;
|
||
|
+ bool streaming;
|
||
|
+
|
||
|
+ struct v4l2_subdev sd;
|
||
|
+ struct media_pad pad;
|
||
|
+
|
||
|
+ struct ov5693_v4l2_ctrls {
|
||
|
+ struct v4l2_ctrl_handler handler;
|
||
|
+ struct v4l2_ctrl *link_freq;
|
||
|
+ struct v4l2_ctrl *pixel_rate;
|
||
|
+ struct v4l2_ctrl *exposure;
|
||
|
+ struct v4l2_ctrl *analogue_gain;
|
||
|
+ struct v4l2_ctrl *digital_gain;
|
||
|
+ struct v4l2_ctrl *hflip;
|
||
|
+ struct v4l2_ctrl *vflip;
|
||
|
+ struct v4l2_ctrl *hblank;
|
||
|
+ struct v4l2_ctrl *vblank;
|
||
|
+ struct v4l2_ctrl *test_pattern;
|
||
|
+ } ctrls;
|
||
|
+};
|
||
|
+
|
||
|
+static const struct ov5693_reg ov5693_global_regs[] = {
|
||
|
+ {0x3016, 0xf0},
|
||
|
+ {0x3017, 0xf0},
|
||
|
+ {0x3018, 0xf0},
|
||
|
+ {0x3022, 0x01},
|
||
|
+ {0x3028, 0x44},
|
||
|
+ {0x3098, 0x02},
|
||
|
+ {0x3099, 0x19},
|
||
|
+ {0x309a, 0x02},
|
||
|
+ {0x309b, 0x01},
|
||
|
+ {0x309c, 0x00},
|
||
|
+ {0x30a0, 0xd2},
|
||
|
+ {0x30a2, 0x01},
|
||
|
+ {0x30b2, 0x00},
|
||
|
+ {0x30b3, 0x7d},
|
||
|
+ {0x30b4, 0x03},
|
||
|
+ {0x30b5, 0x04},
|
||
|
+ {0x30b6, 0x01},
|
||
|
+ {0x3104, 0x21},
|
||
|
+ {0x3106, 0x00},
|
||
|
+ {0x3406, 0x01},
|
||
|
+ {0x3503, 0x07},
|
||
|
+ {0x350b, 0x40},
|
||
|
+ {0x3601, 0x0a},
|
||
|
+ {0x3602, 0x38},
|
||
|
+ {0x3612, 0x80},
|
||
|
+ {0x3620, 0x54},
|
||
|
+ {0x3621, 0xc7},
|
||
|
+ {0x3622, 0x0f},
|
||
|
+ {0x3625, 0x10},
|
||
|
+ {0x3630, 0x55},
|
||
|
+ {0x3631, 0xf4},
|
||
|
+ {0x3632, 0x00},
|
||
|
+ {0x3633, 0x34},
|
||
|
+ {0x3634, 0x02},
|
||
|
+ {0x364d, 0x0d},
|
||
|
+ {0x364f, 0xdd},
|
||
|
+ {0x3660, 0x04},
|
||
|
+ {0x3662, 0x10},
|
||
|
+ {0x3663, 0xf1},
|
||
|
+ {0x3665, 0x00},
|
||
|
+ {0x3666, 0x20},
|
||
|
+ {0x3667, 0x00},
|
||
|
+ {0x366a, 0x80},
|
||
|
+ {0x3680, 0xe0},
|
||
|
+ {0x3681, 0x00},
|
||
|
+ {0x3700, 0x42},
|
||
|
+ {0x3701, 0x14},
|
||
|
+ {0x3702, 0xa0},
|
||
|
+ {0x3703, 0xd8},
|
||
|
+ {0x3704, 0x78},
|
||
|
+ {0x3705, 0x02},
|
||
|
+ {0x370a, 0x00},
|
||
|
+ {0x370b, 0x20},
|
||
|
+ {0x370c, 0x0c},
|
||
|
+ {0x370d, 0x11},
|
||
|
+ {0x370e, 0x00},
|
||
|
+ {0x370f, 0x40},
|
||
|
+ {0x3710, 0x00},
|
||
|
+ {0x371a, 0x1c},
|
||
|
+ {0x371b, 0x05},
|
||
|
+ {0x371c, 0x01},
|
||
|
+ {0x371e, 0xa1},
|
||
|
+ {0x371f, 0x0c},
|
||
|
+ {0x3721, 0x00},
|
||
|
+ {0x3724, 0x10},
|
||
|
+ {0x3726, 0x00},
|
||
|
+ {0x372a, 0x01},
|
||
|
+ {0x3730, 0x10},
|
||
|
+ {0x3738, 0x22},
|
||
|
+ {0x3739, 0xe5},
|
||
|
+ {0x373a, 0x50},
|
||
|
+ {0x373b, 0x02},
|
||
|
+ {0x373c, 0x41},
|
||
|
+ {0x373f, 0x02},
|
||
|
+ {0x3740, 0x42},
|
||
|
+ {0x3741, 0x02},
|
||
|
+ {0x3742, 0x18},
|
||
|
+ {0x3743, 0x01},
|
||
|
+ {0x3744, 0x02},
|
||
|
+ {0x3747, 0x10},
|
||
|
+ {0x374c, 0x04},
|
||
|
+ {0x3751, 0xf0},
|
||
|
+ {0x3752, 0x00},
|
||
|
+ {0x3753, 0x00},
|
||
|
+ {0x3754, 0xc0},
|
||
|
+ {0x3755, 0x00},
|
||
|
+ {0x3756, 0x1a},
|
||
|
+ {0x3758, 0x00},
|
||
|
+ {0x3759, 0x0f},
|
||
|
+ {0x376b, 0x44},
|
||
|
+ {0x375c, 0x04},
|
||
|
+ {0x3774, 0x10},
|
||
|
+ {0x3776, 0x00},
|
||
|
+ {0x377f, 0x08},
|
||
|
+ {0x3780, 0x22},
|
||
|
+ {0x3781, 0x0c},
|
||
|
+ {0x3784, 0x2c},
|
||
|
+ {0x3785, 0x1e},
|
||
|
+ {0x378f, 0xf5},
|
||
|
+ {0x3791, 0xb0},
|
||
|
+ {0x3795, 0x00},
|
||
|
+ {0x3796, 0x64},
|
||
|
+ {0x3797, 0x11},
|
||
|
+ {0x3798, 0x30},
|
||
|
+ {0x3799, 0x41},
|
||
|
+ {0x379a, 0x07},
|
||
|
+ {0x379b, 0xb0},
|
||
|
+ {0x379c, 0x0c},
|
||
|
+ {0x3a04, 0x06},
|
||
|
+ {0x3a05, 0x14},
|
||
|
+ {0x3e07, 0x20},
|
||
|
+ {0x4000, 0x08},
|
||
|
+ {0x4001, 0x04},
|
||
|
+ {0x4004, 0x08},
|
||
|
+ {0x4006, 0x20},
|
||
|
+ {0x4008, 0x24},
|
||
|
+ {0x4009, 0x10},
|
||
|
+ {0x4058, 0x00},
|
||
|
+ {0x4101, 0xb2},
|
||
|
+ {0x4307, 0x31},
|
||
|
+ {0x4511, 0x05},
|
||
|
+ {0x4512, 0x01},
|
||
|
+ {0x481f, 0x30},
|
||
|
+ {0x4826, 0x2c},
|
||
|
+ {0x4d02, 0xfd},
|
||
|
+ {0x4d03, 0xf5},
|
||
|
+ {0x4d04, 0x0c},
|
||
|
+ {0x4d05, 0xcc},
|
||
|
+ {0x4837, 0x0a},
|
||
|
+ {0x5003, 0x20},
|
||
|
+ {0x5013, 0x00},
|
||
|
+ {0x5842, 0x01},
|
||
|
+ {0x5843, 0x2b},
|
||
|
+ {0x5844, 0x01},
|
||
|
+ {0x5845, 0x92},
|
||
|
+ {0x5846, 0x01},
|
||
|
+ {0x5847, 0x8f},
|
||
|
+ {0x5848, 0x01},
|
||
|
+ {0x5849, 0x0c},
|
||
|
+ {0x5e10, 0x0c},
|
||
|
+ {0x3820, 0x00},
|
||
|
+ {0x3821, 0x1e},
|
||
|
+ {0x5041, 0x14}
|
||
|
+};
|
||
|
+
|
||
|
+static const struct ov5693_reg_list ov5693_global_setting = {
|
||
|
+ .num_regs = ARRAY_SIZE(ov5693_global_regs),
|
||
|
+ .regs = ov5693_global_regs,
|
||
|
+};
|
||
|
+
|
||
|
+static const struct v4l2_rect ov5693_default_crop = {
|
||
|
+ .left = OV5693_ACTIVE_START_LEFT,
|
||
|
+ .top = OV5693_ACTIVE_START_TOP,
|
||
|
+ .width = OV5693_ACTIVE_WIDTH,
|
||
|
+ .height = OV5693_ACTIVE_HEIGHT,
|
||
|
+};
|
||
|
+
|
||
|
+static const struct v4l2_mbus_framefmt ov5693_default_fmt = {
|
||
|
+ .width = OV5693_ACTIVE_WIDTH,
|
||
|
+ .height = OV5693_ACTIVE_HEIGHT,
|
||
|
+ .code = MEDIA_BUS_FMT_SBGGR10_1X10,
|
||
|
+};
|
||
|
+
|
||
|
+static const s64 link_freq_menu_items[] = {
|
||
|
+ OV5693_LINK_FREQ_400MHZ
|
||
|
+};
|
||
|
+
|
||
|
+static const char * const ov5693_supply_names[] = {
|
||
|
+ "avdd",
|
||
|
+ "dovdd",
|
||
|
+};
|
||
|
+
|
||
|
+static const char * const ov5693_test_pattern_menu[] = {
|
||
|
+ "Disabled",
|
||
|
+ "Random Data",
|
||
|
+ "Colour Bars",
|
||
|
+ "Colour Bars with Rolling Bar"
|
||
|
+};
|
||
|
+
|
||
|
+static const u8 ov5693_test_pattern_bits[] = {
|
||
|
+ 0,
|
||
|
+ OV5693_TEST_PATTERN_ENABLE | OV5693_TEST_PATTERN_RANDOM,
|
||
|
+ OV5693_TEST_PATTERN_ENABLE | OV5693_TEST_PATTERN_BARS,
|
||
|
+ OV5693_TEST_PATTERN_ENABLE | OV5693_TEST_PATTERN_BARS |
|
||
|
+ OV5693_TEST_PATTERN_ROLLING,
|
||
|
+};
|
||
|
+
|
||
|
+/* I2C I/O Operations */
|
||
|
+
|
||
|
+static int ov5693_read_reg(struct ov5693_device *ov5693, u16 addr, u8 *value)
|
||
|
+{
|
||
|
+ struct i2c_client *client = ov5693->client;
|
||
|
+ struct i2c_msg msgs[2];
|
||
|
+ u8 addr_buf[2];
|
||
|
+ u8 data_buf;
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ put_unaligned_be16(addr, addr_buf);
|
||
|
+
|
||
|
+ /* Write register address */
|
||
|
+ msgs[0].addr = client->addr;
|
||
|
+ msgs[0].flags = 0;
|
||
|
+ msgs[0].len = ARRAY_SIZE(addr_buf);
|
||
|
+ msgs[0].buf = addr_buf;
|
||
|
+
|
||
|
+ /* Read register value */
|
||
|
+ msgs[1].addr = client->addr;
|
||
|
+ msgs[1].flags = I2C_M_RD;
|
||
|
+ msgs[1].len = 1;
|
||
|
+ msgs[1].buf = &data_buf;
|
||
|
+
|
||
|
+ ret = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs));
|
||
|
+ if (ret != ARRAY_SIZE(msgs))
|
||
|
+ return -EIO;
|
||
|
+
|
||
|
+ *value = data_buf;
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static void ov5693_write_reg(struct ov5693_device *ov5693, u16 addr, u8 value,
|
||
|
+ int *error)
|
||
|
+{
|
||
|
+ unsigned char data[3] = { addr >> 8, addr & 0xff, value };
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ if (*error < 0)
|
||
|
+ return;
|
||
|
+
|
||
|
+ ret = i2c_master_send(ov5693->client, data, sizeof(data));
|
||
|
+ if (ret < 0) {
|
||
|
+ dev_dbg(ov5693->dev, "i2c send error at address 0x%04x: %d\n",
|
||
|
+ addr, ret);
|
||
|
+ *error = ret;
|
||
|
+ }
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_write_reg_array(struct ov5693_device *ov5693,
|
||
|
+ const struct ov5693_reg_list *reglist)
|
||
|
+{
|
||
|
+ unsigned int i;
|
||
|
+ int ret = 0;
|
||
|
+
|
||
|
+ for (i = 0; i < reglist->num_regs; i++)
|
||
|
+ ov5693_write_reg(ov5693, reglist->regs[i].reg,
|
||
|
+ reglist->regs[i].val, &ret);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_update_bits(struct ov5693_device *ov5693, u16 address,
|
||
|
+ u16 mask, u16 bits)
|
||
|
+{
|
||
|
+ u8 value = 0;
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ ret = ov5693_read_reg(ov5693, address, &value);
|
||
|
+ if (ret)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ value &= ~mask;
|
||
|
+ value |= bits;
|
||
|
+
|
||
|
+ ov5693_write_reg(ov5693, address, value, &ret);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+/* V4L2 Controls Functions */
|
||
|
+
|
||
|
+static int ov5693_flip_vert_configure(struct ov5693_device *ov5693, bool enable)
|
||
|
+{
|
||
|
+ u8 bits = OV5693_FORMAT1_FLIP_VERT_ISP_EN |
|
||
|
+ OV5693_FORMAT1_FLIP_VERT_SENSOR_EN;
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ ret = ov5693_update_bits(ov5693, OV5693_FORMAT1_REG, bits,
|
||
|
+ enable ? bits : 0);
|
||
|
+ if (ret)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_flip_horz_configure(struct ov5693_device *ov5693, bool enable)
|
||
|
+{
|
||
|
+ u8 bits = OV5693_FORMAT2_FLIP_HORZ_ISP_EN |
|
||
|
+ OV5693_FORMAT2_FLIP_HORZ_SENSOR_EN;
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ ret = ov5693_update_bits(ov5693, OV5693_FORMAT2_REG, bits,
|
||
|
+ enable ? bits : 0);
|
||
|
+ if (ret)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_get_exposure(struct ov5693_device *ov5693, s32 *value)
|
||
|
+{
|
||
|
+ u8 exposure_hh = 0, exposure_h = 0, exposure_l = 0;
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ ret = ov5693_read_reg(ov5693, OV5693_EXPOSURE_L_CTRL_HH_REG, &exposure_hh);
|
||
|
+ if (ret)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ ret = ov5693_read_reg(ov5693, OV5693_EXPOSURE_L_CTRL_H_REG, &exposure_h);
|
||
|
+ if (ret)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ ret = ov5693_read_reg(ov5693, OV5693_EXPOSURE_L_CTRL_L_REG, &exposure_l);
|
||
|
+ if (ret)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ /* The lowest 4 bits are unsupported fractional bits */
|
||
|
+ *value = ((exposure_hh << 16) | (exposure_h << 8) | exposure_l) >> 4;
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_exposure_configure(struct ov5693_device *ov5693, u32 exposure)
|
||
|
+{
|
||
|
+ int ret = 0;
|
||
|
+
|
||
|
+ ov5693_write_reg(ov5693, OV5693_EXPOSURE_L_CTRL_HH_REG,
|
||
|
+ OV5693_EXPOSURE_CTRL_HH(exposure), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_EXPOSURE_L_CTRL_H_REG,
|
||
|
+ OV5693_EXPOSURE_CTRL_H(exposure), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_EXPOSURE_L_CTRL_L_REG,
|
||
|
+ OV5693_EXPOSURE_CTRL_L(exposure), &ret);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_get_gain(struct ov5693_device *ov5693, u32 *gain)
|
||
|
+{
|
||
|
+ u8 gain_l = 0, gain_h = 0;
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ ret = ov5693_read_reg(ov5693, OV5693_GAIN_CTRL_H_REG, &gain_h);
|
||
|
+ if (ret)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ ret = ov5693_read_reg(ov5693, OV5693_GAIN_CTRL_L_REG, &gain_l);
|
||
|
+ if (ret)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ /* As with exposure, the lowest 4 bits are fractional bits. */
|
||
|
+ *gain = ((gain_h << 8) | gain_l) >> 4;
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_digital_gain_configure(struct ov5693_device *ov5693, u32 gain)
|
||
|
+{
|
||
|
+ int ret = 0;
|
||
|
+
|
||
|
+ ov5693_write_reg(ov5693, OV5693_MWB_RED_GAIN_H_REG,
|
||
|
+ OV5693_MWB_GAIN_H_CTRL(gain), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_MWB_RED_GAIN_L_REG,
|
||
|
+ OV5693_MWB_GAIN_L_CTRL(gain), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_MWB_GREEN_GAIN_H_REG,
|
||
|
+ OV5693_MWB_GAIN_H_CTRL(gain), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_MWB_GREEN_GAIN_L_REG,
|
||
|
+ OV5693_MWB_GAIN_L_CTRL(gain), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_MWB_BLUE_GAIN_H_REG,
|
||
|
+ OV5693_MWB_GAIN_H_CTRL(gain), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_MWB_BLUE_GAIN_L_REG,
|
||
|
+ OV5693_MWB_GAIN_L_CTRL(gain), &ret);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_analog_gain_configure(struct ov5693_device *ov5693, u32 gain)
|
||
|
+{
|
||
|
+ int ret = 0;
|
||
|
+
|
||
|
+ ov5693_write_reg(ov5693, OV5693_GAIN_CTRL_L_REG,
|
||
|
+ OV5693_GAIN_CTRL_L(gain), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_GAIN_CTRL_H_REG,
|
||
|
+ OV5693_GAIN_CTRL_H(gain), &ret);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_vts_configure(struct ov5693_device *ov5693, u32 vblank)
|
||
|
+{
|
||
|
+ u16 vts = ov5693->mode.format.height + vblank;
|
||
|
+ int ret = 0;
|
||
|
+
|
||
|
+ ov5693_write_reg(ov5693, OV5693_TIMING_VTS_H_REG,
|
||
|
+ OV5693_TIMING_VTS_H(vts), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_TIMING_VTS_L_REG,
|
||
|
+ OV5693_TIMING_VTS_L(vts), &ret);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_test_pattern_configure(struct ov5693_device *ov5693, u32 idx)
|
||
|
+{
|
||
|
+ int ret = 0;
|
||
|
+
|
||
|
+ ov5693_write_reg(ov5693, OV5693_TEST_PATTERN_REG,
|
||
|
+ ov5693_test_pattern_bits[idx], &ret);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_s_ctrl(struct v4l2_ctrl *ctrl)
|
||
|
+{
|
||
|
+ struct ov5693_device *ov5693 =
|
||
|
+ container_of(ctrl->handler, struct ov5693_device, ctrls.handler);
|
||
|
+ int ret = 0;
|
||
|
+
|
||
|
+ /* If VBLANK is altered we need to update exposure to compensate */
|
||
|
+ if (ctrl->id == V4L2_CID_VBLANK) {
|
||
|
+ int exposure_max;
|
||
|
+
|
||
|
+ exposure_max = ov5693->mode.format.height + ctrl->val -
|
||
|
+ OV5693_INTEGRATION_TIME_MARGIN;
|
||
|
+ __v4l2_ctrl_modify_range(ov5693->ctrls.exposure,
|
||
|
+ ov5693->ctrls.exposure->minimum,
|
||
|
+ exposure_max,
|
||
|
+ ov5693->ctrls.exposure->step,
|
||
|
+ min(ov5693->ctrls.exposure->val, exposure_max));
|
||
|
+ }
|
||
|
+
|
||
|
+ /* Only apply changes to the controls if the device is powered up */
|
||
|
+ if (!pm_runtime_get_if_in_use(ov5693->dev))
|
||
|
+ return 0;
|
||
|
+
|
||
|
+ switch (ctrl->id) {
|
||
|
+ case V4L2_CID_EXPOSURE:
|
||
|
+ ret = ov5693_exposure_configure(ov5693, ctrl->val);
|
||
|
+ break;
|
||
|
+ case V4L2_CID_ANALOGUE_GAIN:
|
||
|
+ ret = ov5693_analog_gain_configure(ov5693, ctrl->val);
|
||
|
+ break;
|
||
|
+ case V4L2_CID_DIGITAL_GAIN:
|
||
|
+ ret = ov5693_digital_gain_configure(ov5693, ctrl->val);
|
||
|
+ break;
|
||
|
+ case V4L2_CID_HFLIP:
|
||
|
+ ret = ov5693_flip_horz_configure(ov5693, !!ctrl->val);
|
||
|
+ break;
|
||
|
+ case V4L2_CID_VFLIP:
|
||
|
+ ret = ov5693_flip_vert_configure(ov5693, !!ctrl->val);
|
||
|
+ break;
|
||
|
+ case V4L2_CID_VBLANK:
|
||
|
+ ret = ov5693_vts_configure(ov5693, ctrl->val);
|
||
|
+ break;
|
||
|
+ case V4L2_CID_TEST_PATTERN:
|
||
|
+ ret = ov5693_test_pattern_configure(ov5693, ctrl->val);
|
||
|
+ break;
|
||
|
+ default:
|
||
|
+ ret = -EINVAL;
|
||
|
+ }
|
||
|
+
|
||
|
+ pm_runtime_put(ov5693->dev);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_g_volatile_ctrl(struct v4l2_ctrl *ctrl)
|
||
|
+{
|
||
|
+ struct ov5693_device *ov5693 =
|
||
|
+ container_of(ctrl->handler, struct ov5693_device, ctrls.handler);
|
||
|
+
|
||
|
+ switch (ctrl->id) {
|
||
|
+ case V4L2_CID_EXPOSURE_ABSOLUTE:
|
||
|
+ return ov5693_get_exposure(ov5693, &ctrl->val);
|
||
|
+ case V4L2_CID_AUTOGAIN:
|
||
|
+ return ov5693_get_gain(ov5693, &ctrl->val);
|
||
|
+ default:
|
||
|
+ return -EINVAL;
|
||
|
+ }
|
||
|
+}
|
||
|
+
|
||
|
+static const struct v4l2_ctrl_ops ov5693_ctrl_ops = {
|
||
|
+ .s_ctrl = ov5693_s_ctrl,
|
||
|
+ .g_volatile_ctrl = ov5693_g_volatile_ctrl
|
||
|
+};
|
||
|
+
|
||
|
+/* System Control Functions */
|
||
|
+
|
||
|
+static int ov5693_mode_configure(struct ov5693_device *ov5693)
|
||
|
+{
|
||
|
+ const struct ov5693_mode *mode = &ov5693->mode;
|
||
|
+ int ret = 0;
|
||
|
+
|
||
|
+ /* Crop Start X */
|
||
|
+ ov5693_write_reg(ov5693, OV5693_CROP_START_X_H_REG,
|
||
|
+ OV5693_CROP_START_X_H(mode->crop.left), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_CROP_START_X_L_REG,
|
||
|
+ OV5693_CROP_START_X_L(mode->crop.left), &ret);
|
||
|
+
|
||
|
+ /* Offset X */
|
||
|
+ ov5693_write_reg(ov5693, OV5693_OFFSET_START_X_H_REG,
|
||
|
+ OV5693_OFFSET_START_X_H(0), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_OFFSET_START_X_L_REG,
|
||
|
+ OV5693_OFFSET_START_X_L(0), &ret);
|
||
|
+
|
||
|
+ /* Output Size X */
|
||
|
+ ov5693_write_reg(ov5693, OV5693_OUTPUT_SIZE_X_H_REG,
|
||
|
+ OV5693_OUTPUT_SIZE_X_H(mode->format.width), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_OUTPUT_SIZE_X_L_REG,
|
||
|
+ OV5693_OUTPUT_SIZE_X_L(mode->format.width), &ret);
|
||
|
+
|
||
|
+ /* Crop End X */
|
||
|
+ ov5693_write_reg(ov5693, OV5693_CROP_END_X_H_REG,
|
||
|
+ OV5693_CROP_END_X_H(mode->crop.left + mode->crop.width),
|
||
|
+ &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_CROP_END_X_L_REG,
|
||
|
+ OV5693_CROP_END_X_L(mode->crop.left + mode->crop.width),
|
||
|
+ &ret);
|
||
|
+
|
||
|
+ /* Horizontal Total Size */
|
||
|
+ ov5693_write_reg(ov5693, OV5693_TIMING_HTS_H_REG,
|
||
|
+ OV5693_TIMING_HTS_H(OV5693_FIXED_PPL), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_TIMING_HTS_L_REG,
|
||
|
+ OV5693_TIMING_HTS_L(OV5693_FIXED_PPL), &ret);
|
||
|
+
|
||
|
+ /* Crop Start Y */
|
||
|
+ ov5693_write_reg(ov5693, OV5693_CROP_START_Y_H_REG,
|
||
|
+ OV5693_CROP_START_Y_H(mode->crop.top), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_CROP_START_Y_L_REG,
|
||
|
+ OV5693_CROP_START_Y_L(mode->crop.top), &ret);
|
||
|
+
|
||
|
+ /* Offset Y */
|
||
|
+ ov5693_write_reg(ov5693, OV5693_OFFSET_START_Y_H_REG,
|
||
|
+ OV5693_OFFSET_START_Y_H(0), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_OFFSET_START_Y_L_REG,
|
||
|
+ OV5693_OFFSET_START_Y_L(0), &ret);
|
||
|
+
|
||
|
+ /* Output Size Y */
|
||
|
+ ov5693_write_reg(ov5693, OV5693_OUTPUT_SIZE_Y_H_REG,
|
||
|
+ OV5693_OUTPUT_SIZE_Y_H(mode->format.height), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_OUTPUT_SIZE_Y_L_REG,
|
||
|
+ OV5693_OUTPUT_SIZE_Y_L(mode->format.height), &ret);
|
||
|
+
|
||
|
+ /* Crop End Y */
|
||
|
+ ov5693_write_reg(ov5693, OV5693_CROP_END_Y_H_REG,
|
||
|
+ OV5693_CROP_END_Y_H(mode->crop.top + mode->crop.height),
|
||
|
+ &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_CROP_END_Y_L_REG,
|
||
|
+ OV5693_CROP_END_Y_L(mode->crop.top + mode->crop.height),
|
||
|
+ &ret);
|
||
|
+
|
||
|
+ /* Vertical Total Size */
|
||
|
+ ov5693_write_reg(ov5693, OV5693_TIMING_VTS_H_REG,
|
||
|
+ OV5693_TIMING_VTS_H(mode->vts), &ret);
|
||
|
+ ov5693_write_reg(ov5693, OV5693_TIMING_VTS_L_REG,
|
||
|
+ OV5693_TIMING_VTS_L(mode->vts), &ret);
|
||
|
+
|
||
|
+ /* Subsample X increase */
|
||
|
+ ov5693_write_reg(ov5693, OV5693_SUB_INC_X_REG,
|
||
|
+ ((mode->inc_x_odd << 4) & 0xf0) | 0x01, &ret);
|
||
|
+ /* Subsample Y increase */
|
||
|
+ ov5693_write_reg(ov5693, OV5693_SUB_INC_Y_REG,
|
||
|
+ ((mode->inc_y_odd << 4) & 0xf0) | 0x01, &ret);
|
||
|
+
|
||
|
+ /* Binning */
|
||
|
+ ret = ov5693_update_bits(ov5693, OV5693_FORMAT1_REG,
|
||
|
+ OV5693_FORMAT1_VBIN_EN,
|
||
|
+ mode->binning_y ? OV5693_FORMAT1_VBIN_EN : 0);
|
||
|
+ if (ret)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ ret = ov5693_update_bits(ov5693, OV5693_FORMAT2_REG,
|
||
|
+ OV5693_FORMAT2_HBIN_EN,
|
||
|
+ mode->binning_x ? OV5693_FORMAT2_HBIN_EN : 0);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_sw_standby(struct ov5693_device *ov5693, bool standby)
|
||
|
+{
|
||
|
+ int ret = 0;
|
||
|
+
|
||
|
+ ov5693_write_reg(ov5693, OV5693_SW_STREAM_REG,
|
||
|
+ standby ? OV5693_STOP_STREAMING : OV5693_START_STREAMING,
|
||
|
+ &ret);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_sw_reset(struct ov5693_device *ov5693)
|
||
|
+{
|
||
|
+ int ret = 0;
|
||
|
+
|
||
|
+ ov5693_write_reg(ov5693, OV5693_SW_RESET_REG, OV5693_SW_RESET, &ret);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_sensor_init(struct ov5693_device *ov5693)
|
||
|
+{
|
||
|
+ int ret = 0;
|
||
|
+
|
||
|
+ ret = ov5693_sw_reset(ov5693);
|
||
|
+ if (ret) {
|
||
|
+ dev_err(ov5693->dev, "%s software reset error\n", __func__);
|
||
|
+ return ret;
|
||
|
+ }
|
||
|
+
|
||
|
+ ret = ov5693_write_reg_array(ov5693, &ov5693_global_setting);
|
||
|
+ if (ret) {
|
||
|
+ dev_err(ov5693->dev, "%s global settings error\n", __func__);
|
||
|
+ return ret;
|
||
|
+ }
|
||
|
+
|
||
|
+ ret = ov5693_mode_configure(ov5693);
|
||
|
+ if (ret) {
|
||
|
+ dev_err(ov5693->dev, "%s mode configure error\n", __func__);
|
||
|
+ return ret;
|
||
|
+ }
|
||
|
+
|
||
|
+ ret = ov5693_sw_standby(ov5693, true);
|
||
|
+ if (ret)
|
||
|
+ dev_err(ov5693->dev, "%s software standby error\n", __func__);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static void ov5693_sensor_powerdown(struct ov5693_device *ov5693)
|
||
|
+{
|
||
|
+ gpiod_set_value_cansleep(ov5693->reset, 1);
|
||
|
+ gpiod_set_value_cansleep(ov5693->powerdown, 1);
|
||
|
+
|
||
|
+ regulator_bulk_disable(OV5693_NUM_SUPPLIES, ov5693->supplies);
|
||
|
+
|
||
|
+ clk_disable_unprepare(ov5693->clk);
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_sensor_powerup(struct ov5693_device *ov5693)
|
||
|
+{
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ gpiod_set_value_cansleep(ov5693->reset, 1);
|
||
|
+ gpiod_set_value_cansleep(ov5693->powerdown, 1);
|
||
|
+
|
||
|
+ ret = clk_prepare_enable(ov5693->clk);
|
||
|
+ if (ret) {
|
||
|
+ dev_err(ov5693->dev, "Failed to enable clk\n");
|
||
|
+ goto fail_power;
|
||
|
+ }
|
||
|
+
|
||
|
+ ret = regulator_bulk_enable(OV5693_NUM_SUPPLIES, ov5693->supplies);
|
||
|
+ if (ret) {
|
||
|
+ dev_err(ov5693->dev, "Failed to enable regulators\n");
|
||
|
+ goto fail_power;
|
||
|
+ }
|
||
|
+
|
||
|
+ gpiod_set_value_cansleep(ov5693->powerdown, 0);
|
||
|
+ gpiod_set_value_cansleep(ov5693->reset, 0);
|
||
|
+
|
||
|
+ usleep_range(5000, 7500);
|
||
|
+
|
||
|
+ return 0;
|
||
|
+
|
||
|
+fail_power:
|
||
|
+ ov5693_sensor_powerdown(ov5693);
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int __maybe_unused ov5693_sensor_suspend(struct device *dev)
|
||
|
+{
|
||
|
+ struct v4l2_subdev *sd = dev_get_drvdata(dev);
|
||
|
+ struct ov5693_device *ov5693 = to_ov5693_sensor(sd);
|
||
|
+
|
||
|
+ ov5693_sensor_powerdown(ov5693);
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static int __maybe_unused ov5693_sensor_resume(struct device *dev)
|
||
|
+{
|
||
|
+ struct v4l2_subdev *sd = dev_get_drvdata(dev);
|
||
|
+ struct ov5693_device *ov5693 = to_ov5693_sensor(sd);
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ mutex_lock(&ov5693->lock);
|
||
|
+
|
||
|
+ ret = ov5693_sensor_powerup(ov5693);
|
||
|
+ if (ret)
|
||
|
+ goto out_unlock;
|
||
|
+
|
||
|
+ ret = ov5693_sensor_init(ov5693);
|
||
|
+ if (ret) {
|
||
|
+ dev_err(dev, "ov5693 sensor init failure\n");
|
||
|
+ goto err_power;
|
||
|
+ }
|
||
|
+
|
||
|
+ goto out_unlock;
|
||
|
+
|
||
|
+err_power:
|
||
|
+ ov5693_sensor_powerdown(ov5693);
|
||
|
+out_unlock:
|
||
|
+ mutex_unlock(&ov5693->lock);
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_detect(struct ov5693_device *ov5693)
|
||
|
+{
|
||
|
+ u8 id_l = 0, id_h = 0;
|
||
|
+ u16 id = 0;
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ ret = ov5693_read_reg(ov5693, OV5693_REG_CHIP_ID_H, &id_h);
|
||
|
+ if (ret)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ ret = ov5693_read_reg(ov5693, OV5693_REG_CHIP_ID_L, &id_l);
|
||
|
+ if (ret)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ id = (id_h << 8) | id_l;
|
||
|
+
|
||
|
+ if (id != OV5693_CHIP_ID) {
|
||
|
+ dev_err(ov5693->dev, "sensor ID mismatch. Found 0x%04x\n", id);
|
||
|
+ return -ENODEV;
|
||
|
+ }
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+/* V4L2 Framework callbacks */
|
||
|
+
|
||
|
+static unsigned int __ov5693_calc_vts(u32 height)
|
||
|
+{
|
||
|
+ /*
|
||
|
+ * We need to set a sensible default VTS for whatever format height we
|
||
|
+ * happen to be given from set_fmt(). This function just targets
|
||
|
+ * an even multiple of 30fps.
|
||
|
+ */
|
||
|
+
|
||
|
+ unsigned int tgt_fps;
|
||
|
+
|
||
|
+ tgt_fps = rounddown(OV5693_PIXEL_RATE / OV5693_FIXED_PPL / height, 30);
|
||
|
+
|
||
|
+ return ALIGN_DOWN(OV5693_PIXEL_RATE / OV5693_FIXED_PPL / tgt_fps, 2);
|
||
|
+}
|
||
|
+
|
||
|
+static struct v4l2_mbus_framefmt *
|
||
|
+__ov5693_get_pad_format(struct ov5693_device *ov5693,
|
||
|
+ struct v4l2_subdev_pad_config *cfg,
|
||
|
+ unsigned int pad, enum v4l2_subdev_format_whence which)
|
||
|
+{
|
||
|
+ switch (which) {
|
||
|
+ case V4L2_SUBDEV_FORMAT_TRY:
|
||
|
+ return v4l2_subdev_get_try_format(&ov5693->sd, cfg, pad);
|
||
|
+ case V4L2_SUBDEV_FORMAT_ACTIVE:
|
||
|
+ return &ov5693->mode.format;
|
||
|
+ default:
|
||
|
+ return NULL;
|
||
|
+ }
|
||
|
+}
|
||
|
+
|
||
|
+static struct v4l2_rect *
|
||
|
+__ov5693_get_pad_crop(struct ov5693_device *ov5693,
|
||
|
+ struct v4l2_subdev_pad_config *cfg,
|
||
|
+ unsigned int pad, enum v4l2_subdev_format_whence which)
|
||
|
+{
|
||
|
+ switch (which) {
|
||
|
+ case V4L2_SUBDEV_FORMAT_TRY:
|
||
|
+ return v4l2_subdev_get_try_crop(&ov5693->sd, cfg, pad);
|
||
|
+ case V4L2_SUBDEV_FORMAT_ACTIVE:
|
||
|
+ return &ov5693->mode.crop;
|
||
|
+ }
|
||
|
+
|
||
|
+ return NULL;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_get_fmt(struct v4l2_subdev *sd,
|
||
|
+ struct v4l2_subdev_pad_config *cfg,
|
||
|
+ struct v4l2_subdev_format *format)
|
||
|
+{
|
||
|
+ struct ov5693_device *ov5693 = to_ov5693_sensor(sd);
|
||
|
+
|
||
|
+ format->format = ov5693->mode.format;
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_set_fmt(struct v4l2_subdev *sd,
|
||
|
+ struct v4l2_subdev_pad_config *cfg,
|
||
|
+ struct v4l2_subdev_format *format)
|
||
|
+{
|
||
|
+ struct ov5693_device *ov5693 = to_ov5693_sensor(sd);
|
||
|
+ const struct v4l2_rect *crop;
|
||
|
+ struct v4l2_mbus_framefmt *fmt;
|
||
|
+ unsigned int hratio, vratio;
|
||
|
+ unsigned int width, height;
|
||
|
+ unsigned int hblank;
|
||
|
+ int exposure_max;
|
||
|
+ int ret = 0;
|
||
|
+
|
||
|
+ crop = __ov5693_get_pad_crop(ov5693, cfg, format->pad, format->which);
|
||
|
+
|
||
|
+ /*
|
||
|
+ * Align to two to simplify the binning calculations below, and clamp
|
||
|
+ * the requested format at the crop rectangle
|
||
|
+ */
|
||
|
+ width = clamp_t(unsigned int, ALIGN(format->format.width, 2),
|
||
|
+ OV5693_MIN_CROP_WIDTH, crop->width);
|
||
|
+ height = clamp_t(unsigned int, ALIGN(format->format.height, 2),
|
||
|
+ OV5693_MIN_CROP_HEIGHT, crop->height);
|
||
|
+
|
||
|
+ /*
|
||
|
+ * We can only support setting either the dimensions of the crop rect
|
||
|
+ * or those dimensions binned (separately) by a factor of two.
|
||
|
+ */
|
||
|
+ hratio = clamp_t(unsigned int, DIV_ROUND_CLOSEST(crop->width, width), 1, 2);
|
||
|
+ vratio = clamp_t(unsigned int, DIV_ROUND_CLOSEST(crop->height, height), 1, 2);
|
||
|
+
|
||
|
+ fmt = __ov5693_get_pad_format(ov5693, cfg, format->pad, format->which);
|
||
|
+
|
||
|
+ fmt->width = crop->width / hratio;
|
||
|
+ fmt->height = crop->height / vratio;
|
||
|
+ fmt->code = MEDIA_BUS_FMT_SBGGR10_1X10;
|
||
|
+
|
||
|
+ format->format = *fmt;
|
||
|
+
|
||
|
+ if (format->which == V4L2_SUBDEV_FORMAT_TRY)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ mutex_lock(&ov5693->lock);
|
||
|
+
|
||
|
+ ov5693->mode.binning_x = hratio > 1 ? true : false;
|
||
|
+ ov5693->mode.inc_x_odd = hratio > 1 ? 3 : 1;
|
||
|
+ ov5693->mode.binning_y = vratio > 1 ? true : false;
|
||
|
+ ov5693->mode.inc_y_odd = vratio > 1 ? 3 : 1;
|
||
|
+
|
||
|
+ ov5693->mode.vts = __ov5693_calc_vts(fmt->height);
|
||
|
+
|
||
|
+ __v4l2_ctrl_modify_range(ov5693->ctrls.vblank,
|
||
|
+ OV5693_TIMING_MIN_VTS,
|
||
|
+ OV5693_TIMING_MAX_VTS - fmt->height,
|
||
|
+ 1, ov5693->mode.vts - fmt->height);
|
||
|
+ __v4l2_ctrl_s_ctrl(ov5693->ctrls.vblank,
|
||
|
+ ov5693->mode.vts - fmt->height);
|
||
|
+
|
||
|
+ hblank = OV5693_FIXED_PPL - fmt->width;
|
||
|
+ __v4l2_ctrl_modify_range(ov5693->ctrls.hblank, hblank, hblank, 1,
|
||
|
+ hblank);
|
||
|
+
|
||
|
+ exposure_max = ov5693->mode.vts - OV5693_INTEGRATION_TIME_MARGIN;
|
||
|
+ __v4l2_ctrl_modify_range(ov5693->ctrls.exposure,
|
||
|
+ ov5693->ctrls.exposure->minimum, exposure_max,
|
||
|
+ ov5693->ctrls.exposure->step,
|
||
|
+ min(ov5693->ctrls.exposure->val, exposure_max));
|
||
|
+
|
||
|
+ mutex_unlock(&ov5693->lock);
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_get_selection(struct v4l2_subdev *sd,
|
||
|
+ struct v4l2_subdev_pad_config *cfg,
|
||
|
+ struct v4l2_subdev_selection *sel)
|
||
|
+{
|
||
|
+ struct ov5693_device *ov5693 = to_ov5693_sensor(sd);
|
||
|
+
|
||
|
+ switch (sel->target) {
|
||
|
+ case V4L2_SEL_TGT_CROP:
|
||
|
+ mutex_lock(&ov5693->lock);
|
||
|
+ sel->r = *__ov5693_get_pad_crop(ov5693, cfg, sel->pad,
|
||
|
+ sel->which);
|
||
|
+ mutex_unlock(&ov5693->lock);
|
||
|
+ break;
|
||
|
+ case V4L2_SEL_TGT_NATIVE_SIZE:
|
||
|
+ sel->r.top = 0;
|
||
|
+ sel->r.left = 0;
|
||
|
+ sel->r.width = OV5693_NATIVE_WIDTH;
|
||
|
+ sel->r.height = OV5693_NATIVE_HEIGHT;
|
||
|
+ break;
|
||
|
+ case V4L2_SEL_TGT_CROP_BOUNDS:
|
||
|
+ case V4L2_SEL_TGT_CROP_DEFAULT:
|
||
|
+ sel->r.top = OV5693_ACTIVE_START_TOP;
|
||
|
+ sel->r.left = OV5693_ACTIVE_START_LEFT;
|
||
|
+ sel->r.width = OV5693_ACTIVE_WIDTH;
|
||
|
+ sel->r.height = OV5693_ACTIVE_HEIGHT;
|
||
|
+ break;
|
||
|
+ default:
|
||
|
+ return -EINVAL;
|
||
|
+ }
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_set_selection(struct v4l2_subdev *sd,
|
||
|
+ struct v4l2_subdev_pad_config *cfg,
|
||
|
+ struct v4l2_subdev_selection *sel)
|
||
|
+{
|
||
|
+ struct ov5693_device *ov5693 = to_ov5693_sensor(sd);
|
||
|
+ struct v4l2_mbus_framefmt *format;
|
||
|
+ struct v4l2_rect *__crop;
|
||
|
+ struct v4l2_rect rect;
|
||
|
+
|
||
|
+ if (sel->target != V4L2_SEL_TGT_CROP)
|
||
|
+ return -EINVAL;
|
||
|
+
|
||
|
+ /*
|
||
|
+ * Clamp the boundaries of the crop rectangle to the size of the sensor
|
||
|
+ * pixel array. Align to multiples of 2 to ensure Bayer pattern isn't
|
||
|
+ * disrupted.
|
||
|
+ */
|
||
|
+ rect.left = clamp(ALIGN(sel->r.left, 2), OV5693_NATIVE_START_LEFT,
|
||
|
+ OV5693_NATIVE_WIDTH);
|
||
|
+ rect.top = clamp(ALIGN(sel->r.top, 2), OV5693_NATIVE_START_TOP,
|
||
|
+ OV5693_NATIVE_HEIGHT);
|
||
|
+ rect.width = clamp_t(unsigned int, ALIGN(sel->r.width, 2),
|
||
|
+ OV5693_MIN_CROP_WIDTH, OV5693_NATIVE_WIDTH);
|
||
|
+ rect.height = clamp_t(unsigned int, ALIGN(sel->r.height, 2),
|
||
|
+ OV5693_MIN_CROP_HEIGHT, OV5693_NATIVE_HEIGHT);
|
||
|
+
|
||
|
+ /* Make sure the crop rectangle isn't outside the bounds of the array */
|
||
|
+ rect.width = min_t(unsigned int, rect.width,
|
||
|
+ OV5693_NATIVE_WIDTH - rect.left);
|
||
|
+ rect.height = min_t(unsigned int, rect.height,
|
||
|
+ OV5693_NATIVE_HEIGHT - rect.top);
|
||
|
+
|
||
|
+ __crop = __ov5693_get_pad_crop(ov5693, cfg, sel->pad, sel->which);
|
||
|
+
|
||
|
+ if (rect.width != __crop->width || rect.height != __crop->height) {
|
||
|
+ /*
|
||
|
+ * Reset the output image size if the crop rectangle size has
|
||
|
+ * been modified.
|
||
|
+ */
|
||
|
+ format = __ov5693_get_pad_format(ov5693, cfg, sel->pad, sel->which);
|
||
|
+ format->width = rect.width;
|
||
|
+ format->height = rect.height;
|
||
|
+ }
|
||
|
+
|
||
|
+ *__crop = rect;
|
||
|
+ sel->r = rect;
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_s_stream(struct v4l2_subdev *sd, int enable)
|
||
|
+{
|
||
|
+ struct ov5693_device *ov5693 = to_ov5693_sensor(sd);
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ if (enable) {
|
||
|
+ ret = pm_runtime_get_sync(ov5693->dev);
|
||
|
+ if (ret < 0)
|
||
|
+ goto err_power_down;
|
||
|
+
|
||
|
+ ret = __v4l2_ctrl_handler_setup(&ov5693->ctrls.handler);
|
||
|
+ if (ret)
|
||
|
+ goto err_power_down;
|
||
|
+ }
|
||
|
+
|
||
|
+ mutex_lock(&ov5693->lock);
|
||
|
+ ret = ov5693_sw_standby(ov5693, !enable);
|
||
|
+ mutex_unlock(&ov5693->lock);
|
||
|
+
|
||
|
+ if (ret)
|
||
|
+ goto err_power_down;
|
||
|
+ ov5693->streaming = !!enable;
|
||
|
+
|
||
|
+ if (!enable)
|
||
|
+ pm_runtime_put(ov5693->dev);
|
||
|
+
|
||
|
+ return 0;
|
||
|
+err_power_down:
|
||
|
+ pm_runtime_put_noidle(ov5693->dev);
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_g_frame_interval(struct v4l2_subdev *sd,
|
||
|
+ struct v4l2_subdev_frame_interval *interval)
|
||
|
+{
|
||
|
+ struct ov5693_device *ov5693 = to_ov5693_sensor(sd);
|
||
|
+ unsigned int framesize = OV5693_FIXED_PPL * (ov5693->mode.format.height +
|
||
|
+ ov5693->ctrls.vblank->val);
|
||
|
+ unsigned int fps = DIV_ROUND_CLOSEST(OV5693_PIXEL_RATE, framesize);
|
||
|
+
|
||
|
+ interval->interval.numerator = 1;
|
||
|
+ interval->interval.denominator = fps;
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_enum_mbus_code(struct v4l2_subdev *sd,
|
||
|
+ struct v4l2_subdev_pad_config *cfg,
|
||
|
+ struct v4l2_subdev_mbus_code_enum *code)
|
||
|
+{
|
||
|
+ /* Only a single mbus format is supported */
|
||
|
+ if (code->index > 0)
|
||
|
+ return -EINVAL;
|
||
|
+
|
||
|
+ code->code = MEDIA_BUS_FMT_SBGGR10_1X10;
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_enum_frame_size(struct v4l2_subdev *sd,
|
||
|
+ struct v4l2_subdev_pad_config *cfg,
|
||
|
+ struct v4l2_subdev_frame_size_enum *fse)
|
||
|
+{
|
||
|
+ struct ov5693_device *ov5693 = to_ov5693_sensor(sd);
|
||
|
+ struct v4l2_rect *__crop;
|
||
|
+
|
||
|
+ if (fse->index > 1 || fse->code != MEDIA_BUS_FMT_SBGGR10_1X10)
|
||
|
+ return -EINVAL;
|
||
|
+
|
||
|
+ __crop = __ov5693_get_pad_crop(ov5693, cfg, fse->pad, fse->which);
|
||
|
+ if (!__crop)
|
||
|
+ return -EINVAL;
|
||
|
+
|
||
|
+ fse->min_width = __crop->width / (fse->index + 1);
|
||
|
+ fse->min_height = __crop->height / (fse->index + 1);
|
||
|
+ fse->max_width = fse->min_width;
|
||
|
+ fse->max_height = fse->min_height;
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static const struct v4l2_subdev_video_ops ov5693_video_ops = {
|
||
|
+ .s_stream = ov5693_s_stream,
|
||
|
+ .g_frame_interval = ov5693_g_frame_interval,
|
||
|
+};
|
||
|
+
|
||
|
+static const struct v4l2_subdev_pad_ops ov5693_pad_ops = {
|
||
|
+ .enum_mbus_code = ov5693_enum_mbus_code,
|
||
|
+ .enum_frame_size = ov5693_enum_frame_size,
|
||
|
+ .get_fmt = ov5693_get_fmt,
|
||
|
+ .set_fmt = ov5693_set_fmt,
|
||
|
+ .get_selection = ov5693_get_selection,
|
||
|
+ .set_selection = ov5693_set_selection,
|
||
|
+};
|
||
|
+
|
||
|
+static const struct v4l2_subdev_ops ov5693_ops = {
|
||
|
+ .video = &ov5693_video_ops,
|
||
|
+ .pad = &ov5693_pad_ops,
|
||
|
+};
|
||
|
+
|
||
|
+/* Sensor and Driver Configuration Functions */
|
||
|
+
|
||
|
+static int ov5693_init_controls(struct ov5693_device *ov5693)
|
||
|
+{
|
||
|
+ const struct v4l2_ctrl_ops *ops = &ov5693_ctrl_ops;
|
||
|
+ struct v4l2_fwnode_device_properties props;
|
||
|
+ int vblank_max, vblank_def;
|
||
|
+ int exposure_max;
|
||
|
+ int hblank;
|
||
|
+ int ret;
|
||
|
+
|
||
|
+ ret = v4l2_ctrl_handler_init(&ov5693->ctrls.handler, 12);
|
||
|
+ if (ret)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ /* link freq */
|
||
|
+ ov5693->ctrls.link_freq = v4l2_ctrl_new_int_menu(&ov5693->ctrls.handler,
|
||
|
+ NULL, V4L2_CID_LINK_FREQ,
|
||
|
+ 0, 0, link_freq_menu_items);
|
||
|
+ if (ov5693->ctrls.link_freq)
|
||
|
+ ov5693->ctrls.link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
|
||
|
+
|
||
|
+ /* pixel rate */
|
||
|
+ ov5693->ctrls.pixel_rate = v4l2_ctrl_new_std(&ov5693->ctrls.handler, NULL,
|
||
|
+ V4L2_CID_PIXEL_RATE, 0,
|
||
|
+ OV5693_PIXEL_RATE, 1,
|
||
|
+ OV5693_PIXEL_RATE);
|
||
|
+
|
||
|
+ /* Exposure */
|
||
|
+ exposure_max = ov5693->mode.vts - OV5693_INTEGRATION_TIME_MARGIN;
|
||
|
+ ov5693->ctrls.exposure = v4l2_ctrl_new_std(&ov5693->ctrls.handler, ops,
|
||
|
+ V4L2_CID_EXPOSURE,
|
||
|
+ OV5693_EXPOSURE_MIN,
|
||
|
+ exposure_max,
|
||
|
+ OV5693_EXPOSURE_STEP,
|
||
|
+ exposure_max);
|
||
|
+
|
||
|
+ /* Gain */
|
||
|
+ ov5693->ctrls.analogue_gain = v4l2_ctrl_new_std(&ov5693->ctrls.handler,
|
||
|
+ ops, V4L2_CID_ANALOGUE_GAIN,
|
||
|
+ OV5693_GAIN_MIN,
|
||
|
+ OV5693_GAIN_MAX,
|
||
|
+ OV5693_GAIN_STEP,
|
||
|
+ OV5693_GAIN_DEF);
|
||
|
+
|
||
|
+ ov5693->ctrls.digital_gain = v4l2_ctrl_new_std(&ov5693->ctrls.handler, ops,
|
||
|
+ V4L2_CID_DIGITAL_GAIN,
|
||
|
+ OV5693_DIGITAL_GAIN_MIN,
|
||
|
+ OV5693_DIGITAL_GAIN_MAX,
|
||
|
+ OV5693_DIGITAL_GAIN_STEP,
|
||
|
+ OV5693_DIGITAL_GAIN_DEF);
|
||
|
+
|
||
|
+ /* Flip */
|
||
|
+ ov5693->ctrls.hflip = v4l2_ctrl_new_std(&ov5693->ctrls.handler, ops,
|
||
|
+ V4L2_CID_HFLIP, 0, 1, 1, 0);
|
||
|
+
|
||
|
+ ov5693->ctrls.vflip = v4l2_ctrl_new_std(&ov5693->ctrls.handler, ops,
|
||
|
+ V4L2_CID_VFLIP, 0, 1, 1, 0);
|
||
|
+
|
||
|
+ hblank = OV5693_FIXED_PPL - ov5693->mode.format.width;
|
||
|
+ ov5693->ctrls.hblank = v4l2_ctrl_new_std(&ov5693->ctrls.handler, ops,
|
||
|
+ V4L2_CID_HBLANK, hblank,
|
||
|
+ hblank, 1, hblank);
|
||
|
+
|
||
|
+ if (ov5693->ctrls.hblank)
|
||
|
+ ov5693->ctrls.hblank->flags |= V4L2_CTRL_FLAG_READ_ONLY;
|
||
|
+
|
||
|
+ vblank_max = OV5693_TIMING_MAX_VTS - ov5693->mode.format.height;
|
||
|
+ vblank_def = ov5693->mode.vts - ov5693->mode.format.height;
|
||
|
+ ov5693->ctrls.vblank = v4l2_ctrl_new_std(&ov5693->ctrls.handler, ops,
|
||
|
+ V4L2_CID_VBLANK,
|
||
|
+ OV5693_TIMING_MIN_VTS,
|
||
|
+ vblank_max, 1, vblank_def);
|
||
|
+
|
||
|
+ ov5693->ctrls.test_pattern = v4l2_ctrl_new_std_menu_items(
|
||
|
+ &ov5693->ctrls.handler, ops,
|
||
|
+ V4L2_CID_TEST_PATTERN,
|
||
|
+ ARRAY_SIZE(ov5693_test_pattern_menu) - 1,
|
||
|
+ 0, 0, ov5693_test_pattern_menu);
|
||
|
+
|
||
|
+ if (ov5693->ctrls.handler.error) {
|
||
|
+ dev_err(ov5693->dev, "Error initialising v4l2 ctrls\n");
|
||
|
+ ret = ov5693->ctrls.handler.error;
|
||
|
+ goto err_free_handler;
|
||
|
+ }
|
||
|
+
|
||
|
+ /* set properties from fwnode (e.g. rotation, orientation) */
|
||
|
+ ret = v4l2_fwnode_device_parse(ov5693->dev, &props);
|
||
|
+ if (ret)
|
||
|
+ goto err_free_handler;
|
||
|
+
|
||
|
+ ret = v4l2_ctrl_new_fwnode_properties(&ov5693->ctrls.handler, ops,
|
||
|
+ &props);
|
||
|
+ if (ret)
|
||
|
+ goto err_free_handler;
|
||
|
+
|
||
|
+ /* Use same lock for controls as for everything else. */
|
||
|
+ ov5693->ctrls.handler.lock = &ov5693->lock;
|
||
|
+ ov5693->sd.ctrl_handler = &ov5693->ctrls.handler;
|
||
|
+
|
||
|
+ return 0;
|
||
|
+
|
||
|
+err_free_handler:
|
||
|
+ v4l2_ctrl_handler_free(&ov5693->ctrls.handler);
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_configure_gpios(struct ov5693_device *ov5693)
|
||
|
+{
|
||
|
+ ov5693->reset = devm_gpiod_get_optional(ov5693->dev, "reset",
|
||
|
+ GPIOD_OUT_HIGH);
|
||
|
+ if (IS_ERR(ov5693->reset)) {
|
||
|
+ dev_err(ov5693->dev, "Error fetching reset GPIO\n");
|
||
|
+ return PTR_ERR(ov5693->reset);
|
||
|
+ }
|
||
|
+
|
||
|
+ ov5693->powerdown = devm_gpiod_get_optional(ov5693->dev, "powerdown",
|
||
|
+ GPIOD_OUT_HIGH);
|
||
|
+ if (IS_ERR(ov5693->powerdown)) {
|
||
|
+ dev_err(ov5693->dev, "Error fetching powerdown GPIO\n");
|
||
|
+ return PTR_ERR(ov5693->powerdown);
|
||
|
+ }
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_get_regulators(struct ov5693_device *ov5693)
|
||
|
+{
|
||
|
+ unsigned int i;
|
||
|
+
|
||
|
+ for (i = 0; i < OV5693_NUM_SUPPLIES; i++)
|
||
|
+ ov5693->supplies[i].supply = ov5693_supply_names[i];
|
||
|
+
|
||
|
+ return devm_regulator_bulk_get(ov5693->dev, OV5693_NUM_SUPPLIES,
|
||
|
+ ov5693->supplies);
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_probe(struct i2c_client *client)
|
||
|
+{
|
||
|
+ struct fwnode_handle *fwnode = dev_fwnode(&client->dev);
|
||
|
+ struct fwnode_handle *endpoint;
|
||
|
+ struct ov5693_device *ov5693;
|
||
|
+ u32 clk_rate;
|
||
|
+ int ret = 0;
|
||
|
+
|
||
|
+ endpoint = fwnode_graph_get_next_endpoint(fwnode, NULL);
|
||
|
+ if (!endpoint && !IS_ERR_OR_NULL(fwnode->secondary))
|
||
|
+ endpoint = fwnode_graph_get_next_endpoint(fwnode->secondary, NULL);
|
||
|
+ if (!endpoint)
|
||
|
+ return -EPROBE_DEFER;
|
||
|
+
|
||
|
+ ov5693 = devm_kzalloc(&client->dev, sizeof(*ov5693), GFP_KERNEL);
|
||
|
+ if (!ov5693)
|
||
|
+ return -ENOMEM;
|
||
|
+
|
||
|
+ ov5693->client = client;
|
||
|
+ ov5693->dev = &client->dev;
|
||
|
+
|
||
|
+ mutex_init(&ov5693->lock);
|
||
|
+
|
||
|
+ v4l2_i2c_subdev_init(&ov5693->sd, client, &ov5693_ops);
|
||
|
+
|
||
|
+ ov5693->clk = devm_clk_get(&client->dev, "xvclk");
|
||
|
+ if (IS_ERR(ov5693->clk)) {
|
||
|
+ dev_err(&client->dev, "Error getting clock\n");
|
||
|
+ return PTR_ERR(ov5693->clk);
|
||
|
+ }
|
||
|
+
|
||
|
+ clk_rate = clk_get_rate(ov5693->clk);
|
||
|
+ if (clk_rate != OV5693_XVCLK_FREQ) {
|
||
|
+ dev_err(&client->dev, "Unsupported clk freq %u, expected %u\n",
|
||
|
+ clk_rate, OV5693_XVCLK_FREQ);
|
||
|
+ return -EINVAL;
|
||
|
+ }
|
||
|
+
|
||
|
+ ret = ov5693_configure_gpios(ov5693);
|
||
|
+ if (ret)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ ret = ov5693_get_regulators(ov5693);
|
||
|
+ if (ret) {
|
||
|
+ dev_err(&client->dev, "Error fetching regulators\n");
|
||
|
+ return ret;
|
||
|
+ }
|
||
|
+
|
||
|
+ ov5693->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
|
||
|
+ ov5693->pad.flags = MEDIA_PAD_FL_SOURCE;
|
||
|
+ ov5693->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
|
||
|
+
|
||
|
+ ov5693->mode.crop = ov5693_default_crop;
|
||
|
+ ov5693->mode.format = ov5693_default_fmt;
|
||
|
+ ov5693->mode.vts = __ov5693_calc_vts(ov5693->mode.format.height);
|
||
|
+
|
||
|
+ ret = ov5693_init_controls(ov5693);
|
||
|
+ if (ret)
|
||
|
+ return ret;
|
||
|
+
|
||
|
+ ret = media_entity_pads_init(&ov5693->sd.entity, 1, &ov5693->pad);
|
||
|
+ if (ret)
|
||
|
+ goto err_ctrl_handler_free;
|
||
|
+
|
||
|
+ /*
|
||
|
+ * We need the driver to work in the event that pm runtime is disable in
|
||
|
+ * the kernel, so power up and verify the chip now. In the event that
|
||
|
+ * runtime pm is disabled this will leave the chip on, so that streaming
|
||
|
+ * will work.
|
||
|
+ */
|
||
|
+
|
||
|
+ ret = ov5693_sensor_powerup(ov5693);
|
||
|
+ if (ret)
|
||
|
+ goto err_media_entity_cleanup;
|
||
|
+
|
||
|
+ ret = ov5693_detect(ov5693);
|
||
|
+ if (ret)
|
||
|
+ goto err_powerdown;
|
||
|
+
|
||
|
+ pm_runtime_set_active(&client->dev);
|
||
|
+ pm_runtime_get_noresume(&client->dev);
|
||
|
+ pm_runtime_enable(&client->dev);
|
||
|
+
|
||
|
+ ret = v4l2_async_register_subdev_sensor_common(&ov5693->sd);
|
||
|
+ if (ret) {
|
||
|
+ dev_err(&client->dev, "failed to register V4L2 subdev: %d",
|
||
|
+ ret);
|
||
|
+ goto err_pm_runtime;
|
||
|
+ }
|
||
|
+
|
||
|
+ pm_runtime_set_autosuspend_delay(&client->dev, 1000);
|
||
|
+ pm_runtime_use_autosuspend(&client->dev);
|
||
|
+ pm_runtime_put_autosuspend(&client->dev);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+
|
||
|
+err_pm_runtime:
|
||
|
+ pm_runtime_disable(&client->dev);
|
||
|
+ pm_runtime_put_noidle(&client->dev);
|
||
|
+err_powerdown:
|
||
|
+ ov5693_sensor_powerdown(ov5693);
|
||
|
+err_media_entity_cleanup:
|
||
|
+ media_entity_cleanup(&ov5693->sd.entity);
|
||
|
+err_ctrl_handler_free:
|
||
|
+ v4l2_ctrl_handler_free(&ov5693->ctrls.handler);
|
||
|
+
|
||
|
+ return ret;
|
||
|
+}
|
||
|
+
|
||
|
+static int ov5693_remove(struct i2c_client *client)
|
||
|
+{
|
||
|
+ struct v4l2_subdev *sd = i2c_get_clientdata(client);
|
||
|
+ struct ov5693_device *ov5693 = to_ov5693_sensor(sd);
|
||
|
+
|
||
|
+ v4l2_async_unregister_subdev(sd);
|
||
|
+ media_entity_cleanup(&ov5693->sd.entity);
|
||
|
+ v4l2_ctrl_handler_free(&ov5693->ctrls.handler);
|
||
|
+ mutex_destroy(&ov5693->lock);
|
||
|
+
|
||
|
+ /*
|
||
|
+ * Disable runtime PM. In case runtime PM is disabled in the kernel,
|
||
|
+ * make sure to turn power off manually.
|
||
|
+ */
|
||
|
+ pm_runtime_disable(&client->dev);
|
||
|
+ if (!pm_runtime_status_suspended(&client->dev))
|
||
|
+ ov5693_sensor_powerdown(ov5693);
|
||
|
+ pm_runtime_set_suspended(&client->dev);
|
||
|
+
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static const struct dev_pm_ops ov5693_pm_ops = {
|
||
|
+ SET_RUNTIME_PM_OPS(ov5693_sensor_suspend, ov5693_sensor_resume, NULL)
|
||
|
+};
|
||
|
+
|
||
|
+static const struct acpi_device_id ov5693_acpi_match[] = {
|
||
|
+ {"INT33BE"},
|
||
|
+ {},
|
||
|
+};
|
||
|
+MODULE_DEVICE_TABLE(acpi, ov5693_acpi_match);
|
||
|
+
|
||
|
+static struct i2c_driver ov5693_driver = {
|
||
|
+ .driver = {
|
||
|
+ .name = "ov5693",
|
||
|
+ .acpi_match_table = ov5693_acpi_match,
|
||
|
+ .pm = &ov5693_pm_ops,
|
||
|
+ },
|
||
|
+ .probe_new = ov5693_probe,
|
||
|
+ .remove = ov5693_remove,
|
||
|
+};
|
||
|
+module_i2c_driver(ov5693_driver);
|
||
|
+
|
||
|
+MODULE_DESCRIPTION("A low-level driver for OmniVision 5693 sensors");
|
||
|
+MODULE_LICENSE("GPL");
|
||
|
--
|
||
|
2.31.1
|
||
|
|
||
|
From 50a9c72845f5a7f0ce6411b59a49a724b04cb92d Mon Sep 17 00:00:00 2001
|
||
|
From: =?UTF-8?q?Fabian=20W=C3=BCthrich?= <me@fabwu.ch>
|
||
|
Date: Fri, 22 Jan 2021 20:58:13 +0100
|
||
|
Subject: [PATCH] cio2-bridge: Parse sensor orientation and rotation
|
||
|
MIME-Version: 1.0
|
||
|
Content-Type: text/plain; charset=UTF-8
|
||
|
Content-Transfer-Encoding: 8bit
|
||
|
|
||
|
The sensor orientation is read from the _PLC ACPI buffer and converted
|
||
|
to a v4l2 format.
|
||
|
|
||
|
See https://uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf
|
||
|
page 351 for a definition of the Panel property.
|
||
|
|
||
|
The sensor rotation is read from the SSDB ACPI buffer and converted into
|
||
|
degrees.
|
||
|
|
||
|
Signed-off-by: Fabian Wüthrich <me@fabwu.ch>
|
||
|
Patchset: cameras
|
||
|
---
|
||
|
drivers/media/pci/intel/ipu3/cio2-bridge.c | 45 ++++++++++++++++++++--
|
||
|
drivers/media/pci/intel/ipu3/cio2-bridge.h | 3 ++
|
||
|
2 files changed, 44 insertions(+), 4 deletions(-)
|
||
|
|
||
|
diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c b/drivers/media/pci/intel/ipu3/cio2-bridge.c
|
||
|
index c2199042d3db..9a8a4a55d6a7 100644
|
||
|
--- a/drivers/media/pci/intel/ipu3/cio2-bridge.c
|
||
|
+++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c
|
||
|
@@ -29,6 +29,7 @@ static const struct cio2_sensor_config cio2_supported_sensors[] = {
|
||
|
static const struct cio2_property_names prop_names = {
|
||
|
.clock_frequency = "clock-frequency",
|
||
|
.rotation = "rotation",
|
||
|
+ .orientation = "orientation",
|
||
|
.bus_type = "bus-type",
|
||
|
.data_lanes = "data-lanes",
|
||
|
.remote_endpoint = "remote-endpoint",
|
||
|
@@ -72,11 +73,36 @@ static int cio2_bridge_read_acpi_buffer(struct acpi_device *adev, char *id,
|
||
|
return ret;
|
||
|
}
|
||
|
|
||
|
+static u32 cio2_bridge_parse_rotation(u8 rotation)
|
||
|
+{
|
||
|
+ if (rotation == 1)
|
||
|
+ return 180;
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+static enum v4l2_fwnode_orientation cio2_bridge_parse_orientation(u8 panel)
|
||
|
+{
|
||
|
+ switch (panel) {
|
||
|
+ case 4:
|
||
|
+ return V4L2_FWNODE_ORIENTATION_FRONT;
|
||
|
+ case 5:
|
||
|
+ return V4L2_FWNODE_ORIENTATION_BACK;
|
||
|
+ default:
|
||
|
+ return V4L2_FWNODE_ORIENTATION_EXTERNAL;
|
||
|
+ }
|
||
|
+}
|
||
|
+
|
||
|
static void cio2_bridge_create_fwnode_properties(
|
||
|
struct cio2_sensor *sensor,
|
||
|
struct cio2_bridge *bridge,
|
||
|
const struct cio2_sensor_config *cfg)
|
||
|
{
|
||
|
+ u32 rotation;
|
||
|
+ enum v4l2_fwnode_orientation orientation;
|
||
|
+
|
||
|
+ rotation = cio2_bridge_parse_rotation(sensor->ssdb.degree);
|
||
|
+ orientation = cio2_bridge_parse_orientation(sensor->pld->panel);
|
||
|
+
|
||
|
sensor->prop_names = prop_names;
|
||
|
|
||
|
sensor->local_ref[0].node = &sensor->swnodes[SWNODE_CIO2_ENDPOINT];
|
||
|
@@ -85,9 +111,12 @@ static void cio2_bridge_create_fwnode_properties(
|
||
|
sensor->dev_properties[0] = PROPERTY_ENTRY_U32(
|
||
|
sensor->prop_names.clock_frequency,
|
||
|
sensor->ssdb.mclkspeed);
|
||
|
- sensor->dev_properties[1] = PROPERTY_ENTRY_U8(
|
||
|
+ sensor->dev_properties[1] = PROPERTY_ENTRY_U32(
|
||
|
sensor->prop_names.rotation,
|
||
|
- sensor->ssdb.degree);
|
||
|
+ rotation);
|
||
|
+ sensor->dev_properties[2] = PROPERTY_ENTRY_U32(
|
||
|
+ sensor->prop_names.orientation,
|
||
|
+ orientation);
|
||
|
|
||
|
sensor->ep_properties[0] = PROPERTY_ENTRY_U32(
|
||
|
sensor->prop_names.bus_type,
|
||
|
@@ -159,6 +188,7 @@ static void cio2_bridge_unregister_sensors(struct cio2_bridge *bridge)
|
||
|
for (i = 0; i < bridge->n_sensors; i++) {
|
||
|
sensor = &bridge->sensors[i];
|
||
|
software_node_unregister_nodes(sensor->swnodes);
|
||
|
+ ACPI_FREE(sensor->pld);
|
||
|
acpi_dev_put(sensor->adev);
|
||
|
}
|
||
|
}
|
||
|
@@ -170,6 +200,7 @@ static int cio2_bridge_connect_sensor(const struct cio2_sensor_config *cfg,
|
||
|
struct fwnode_handle *fwnode;
|
||
|
struct cio2_sensor *sensor;
|
||
|
struct acpi_device *adev;
|
||
|
+ acpi_status status;
|
||
|
int ret;
|
||
|
|
||
|
for_each_acpi_dev_match(adev, cfg->hid, NULL, -1) {
|
||
|
@@ -193,11 +224,15 @@ static int cio2_bridge_connect_sensor(const struct cio2_sensor_config *cfg,
|
||
|
if (ret)
|
||
|
goto err_put_adev;
|
||
|
|
||
|
+ status = acpi_get_physical_device_location(adev->handle, &sensor->pld);
|
||
|
+ if (ACPI_FAILURE(status))
|
||
|
+ goto err_put_adev;
|
||
|
+
|
||
|
if (sensor->ssdb.lanes > CIO2_MAX_LANES) {
|
||
|
dev_err(&adev->dev,
|
||
|
"Number of lanes in SSDB is invalid\n");
|
||
|
ret = -EINVAL;
|
||
|
- goto err_put_adev;
|
||
|
+ goto err_free_pld;
|
||
|
}
|
||
|
|
||
|
cio2_bridge_create_fwnode_properties(sensor, bridge, cfg);
|
||
|
@@ -205,7 +240,7 @@ static int cio2_bridge_connect_sensor(const struct cio2_sensor_config *cfg,
|
||
|
|
||
|
ret = software_node_register_nodes(sensor->swnodes);
|
||
|
if (ret)
|
||
|
- goto err_put_adev;
|
||
|
+ goto err_free_pld;
|
||
|
|
||
|
fwnode = software_node_fwnode(&sensor->swnodes[
|
||
|
SWNODE_SENSOR_HID]);
|
||
|
@@ -226,6 +261,8 @@ static int cio2_bridge_connect_sensor(const struct cio2_sensor_config *cfg,
|
||
|
|
||
|
err_free_swnodes:
|
||
|
software_node_unregister_nodes(sensor->swnodes);
|
||
|
+err_free_pld:
|
||
|
+ ACPI_FREE(sensor->pld);
|
||
|
err_put_adev:
|
||
|
acpi_dev_put(sensor->adev);
|
||
|
err_out:
|
||
|
diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.h b/drivers/media/pci/intel/ipu3/cio2-bridge.h
|
||
|
index dd0ffcafa489..924d99d20328 100644
|
||
|
--- a/drivers/media/pci/intel/ipu3/cio2-bridge.h
|
||
|
+++ b/drivers/media/pci/intel/ipu3/cio2-bridge.h
|
||
|
@@ -80,6 +80,7 @@ struct cio2_sensor_ssdb {
|
||
|
struct cio2_property_names {
|
||
|
char clock_frequency[16];
|
||
|
char rotation[9];
|
||
|
+ char orientation[12];
|
||
|
char bus_type[9];
|
||
|
char data_lanes[11];
|
||
|
char remote_endpoint[16];
|
||
|
@@ -106,6 +107,8 @@ struct cio2_sensor {
|
||
|
struct cio2_node_names node_names;
|
||
|
|
||
|
struct cio2_sensor_ssdb ssdb;
|
||
|
+ struct acpi_pld_info *pld;
|
||
|
+
|
||
|
struct cio2_property_names prop_names;
|
||
|
struct property_entry ep_properties[5];
|
||
|
struct property_entry dev_properties[3];
|
||
|
--
|
||
|
2.31.1
|
||
|
|
||
|
From b8227ed525b8a609ae311c7c7d310498c29e94fd Mon Sep 17 00:00:00 2001
|
||
|
From: =?UTF-8?q?Fabian=20W=C3=BCthrich?= <me@fabwu.ch>
|
||
|
Date: Sun, 24 Jan 2021 11:07:42 +0100
|
||
|
Subject: [PATCH] cio2-bridge: Use macros and add warnings
|
||
|
MIME-Version: 1.0
|
||
|
Content-Type: text/plain; charset=UTF-8
|
||
|
Content-Transfer-Encoding: 8bit
|
||
|
|
||
|
Use macros for the _PLD panel as defined in the ACPI spec 6.3 and emit
|
||
|
a warning if we see an unknown value.
|
||
|
|
||
|
Signed-off-by: Fabian Wüthrich <me@fabwu.ch>
|
||
|
Patchset: cameras
|
||
|
---
|
||
|
drivers/media/pci/intel/ipu3/cio2-bridge.c | 33 ++++++++++++++++------
|
||
|
drivers/media/pci/intel/ipu3/cio2-bridge.h | 13 +++++++++
|
||
|
2 files changed, 37 insertions(+), 9 deletions(-)
|
||
|
|
||
|
diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c b/drivers/media/pci/intel/ipu3/cio2-bridge.c
|
||
|
index 9a8a4a55d6a7..503809907b92 100644
|
||
|
--- a/drivers/media/pci/intel/ipu3/cio2-bridge.c
|
||
|
+++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c
|
||
|
@@ -73,21 +73,36 @@ static int cio2_bridge_read_acpi_buffer(struct acpi_device *adev, char *id,
|
||
|
return ret;
|
||
|
}
|
||
|
|
||
|
-static u32 cio2_bridge_parse_rotation(u8 rotation)
|
||
|
+static u32 cio2_bridge_parse_rotation(struct cio2_sensor *sensor)
|
||
|
{
|
||
|
- if (rotation == 1)
|
||
|
+ switch (sensor->ssdb.degree) {
|
||
|
+ case CIO2_SENSOR_ROTATION_NORMAL:
|
||
|
+ return 0;
|
||
|
+ case CIO2_SENSOR_ROTATION_INVERTED:
|
||
|
return 180;
|
||
|
- return 0;
|
||
|
+ default:
|
||
|
+ dev_warn(&sensor->adev->dev,
|
||
|
+ "Unknown rotation %d. Assume 0 degree rotation\n",
|
||
|
+ sensor->ssdb.degree);
|
||
|
+ return 0;
|
||
|
+ }
|
||
|
}
|
||
|
|
||
|
-static enum v4l2_fwnode_orientation cio2_bridge_parse_orientation(u8 panel)
|
||
|
+static enum v4l2_fwnode_orientation cio2_bridge_parse_orientation(struct cio2_sensor *sensor)
|
||
|
{
|
||
|
- switch (panel) {
|
||
|
- case 4:
|
||
|
+ switch (sensor->pld->panel) {
|
||
|
+ case CIO2_PLD_PANEL_FRONT:
|
||
|
return V4L2_FWNODE_ORIENTATION_FRONT;
|
||
|
- case 5:
|
||
|
+ case CIO2_PLD_PANEL_BACK:
|
||
|
return V4L2_FWNODE_ORIENTATION_BACK;
|
||
|
+ case CIO2_PLD_PANEL_TOP:
|
||
|
+ case CIO2_PLD_PANEL_LEFT:
|
||
|
+ case CIO2_PLD_PANEL_RIGHT:
|
||
|
+ case CIO2_PLD_PANEL_UNKNOWN:
|
||
|
+ return V4L2_FWNODE_ORIENTATION_EXTERNAL;
|
||
|
default:
|
||
|
+ dev_warn(&sensor->adev->dev, "Unknown _PLD panel value %d\n",
|
||
|
+ sensor->pld->panel);
|
||
|
return V4L2_FWNODE_ORIENTATION_EXTERNAL;
|
||
|
}
|
||
|
}
|
||
|
@@ -100,8 +115,8 @@ static void cio2_bridge_create_fwnode_properties(
|
||
|
u32 rotation;
|
||
|
enum v4l2_fwnode_orientation orientation;
|
||
|
|
||
|
- rotation = cio2_bridge_parse_rotation(sensor->ssdb.degree);
|
||
|
- orientation = cio2_bridge_parse_orientation(sensor->pld->panel);
|
||
|
+ rotation = cio2_bridge_parse_rotation(sensor);
|
||
|
+ orientation = cio2_bridge_parse_orientation(sensor);
|
||
|
|
||
|
sensor->prop_names = prop_names;
|
||
|
|
||
|
diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.h b/drivers/media/pci/intel/ipu3/cio2-bridge.h
|
||
|
index 924d99d20328..e1e388cc9f45 100644
|
||
|
--- a/drivers/media/pci/intel/ipu3/cio2-bridge.h
|
||
|
+++ b/drivers/media/pci/intel/ipu3/cio2-bridge.h
|
||
|
@@ -12,6 +12,19 @@
|
||
|
#define CIO2_MAX_LANES 4
|
||
|
#define MAX_NUM_LINK_FREQS 3
|
||
|
|
||
|
+/* Values are estimated guesses as we don't have a spec */
|
||
|
+#define CIO2_SENSOR_ROTATION_NORMAL 0
|
||
|
+#define CIO2_SENSOR_ROTATION_INVERTED 1
|
||
|
+
|
||
|
+/* Panel position defined in _PLD section of ACPI Specification 6.3 */
|
||
|
+#define CIO2_PLD_PANEL_TOP 0
|
||
|
+#define CIO2_PLD_PANEL_BOTTOM 1
|
||
|
+#define CIO2_PLD_PANEL_LEFT 2
|
||
|
+#define CIO2_PLD_PANEL_RIGHT 3
|
||
|
+#define CIO2_PLD_PANEL_FRONT 4
|
||
|
+#define CIO2_PLD_PANEL_BACK 5
|
||
|
+#define CIO2_PLD_PANEL_UNKNOWN 6
|
||
|
+
|
||
|
#define CIO2_SENSOR_CONFIG(_HID, _NR, ...) \
|
||
|
(const struct cio2_sensor_config) { \
|
||
|
.hid = _HID, \
|
||
|
--
|
||
|
2.31.1
|
||
|
|