41 lines
1.5 KiB
Diff
41 lines
1.5 KiB
Diff
|
From ec67d8f1941054e7c9933c2525afa2af2d8289ec Mon Sep 17 00:00:00 2001
|
||
|
From: Maximilian Luz <luzmaximilian@gmail.com>
|
||
|
Date: Sun, 17 Jul 2022 13:59:01 +0200
|
||
|
Subject: [PATCH] platform/surface: tabletsw: Fix __le32 integer access
|
||
|
|
||
|
The sources.count field is a __le32 inside a packed struct. So use the
|
||
|
proper functions to access it.
|
||
|
|
||
|
Reported-by: kernel test robot <lkp@intel.com>
|
||
|
Fixes: 9f794056db5b ("platform/surface: Add KIP/POS tablet-mode switch driver")
|
||
|
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
|
||
|
---
|
||
|
drivers/platform/surface/surface_aggregator_tabletsw.c | 4 ++--
|
||
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
||
|
|
||
|
diff --git a/drivers/platform/surface/surface_aggregator_tabletsw.c b/drivers/platform/surface/surface_aggregator_tabletsw.c
|
||
|
index 596ca6c80681..27d95a6a7851 100644
|
||
|
--- a/drivers/platform/surface/surface_aggregator_tabletsw.c
|
||
|
+++ b/drivers/platform/surface/surface_aggregator_tabletsw.c
|
||
|
@@ -410,7 +410,7 @@ static int ssam_pos_get_source(struct ssam_tablet_sw *sw, u32 *source_id)
|
||
|
if (status)
|
||
|
return status;
|
||
|
|
||
|
- if (sources.count == 0) {
|
||
|
+ if (get_unaligned_le32(&sources.count) == 0) {
|
||
|
dev_err(&sw->sdev->dev, "no posture sources found\n");
|
||
|
return -ENODEV;
|
||
|
}
|
||
|
@@ -422,7 +422,7 @@ static int ssam_pos_get_source(struct ssam_tablet_sw *sw, u32 *source_id)
|
||
|
* is a device that provides multiple sources, at which point we can
|
||
|
* then try to figure out how to handle them.
|
||
|
*/
|
||
|
- WARN_ON(sources.count > 1);
|
||
|
+ WARN_ON(get_unaligned_le32(&sources.count) > 1);
|
||
|
|
||
|
*source_id = get_unaligned_le32(&sources.id[0]);
|
||
|
return 0;
|
||
|
--
|
||
|
2.37.0
|
||
|
|