beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Kernel: Remove superfluous alignas(T) from KResultOr<T>

Browse source 
Since `m_storage` is already guaranteed to be correctly aligned for the
type, we can forgo specifying it for the entire class.

This fixes an error: previously, this would *force* the value type's
alignment on the entire class, which would try to make 1-byte aligned
ints with `KResultOr<bool>`. GCC somehow compiled this (probably just
ignored it), but this caused a build error with Clang.

Closes #8072
This commit is contained in:
Daniel Bertalan 2021-06-24 10:43:59 +02:00 committed by Ali Mohammad Pur
parent 2d2747cb15
commit ffb118265b
Notes: sideshowbarker 2024-07-18 11:34:23 +09:00 
Author: https://github.com/BertalanD
Commit: https://github.com/SerenityOS/serenity/commit/ffb118265b3
Pull-request: https://github.com/SerenityOS/serenity/pull/8150
Reviewed-by: https://github.com/Hendiadyoin1
Reviewed-by: https://github.com/alimpfard ✅
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Kernel/KResult.h
View file

@ -43,7 +43,7 @@ private:
};
template<typename T>
class alignas(T) [[nodiscard]] KResultOr {
class [[nodiscard]] KResultOr {
public:
KResultOr(KResult error)
: m_error(error)