beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Kernel: Release the paging lock while reading from the disk

Browse source 
Because reading from the disk may preempt, we need to release the
paging lock.
This commit is contained in:
Tom 2021-02-06 12:11:10 -07:00 committed by Andreas Kling
parent 1110c659ee
commit fe679de791
Notes: sideshowbarker 2024-07-18 17:25:35 +09:00 
Author: https://github.com/tomuta
Commit: https://github.com/SerenityOS/serenity/commit/fe679de791a
Pull-request: https://github.com/SerenityOS/serenity/pull/7459
Issue: https://github.com/SerenityOS/serenity/issues/7359
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
Kernel/VM/Region.cpp
View file

@ -539,8 +539,14 @@ PageFaultResponse Region::handle_inode_fault(size_t page_index_in_region, Scoped
// Reading the page may block, so release the MM lock temporarily
mm_lock.unlock();
auto buffer = UserOrKernelBuffer::for_kernel_buffer(page_buffer);
auto result = inode.read_bytes(page_index_in_vmobject * PAGE_SIZE, PAGE_SIZE, buffer, nullptr);
KResultOr<ssize_t> result(KSuccess);
{
ScopedLockRelease release_paging_lock(vmobject().m_paging_lock);
auto buffer = UserOrKernelBuffer::for_kernel_buffer(page_buffer);
result = inode.read_bytes(page_index_in_vmobject * PAGE_SIZE, PAGE_SIZE, buffer, nullptr);
}
mm_lock.lock();
if (result.is_error()) {