beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 08:11:13 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Remove unreachable abspos width calculation in BFC

Browse source 
compute_width() could never be invoked for abspos boxes because they
are skipped during normal layout and processed in
parent_context_did_dimension_child_root_box()
This commit is contained in:
Aliaksandr Kalenik 2024-09-15 15:46:48 +02:00 committed by Alexander Kalenik
parent 17f4ed6ea1
commit ea04500bb2
Notes: github-actions[bot] 2024-09-15 14:58:14 +00:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/LadybirdBrowser/ladybird/commit/ea04500bb26
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1406
Reviewed-by: https://github.com/awesomekling ✅
1 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp
View file

@ -135,11 +135,6 @@ bool BlockFormattingContext::box_should_avoid_floats_because_it_establishes_fc(B
void BlockFormattingContext::compute_width(Box const& box, AvailableSpace const& available_space)
{
if (box.is_absolutely_positioned()) {
compute_width_for_absolutely_positioned_element(box, available_space);
return;
}
auto remaining_available_space = available_space;
if (available_space.width.is_definite() && box_should_avoid_floats_because_it_establishes_fc(box)) {
// NOTE: Although CSS 2.2 specification says that only block formatting contexts should avoid floats,