beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 08:11:13 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Don't advertise the empty string as HTMLCollection property name

Browse source 
This fixes wpt/dom/collections/HTMLCollection-empty-name.html
This commit is contained in:
Andreas Kling 2024-05-27 10:47:19 +02:00
parent 8988dce93d
commit e7febd347b
Notes: sideshowbarker 2024-07-17 04:09:56 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/e7febd347b
Pull-request: https://github.com/SerenityOS/serenity/pull/24461
3 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibWeb/Text/expected/DOM/HTMLCollection-empty-string-as-property-name.txt Normal file
View file

@ -0,0 +1,2 @@
Empty string in collection: false
'haxx' in collection: true

10
Tests/LibWeb/Text/input/DOM/HTMLCollection-empty-string-as-property-name.html Normal file
View file

@ -0,0 +1,10 @@
<script src="../include.js"></script>
<div id></div>
<div id=haxx></div>
<script>
test(() => {
var c = document.getElementsByTagName("*");
println("Empty string in collection: " + ("" in c));
println("'haxx' in collection: " + ("haxx" in c));
});
</script>

2
Userland/Libraries/LibWeb/DOM/HTMLCollection.cpp
View file

@ -135,7 +135,7 @@ Vector<FlyString> HTMLCollection::supported_property_names() const
for (auto const& element : m_cached_elements) {
// 1. If element has an ID which is not in result, append element’s ID to result.
if (auto const& id = element->id(); id.has_value()) {
if (!result.contains_slow(id.value()))
if (!id.value().is_empty() && !result.contains_slow(id.value()))
result.append(id.value());
}