beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Resolve used insets for grid items

Browse source
This commit is contained in:
Andreas Kling 2023-07-03 20:35:39 +02:00
parent 03ec17fd37
commit e7e454f1d6
Notes: sideshowbarker 2024-07-17 04:09:56 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/e7e454f1d6
Pull-request: https://github.com/SerenityOS/serenity/pull/19774
3 changed files with 34 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
Tests/LibWeb/Layout/expected/grid/relpos-grid-item.txt Normal file
View file

@ -0,0 +1,13 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (2,2) content-size 796x62.9375 [BFC] children: not-inline
Box <body> at (12,12) content-size 600x42.9375 [GFC] children: not-inline
BlockContainer <div.exekiller> at (14,14) content-size 200x17.46875 positioned [BFC] children: inline
line 0 width: 65.4375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 9, rect: [14,14 65.4375x17.46875]
"exekiller"
TextNode <#text>
BlockContainer <div.athena> at (24,25.46875) content-size 200x17.46875 positioned [BFC] children: inline
line 0 width: 53.171875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 6, rect: [24,25.46875 53.171875x17.46875]
"athena"
TextNode <#text>

19
Tests/LibWeb/Layout/input/grid/relpos-grid-item.html Normal file
View file

@ -0,0 +1,19 @@
<!DOCTYPE html><style>
* { border: 2px solid black; }
body {
width: 600px;
display: grid;
}
div {
width: 200px;
position: relative;
}
.athena {
background: green;
top: -10px;
left: 10px;
}
.exekiller {
background: red;
}
</style><body><div class="exekiller">exekiller</div><div class="athena">athena</div></body>

2
Userland/Libraries/LibWeb/Layout/GridFormattingContext.cpp
View file

@ -1609,6 +1609,8 @@ void GridFormattingContext::run(Box const& box, LayoutMode, AvailableSpace const
y_start + child_box_state.border_top + child_box_state.padding_top + child_box_state.margin_top
};
compute_inset(child_box);
auto available_space_for_children = AvailableSpace(AvailableSize::make_definite(child_box_state.content_width()), AvailableSize::make_definite(child_box_state.content_height()));
if (auto independent_formatting_context = layout_inside(child_box, LayoutMode::Normal, available_space_for_children))
independent_formatting_context->parent_context_did_dimension_child_root_box();