mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-09-30 00:31:14 +00:00
LibJS: Rearrange ASTNode members so there's a padding hole at the end
ASTNode inherits from RefCounted, which has a single 32-bit member. This means that there's a 32-bit padding hole after RefCounted, where we are free to put something (or it will go to waste!) This patch moves ASTNode::m_start_offset into that padding hole, and we now have a 32-bit padding hole at the end of ASTNode instead. This will allow ASTNode subclasses to put things in the ASTNode hole by moving them to the head of the member list.
This commit is contained in:
parent
e647ad2ce3
commit
e70f944e11
Notes:
sideshowbarker
2024-07-17 04:09:56 +09:00
Author: https://github.com/awesomekling Commit: https://github.com/SerenityOS/serenity/commit/e70f944e11 Pull-request: https://github.com/SerenityOS/serenity/pull/16215 Reviewed-by: https://github.com/ADKaster Reviewed-by: https://github.com/trflynn89
|
@ -62,8 +62,8 @@ private:
|
|||
};
|
||||
|
||||
ASTNode::ASTNode(SourceRange source_range)
|
||||
: m_source_code(source_range.code)
|
||||
, m_start_offset(source_range.start.offset)
|
||||
: m_start_offset(source_range.start.offset)
|
||||
, m_source_code(source_range.code)
|
||||
, m_end_offset(source_range.end.offset)
|
||||
{
|
||||
}
|
||||
|
|
|
@ -90,8 +90,10 @@ protected:
|
|||
explicit ASTNode(SourceRange);
|
||||
|
||||
private:
|
||||
RefPtr<SourceCode> m_source_code;
|
||||
// NOTE: These members are carefully ordered so that `m_start_offset` is packed with the padding after RefCounted::m_ref_count.
|
||||
// This creates a 4-byte padding hole after `m_end_offset` which is used to pack subclasses better.
|
||||
u32 m_start_offset { 0 };
|
||||
RefPtr<SourceCode> m_source_code;
|
||||
u32 m_end_offset { 0 };
|
||||
};
|
||||
|
||||
|
|
Loading…
Reference in a new issue