beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Don't implement bogus assertion in prepare-the-script-element

Browse source 
The HTML spec is asking us to make a possibly-bogus assertion, so let's
disable it for now.

Spec bug: https://github.com/whatwg/html/issues/8534
This commit is contained in:
Andreas Kling 2022-11-20 20:56:38 +01:00
parent b21b27fda3
commit e54ae1bd11
Notes: sideshowbarker 2024-07-17 08:38:37 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/e54ae1bd11
Pull-request: https://github.com/SerenityOS/serenity/pull/16125
Reviewed-by: https://github.com/ADKaster ✅
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/HTML/HTMLScriptElement.cpp
View file

@ -394,10 +394,9 @@ void HTMLScriptElement::prepare_script()
}
// 32. If el's type is "classic" and el has a src attribute, or el's type is "module":
if ((m_script_type == ScriptType::Classic && has_attribute(HTML::AttributeNames::src))
|| m_script_type == ScriptType::Module) {
if ((m_script_type == ScriptType::Classic && has_attribute(HTML::AttributeNames::src)) || m_script_type == ScriptType::Module) {
// 1. Assert: el's result is "uninitialized".
VERIFY(m_result.has<ResultState::Uninitialized>());
// FIXME: I believe this step to be a spec bug, and it should be removed: https://github.com/whatwg/html/issues/8534
// 2. If el has an async attribute or el's force async is true:
if (has_attribute(HTML::AttributeNames::async) || m_force_async) {