beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibGfx: Don't constexpr functions returning Strings

Browse source 
Since strings don't have a constexpr constructor, these won't have any
effect anyways. Furthermore, this is explicitly disallowed by the
standard, and makes Clang tools freak out.
This commit is contained in:
Daniel Bertalan 2021-06-20 21:11:29 +02:00 committed by Ali Mohammad Pur
parent 221bd464a0
commit e364845456
Notes: sideshowbarker 2024-07-18 11:34:31 +09:00 
Author: https://github.com/BertalanD
Commit: https://github.com/SerenityOS/serenity/commit/e3648454565
Pull-request: https://github.com/SerenityOS/serenity/pull/8150
Reviewed-by: https://github.com/Hendiadyoin1
Reviewed-by: https://github.com/alimpfard ✅
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGfx/Vector2.h
View file

@ -108,7 +108,7 @@ public:
return sqrt(m_x * m_x + m_y * m_y);
}
constexpr String to_string() const
String to_string() const
{
return String::formatted("[{},{}]", x(), y());
}

2
Userland/Libraries/LibGfx/Vector3.h
View file

@ -124,7 +124,7 @@ public:
return sqrt(m_x * m_x + m_y * m_y + m_z * m_z);
}
constexpr String to_string() const
String to_string() const
{
return String::formatted("[{},{},{}]", x(), y(), z());
}

2
Userland/Libraries/LibGfx/Vector4.h
View file

@ -124,7 +124,7 @@ public:
return sqrt(m_x * m_x + m_y * m_y + m_z * m_z + m_w * m_w);
}
constexpr String to_string() const
String to_string() const
{
return String::formatted("[{},{},{},{}]", x(), y(), z(), w());
}