beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

VirtualFileSystem: Return early in rename() when old_path==new_path

Browse source 
This change fixes disappearing symlink after trying to do the following
thing:
  cp /res/icons/16x16/add-event.png .
  ln -s add-event.png a
  mv a a
This commit is contained in:
LuK1337 2021-08-10 13:39:44 +02:00 committed by Andreas Kling
parent 0286160b62
commit e1ed1d9176
Notes: sideshowbarker 2024-07-18 07:09:02 +09:00 
Author: https://github.com/luk1337
Commit: https://github.com/SerenityOS/serenity/commit/e1ed1d91766
Pull-request: https://github.com/SerenityOS/serenity/pull/9326
Reviewed-by: https://github.com/gunnarbeutner ✅
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Kernel/FileSystem/VirtualFileSystem.cpp
View file

@ -549,6 +549,9 @@ KResult VirtualFileSystem::rename(StringView old_path, StringView new_path, Cust
if (new_basename.is_empty() || new_basename == "."sv || new_basename == ".."sv)
return EINVAL;
if (old_basename == new_basename && old_parent_inode.index() == new_parent_inode.index())
return KSuccess;
if (!new_custody_or_error.is_error()) {
auto& new_custody = *new_custody_or_error.value();
auto& new_inode = new_custody.inode();