beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

AudioServer: Add a hack to make audio "just work" on HDA for now

Browse source 
This should be fixed properly, but we have decided that a quick hack is
fine so that audio "just works" for most people.
This commit is contained in:
kleines Filmröllchen 2023-06-24 13:45:06 +02:00 committed by Jelle Raaijmakers
parent 03fac609ee
commit e0dce41ddf
Notes: sideshowbarker 2024-07-17 03:25:24 +09:00 
Author: https://github.com/kleinesfilmroellchen
Commit: https://github.com/SerenityOS/serenity/commit/e0dce41ddf
Pull-request: https://github.com/SerenityOS/serenity/pull/17656
Reviewed-by: https://github.com/gmta
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Services/AudioServer/Mixer.cpp
View file

@ -57,7 +57,10 @@ void Mixer::mix()
{
Threading::MutexLocker const locker(m_pending_mutex);
// While we have nothing to mix, wait on the condition.
m_mixing_necessary.wait_while([this, &active_mix_queues]() { return m_pending_mixing.is_empty() && active_mix_queues.is_empty(); });
// HACK: HDA is currently broken when we don't constantly feed it a buffer stream.
// Commenting out this line makes it "just work" for the time being. Please add this line back once the issue is fixed.
// See:
// m_mixing_necessary.wait_while([this, &active_mix_queues]() { return m_pending_mixing.is_empty() && active_mix_queues.is_empty(); });
if (!m_pending_mixing.is_empty()) {
active_mix_queues.extend(move(m_pending_mixing));
m_pending_mixing.clear();