beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 08:11:13 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Documentation: Replace TRY() example in Patterns.md

Browse source 
The `Menubar::add_menu()` call used in the previous code snippet no
longer returns `ErrorOr`, which defeats the purpose of the example.
This commit is contained in:
Tim Ledbetter 2023-09-28 23:08:27 +01:00 committed by Sam Atkins
parent dcf3bdcb9a
commit d054116012
Notes: sideshowbarker 2024-07-18 01:43:16 +09:00 
Author: https://github.com/tcl3
Commit: https://github.com/SerenityOS/serenity/commit/d054116012
Pull-request: https://github.com/SerenityOS/serenity/pull/21262
Reviewed-by: https://github.com/AtkinsSJ ✅
1 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
Documentation/Patterns.md
View file

@ -18,21 +18,24 @@ result of the contents of the TRY will be the result of the macro's execution.
### Examples: ### Examples:
Example from LibGUI: Example from LibGfx:
```cpp ```cpp
#include <AK/Try.h> #include <AK/Try.h>
... snip ... ... snip ...
ErrorOr<NonnullRefPtr<Menu>> Window::try_add_menu(String name) ErrorOr<NonnullRefPtr<Bitmap>> Bitmap::create_shareable(BitmapFormat format, IntSize size, int scale_factor)
{ {
auto menu = m_menubar->add_menu({}, move(name)); if (size_would_overflow(format, size, scale_factor))
if (m_window_id) { return Error::from_string_literal("Gfx::Bitmap::create_shareable size overflow");
menu->realize_menu_if_needed();
ConnectionToWindowServer::the().async_add_menu(m_window_id, menu->menu_id()); auto const pitch = minimum_pitch(size.width() * scale_factor, format);
} auto const data_size = size_in_bytes(pitch, size.height() * scale_factor);
return menu;
auto buffer = TRY(Core::AnonymousBuffer::create_with_size(round_up_to_power_of_two(data_size, PAGE_SIZE)));
auto bitmap = TRY(Bitmap::create_with_anonymous_buffer(format, buffer, size, scale_factor, {}));
return bitmap;
} }
``` ```