beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 08:11:13 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Use base URL for link loading

Browse source
This commit is contained in:
Colin Reeder 2024-08-10 20:23:13 -06:00 committed by Sam Atkins
parent ff71d8f2c9
commit c6975a1680
Notes: github-actions[bot] 2024-08-13 13:35:13 +00:00 
Author: https://github.com/vpzomtrrfrt
Commit: https://github.com/LadybirdBrowser/ladybird/commit/c6975a16806
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1036
Reviewed-by: https://github.com/AtkinsSJ ✅
Reviewed-by: https://github.com/shannonbooth
3 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/base/link-element-base.txt Normal file
View file

@ -0,0 +1 @@
document background: rgb(255, 0, 0)

17
Tests/LibWeb/Text/input/base/link-element-base.html Normal file
View file

@ -0,0 +1,17 @@
<!DOCTYPE html>
<html>
<head>
<base href="..">
<link rel="stylesheet" href="body-background-color-red.css">
</head>
<body>
<script src="include.js"></script>
<script>
test(() => {
window.onload = () => {
println("document background: " + getComputedStyle(document.body).backgroundColor);
};
});
</script>
</body>
</html>

4
Userland/Libraries/LibWeb/HTML/HTMLLinkElement.cpp
View file

@ -228,8 +228,8 @@ HTMLLinkElement::LinkProcessingOptions HTMLLinkElement::create_link_options()
// referrer policy the state of el's referrerpolicy content attribute
options.referrer_policy = ReferrerPolicy::from_string(get_attribute(AttributeNames::referrerpolicy).value_or(""_string)).value_or(ReferrerPolicy::ReferrerPolicy::EmptyString);
// FIXME: source set el's source set
// base URL document's URL
options.base_url = document.url();
// base URL document's document base URL
options.base_url = document.base_url();
// origin document's origin
options.origin = document.origin();
// environment document's relevant settings object