beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

HackStudio: Use StringView in DiffViewer::draw_line

Browse source
This commit is contained in:
Shannon Booth 2023-06-24 13:08:47 +12:00 committed by Andreas Kling
parent ee92378b80
commit c60150da15
Notes: sideshowbarker 2024-07-17 02:56:25 +09:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/SerenityOS/serenity/commit/c60150da15
Pull-request: https://github.com/SerenityOS/serenity/pull/19592
Reviewed-by: https://github.com/kennethmyhra ✅
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/DevTools/HackStudio/Git/DiffViewer.cpp
View file

@ -48,7 +48,7 @@ void DiffViewer::paint_event(GUI::PaintEvent& event)
left_y_offset += line_height();
}
for (int i = 0; i < (int)hunk.added_lines.size() - (int)hunk.removed_lines.size(); ++i) {
draw_line(painter, "", left_y_offset, LinePosition::Left, LineType::Missing);
draw_line(painter, ""sv, left_y_offset, LinePosition::Left, LineType::Missing);
left_y_offset += line_height();
}
@ -58,7 +58,7 @@ void DiffViewer::paint_event(GUI::PaintEvent& event)
right_y_offset += line_height();
}
for (int i = 0; i < (int)hunk.removed_lines.size() - (int)hunk.added_lines.size(); ++i) {
draw_line(painter, "", right_y_offset, LinePosition::Right, LineType::Missing);
draw_line(painter, ""sv, right_y_offset, LinePosition::Right, LineType::Missing);
right_y_offset += line_height();
}
@ -71,7 +71,7 @@ void DiffViewer::paint_event(GUI::PaintEvent& event)
}
}
void DiffViewer::draw_line(GUI::Painter& painter, DeprecatedString const& line, size_t y_offset, LinePosition line_position, LineType line_type)
void DiffViewer::draw_line(GUI::Painter& painter, StringView line, size_t y_offset, LinePosition line_position, LineType line_type)
{
size_t line_width = font().width(line);

2
Userland/DevTools/HackStudio/Git/DiffViewer.h
View file

@ -43,7 +43,7 @@ private:
Missing,
};
void draw_line(GUI::Painter&, DeprecatedString const& line, size_t y_offset, LinePosition, LineType);
void draw_line(GUI::Painter&, StringView line, size_t y_offset, LinePosition, LineType);
static Vector<DeprecatedString> split_to_lines(DeprecatedString const& text);