beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 16:21:29 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Meta: Add allow-list for icon size detection in CMake

Browse source 
The only icons we are currently warning about are designed
and rendered as small icons intentionally, as their only use
is in desktop applets, and thus are exempt to this rule.

This reduces build spam back down to a minimum.
I should have just done this in the first place, back in #4729
This commit is contained in:
Brian Gianforcaro 2021-04-19 21:26:09 -07:00 committed by Andreas Kling
parent 955eef83b0
commit c195ee6fd2
Notes: sideshowbarker 2024-07-18 19:22:03 +09:00 
Author: https://github.com/bgianfo
Commit: https://github.com/SerenityOS/serenity/commit/c195ee6fd2e
Pull-request: https://github.com/SerenityOS/serenity/pull/6504
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Meta/CMake/utils.cmake
View file

@ -86,7 +86,13 @@ function(serenity_app target_name)
if (EXISTS "${medium_icon}")
embed_resource("${target_name}" serenity_icon_m "${medium_icon}")
else()
message(WARNING "Missing medium app icon: ${medium_icon}")
# These icons are designed small only for use in applets, and thus are exempt.
list(APPEND allowed_missing_medium_icons "audio-volume-high")
list(APPEND allowed_missing_medium_icons "edit-copy")
if (NOT ${SERENITY_APP_ICON} IN_LIST allowed_missing_medium_icons)
message(WARNING "Missing medium app icon: ${medium_icon}")
endif()
endif()
endfunction()