beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 08:41:15 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibGfx: Remove unneeded TODO in BMPLoader

Browse source 
There was a TODO questioning whether breaking on >4bpp images
was the correct behaviour when RLE4 was detected. There is no
indication in the spec that RLE4 can be used with anything >4bpp,
so I believe this doesn't require additional follow-up.

MS Spec:
https://learn.microsoft.com/en-us/windows/win32/gdi/bitmap-compression
This commit is contained in:
Optimoos 2023-06-18 17:01:29 -04:00 committed by Andreas Kling
parent 1a17e08f87
commit bee316cfbe
Notes: sideshowbarker 2024-07-17 05:13:53 +09:00 
Author: https://github.com/Optimoos
Commit: https://github.com/SerenityOS/serenity/commit/bee316cfbe
Pull-request: https://github.com/SerenityOS/serenity/pull/19470
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibGfx/ImageFormats/BMPLoader.cpp
View file

@ -438,7 +438,6 @@ static bool check_for_invalid_bitmask_combinations(BMPLoadingContext& context)
return false;
break;
case Compression::RLE4:
// TODO: This is a guess
if (bpp > 4)
return false;
break;