CI: Remove outdated references to Serenity vs. toolchain ccache
Some checks are pending
CI / Lagom (false, FUZZ, ubuntu-22.04, Linux, Clang) (push) Waiting to run
CI / Lagom (false, NO_FUZZ, macos-14, macOS, Clang) (push) Waiting to run
CI / Lagom (false, NO_FUZZ, ubuntu-22.04, Linux, GNU) (push) Waiting to run
CI / Lagom (true, NO_FUZZ, ubuntu-22.04, Linux, Clang) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (macos-14, macOS, macOS-universal2) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (ubuntu-22.04, Linux, Linux-x86_64) (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
Push notes / build (push) Waiting to run

The toolchain ccache no longer exists. Remove it and the "Serenity"
prefix from remaining ccache variables.
This commit is contained in:
Timothy Flynn 2024-08-27 18:43:14 -04:00 committed by Tim Flynn
parent 0dd8fe1f0f
commit ba36312864
Notes: github-actions[bot] 2024-08-27 23:25:27 +00:00
5 changed files with 41 additions and 50 deletions

View file

@ -23,8 +23,8 @@ inputs:
description: 'Increment this number if CI has trouble with ccache.' description: 'Increment this number if CI has trouble with ccache.'
required: false required: false
default: '0' default: '0'
serenity_ccache_path: ccache_path:
description: 'Path to the SerenityOS ccache directory' description: 'Path to the ccache directory'
required: false required: false
default: '' default: ''
download_cache_path: download_cache_path:
@ -33,9 +33,9 @@ inputs:
default: 'caches' default: 'caches'
outputs: outputs:
serenity_ccache_primary_key: ccache_primary_key:
description: 'Primary key for the Serenity ccache' description: 'Primary ccache key'
value: ${{ steps.serenity-ccache.outputs.cache-primary-key }} value: ${{ steps.ccache.outputs.cache-primary-key }}
runs: runs:
using: "composite" using: "composite"
@ -46,27 +46,27 @@ runs:
run: | run: |
echo "timestamp=$(date -u "+%Y%m%d%H%M_%S")" >> "$GITHUB_OUTPUT" echo "timestamp=$(date -u "+%Y%m%d%H%M_%S")" >> "$GITHUB_OUTPUT"
- name: 'Serenity Compiler Cache' - name: 'Compiler Cache'
uses: actions/cache/restore@v4 uses: actions/cache/restore@v4
id: 'serenity-ccache' id: 'ccache'
if: ${{ inputs.serenity_ccache_path != '' }} if: ${{ inputs.ccache_path != '' }}
with: with:
path: ${{ inputs.serenity_ccache_path }} path: ${{ inputs.ccache_path }}
key: '"ccache" | "${{ inputs.os }}" | "${{ inputs.arch }}" | "${{ inputs.toolchain }}" | "${{ inputs.cache_key_extra }}" | "${{ inputs.ccache_version }}" | ${{ steps.date-stamp.outputs.timestamp }}' key: '"ccache" | "${{ inputs.os }}" | "${{ inputs.arch }}" | "${{ inputs.toolchain }}" | "${{ inputs.cache_key_extra }}" | "${{ inputs.ccache_version }}" | ${{ steps.date-stamp.outputs.timestamp }}'
restore-keys: | restore-keys: |
"ccache" | "${{ inputs.os }}" | "${{ inputs.arch }}" | "${{ inputs.toolchain }}" | "${{ inputs.cache_key_extra }}" | "${{ inputs.ccache_version }}" "ccache" | "${{ inputs.os }}" | "${{ inputs.arch }}" | "${{ inputs.toolchain }}" | "${{ inputs.cache_key_extra }}" | "${{ inputs.ccache_version }}"
- name: 'Configure Serenity ccache' - name: 'Configure Compiler Cache'
if: ${{ inputs.serenity_ccache_path != '' }} if: ${{ inputs.ccache_path != '' }}
shell: bash shell: bash
run: | run: |
CCACHE_DIR=${{ inputs.serenity_ccache_path }} ccache -M 0 CCACHE_DIR=${{ inputs.ccache_path }} ccache -M 0
# Reset all ccache modification dates to a known epoch. This provides a baseline that we can prune against. # Reset all ccache modification dates to a known epoch. This provides a baseline that we can prune against.
find ${{ inputs.serenity_ccache_path }} | tac | xargs touch -a -m -d "2018-10-10T09:53:07Z" find ${{ inputs.ccache_path }} | tac | xargs touch -a -m -d "2018-10-10T09:53:07Z"
CCACHE_DIR=${{ inputs.serenity_ccache_path }} ccache -s CCACHE_DIR=${{ inputs.ccache_path }} ccache -s
CCACHE_DIR=${{ inputs.serenity_ccache_path }} ccache -z CCACHE_DIR=${{ inputs.ccache_path }} ccache -z
- name: Export vcpkg GitHub Actions cache environment variables - name: Export vcpkg GitHub Actions cache environment variables
uses: actions/github-script@v7 uses: actions/github-script@v7

View file

@ -7,12 +7,12 @@ inputs:
description: 'Target Architecture to restore caches for' description: 'Target Architecture to restore caches for'
required: false required: false
default: 'x86_64' default: 'x86_64'
serenity_ccache_path: ccache_path:
description: 'Path to the SerenityOS ccache directory' description: 'Path to the ccache directory'
required: false required: false
default: '' default: ''
serenity_ccache_primary_key: ccache_primary_key:
description: 'Primary key for the Serenity ccache' description: 'Primary ccache key'
required: false required: false
default: '' default: ''
@ -21,22 +21,18 @@ runs:
steps: steps:
- name: 'Prune obsolete ccache files' - name: 'Prune obsolete ccache files'
shell: bash shell: bash
if: ${{ inputs.serenity_ccache_path != '' }} if: ${{ inputs.ccache_path != '' }}
run: | run: |
CCACHE_DIR=${{ inputs.serenity_ccache_path }} ccache --evict-older-than=1d CCACHE_DIR=${{ inputs.ccache_path }} ccache --evict-older-than=1d
- name: 'Serenity Compiler Cache' - name: 'Compiler Cache'
uses: actions/cache/save@v4 uses: actions/cache/save@v4
if: ${{ inputs.serenity_ccache_path != '' }} if: ${{ inputs.ccache_path != '' }}
with: with:
path: ${{ inputs.serenity_ccache_path }} path: ${{ inputs.ccache_path }}
key: ${{ inputs.serenity_ccache_primary_key }} key: ${{ inputs.ccache_primary_key }}
- name: 'Cache Stats' - name: 'Cache Stats'
shell: bash shell: bash
run: | run: |
echo "Toolchain Compiler Cache" CCACHE_DIR=${{ inputs.ccache_path }} ccache -s
CCACHE_DIR=${{ inputs.toolchain_ccache_path }} ccache -s
echo "Serenity Compiler Cache"
CCACHE_DIR=${{ inputs.serenity_ccache_path }} ccache -s

View file

@ -4,7 +4,7 @@ on: [push]
env: env:
LADYBIRD_SOURCE_DIR: ${{ github.workspace }} LADYBIRD_SOURCE_DIR: ${{ github.workspace }}
SERENITY_CCACHE_DIR: ${{ github.workspace }}/.ccache CCACHE_DIR: ${{ github.workspace }}/.ccache
VCPKG_ROOT: ${{ github.workspace }}/Toolchain/Tarballs/vcpkg VCPKG_ROOT: ${{ github.workspace }}/Toolchain/Tarballs/vcpkg
VCPKG_BINARY_SOURCES: "clear;x-gha,readwrite" VCPKG_BINARY_SOURCES: "clear;x-gha,readwrite"
@ -44,7 +44,7 @@ jobs:
os: ${{ matrix.os_name }} os: ${{ matrix.os_name }}
arch: 'Lagom' arch: 'Lagom'
cache_key_extra: 'LibJS Artifacts' cache_key_extra: 'LibJS Artifacts'
serenity_ccache_path: ${{ env.SERENITY_CCACHE_DIR }} ccache_path: ${{ env.CCACHE_DIR }}
download_cache_path: ${{ github.workspace }}/Build/caches download_cache_path: ${{ github.workspace }}/Build/caches
- name: Create build directory Ubuntu - name: Create build directory Ubuntu
@ -56,7 +56,7 @@ jobs:
-DENABLE_GUI_TARGETS=OFF -DENABLE_GUI_TARGETS=OFF
if: ${{ matrix.os == 'ubuntu-22.04' }} if: ${{ matrix.os == 'ubuntu-22.04' }}
env: env:
CCACHE_DIR: ${{ env.SERENITY_CCACHE_DIR }} CCACHE_DIR: ${{ env.CCACHE_DIR }}
# FIXME: Add the following flag back when vcpkg supports Universal binaries: # FIXME: Add the following flag back when vcpkg supports Universal binaries:
# -DCMAKE_OSX_ARCHITECTURES="x86_64;arm64" # -DCMAKE_OSX_ARCHITECTURES="x86_64;arm64"
@ -69,23 +69,19 @@ jobs:
-DCMAKE_OSX_DEPLOYMENT_TARGET="11.0" \ -DCMAKE_OSX_DEPLOYMENT_TARGET="11.0" \
-DENABLE_GUI_TARGETS=OFF -DENABLE_GUI_TARGETS=OFF
if: ${{ matrix.os == 'macos-14' }} if: ${{ matrix.os == 'macos-14' }}
env:
CCACHE_DIR: ${{ env.SERENITY_CCACHE_DIR }}
- name: Build and package js - name: Build and package js
working-directory: Build working-directory: Build
run: | run: |
ninja js ninja js
cpack cpack
env:
CCACHE_DIR: ${{ env.SERENITY_CCACHE_DIR }}
- name: Save Caches - name: Save Caches
uses: ./.github/actions/cache-save uses: ./.github/actions/cache-save
with: with:
arch: 'Lagom' arch: 'Lagom'
serenity_ccache_path: ${{ env.SERENITY_CCACHE_DIR }} ccache_path: ${{ env.CCACHE_DIR }}
serenity_ccache_primary_key: ${{ steps.cache-restore.outputs.serenity_ccache_primary_key }} ccache_primary_key: ${{ steps.cache-restore.outputs.ccache_primary_key }}
- name: Upload js package - name: Upload js package
uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v4

View file

@ -22,8 +22,8 @@ on:
default: false default: false
env: env:
# runner.workspace = /home/runner/work/serenity # runner.workspace = /home/runner/work/ladybird
# github.workspace = /home/runner/work/serenity/serenity # github.workspace = /home/runner/work/ladybird/ladybird
LADYBIRD_SOURCE_DIR: ${{ github.workspace }} LADYBIRD_SOURCE_DIR: ${{ github.workspace }}
CCACHE_DIR: ${{ github.workspace }}/.ccache CCACHE_DIR: ${{ github.workspace }}/.ccache
VCPKG_ROOT: ${{ github.workspace }}/Toolchain/Tarballs/vcpkg VCPKG_ROOT: ${{ github.workspace }}/Toolchain/Tarballs/vcpkg
@ -91,11 +91,10 @@ jobs:
arch: 'Lagom' arch: 'Lagom'
toolchain: ${{ inputs.toolchain }} toolchain: ${{ inputs.toolchain }}
cache_key_extra: ${{ steps.build-parameters.outputs.ccache_key }} cache_key_extra: ${{ steps.build-parameters.outputs.ccache_key }}
serenity_ccache_path: ${{ env.CCACHE_DIR }} ccache_path: ${{ env.CCACHE_DIR }}
download_cache_path: ${{ github.workspace }}/Build/caches download_cache_path: ${{ github.workspace }}/Build/caches
- name: Set dynamic environment variables - name: Set dynamic environment variables
id: 'set-env-vars'
run: | run: |
# Note: Required for vcpkg to use this compiler for its own builds. # Note: Required for vcpkg to use this compiler for its own builds.
echo "CC=${{ steps.build-parameters.outputs.host_cc }}" >> "$GITHUB_ENV" echo "CC=${{ steps.build-parameters.outputs.host_cc }}" >> "$GITHUB_ENV"
@ -172,8 +171,8 @@ jobs:
uses: ./.github/actions/cache-save uses: ./.github/actions/cache-save
with: with:
arch: 'Lagom' arch: 'Lagom'
serenity_ccache_path: ${{ env.CCACHE_DIR }} ccache_path: ${{ env.CCACHE_DIR }}
serenity_ccache_primary_key: ${{ steps.cache-restore.outputs.serenity_ccache_primary_key }} ccache_primary_key: ${{ steps.cache-restore.outputs.ccache_primary_key }}
# === TEST === # === TEST ===

View file

@ -6,8 +6,8 @@ on:
- cron: '0 0 * * *' - cron: '0 0 * * *'
env: env:
# runner.workspace = /home/runner/work/serenity # runner.workspace = /home/runner/work/ladybird
# github.workspace = /home/runner/work/serenity/serenity # github.workspace = /home/runner/work/ladybird/ladybird
LADYBIRD_SOURCE_DIR: ${{ github.workspace }} LADYBIRD_SOURCE_DIR: ${{ github.workspace }}
CCACHE_DIR: ${{ github.workspace }}/.ccache CCACHE_DIR: ${{ github.workspace }}/.ccache
VCPKG_ROOT: ${{ github.workspace }}/Toolchain/Tarballs/vcpkg VCPKG_ROOT: ${{ github.workspace }}/Toolchain/Tarballs/vcpkg
@ -54,7 +54,7 @@ jobs:
os: ${{ matrix.os_name }} os: ${{ matrix.os_name }}
arch: 'Lagom' arch: 'Lagom'
cache_key_extra: 'Nightly Android' cache_key_extra: 'Nightly Android'
serenity_ccache_path: ${{ env.CCACHE_DIR }} ccache_path: ${{ env.CCACHE_DIR }}
download_cache_path: ${{ github.workspace }}/Build/caches download_cache_path: ${{ github.workspace }}/Build/caches
- name: Assign Build Parameters - name: Assign Build Parameters
@ -101,5 +101,5 @@ jobs:
uses: ./.github/actions/cache-save uses: ./.github/actions/cache-save
with: with:
arch: 'Lagom' arch: 'Lagom'
serenity_ccache_path: ${{ env.CCACHE_DIR }} ccache_path: ${{ env.CCACHE_DIR }}
serenity_ccache_primary_key: ${{ steps.cache-restore.outputs.serenity_ccache_primary_key }} ccache_primary_key: ${{ steps.cache-restore.outputs.ccache_primary_key }}