beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibLine: Avoid pointless size_t <-> ssize_t cast

Browse source 
Just a small cleanup.
This commit is contained in:
Ali Mohammad Pur 2022-03-27 22:55:03 +04:30 committed by Andreas Kling
parent f6afb70b07
commit b732edf61c
Notes: sideshowbarker 2024-07-17 16:39:08 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/b732edf61c
Pull-request: https://github.com/SerenityOS/serenity/pull/13296
Issue: https://github.com/SerenityOS/serenity/issues/13280
Issue: https://github.com/SerenityOS/serenity/issues/13281
Reviewed-by: https://github.com/linusg ✅
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibLine/Editor.cpp
View file

@ -827,9 +827,9 @@ void Editor::handle_read_event()
}
m_incomplete_data.append(keybuf, nread);
nread = m_incomplete_data.size();
auto available_bytes = m_incomplete_data.size();
if (nread == 0) {
if (available_bytes == 0) {
m_input_error = Error::Empty;
finish();
return;
@ -839,12 +839,12 @@ void Editor::handle_read_event()
// Discard starting bytes until they make sense as utf-8.
size_t valid_bytes = 0;
while (nread) {
Utf8View { StringView { m_incomplete_data.data(), (size_t)nread } }.validate(valid_bytes);
if (valid_bytes)
while (available_bytes > 0) {
Utf8View { StringView { m_incomplete_data.data(), available_bytes } }.validate(valid_bytes);
if (valid_bytes != 0)
break;
m_incomplete_data.take_first();
--nread;
--available_bytes;
}
Utf8View input_view { StringView { m_incomplete_data.data(), valid_bytes } };