From b688b5d9d4cfd8f781dd05d522d9533cd6796aca Mon Sep 17 00:00:00 2001 From: Tim Ledbetter Date: Tue, 27 Aug 2024 20:25:14 +0100 Subject: [PATCH] LibWeb: Correctly test if WebDriver ExecuteScript timeout is reached Previously, the conversion assumed that the supplied timeout was in seconds rather than milliseconds. --- Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp b/Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp index 5dcdf6e0d78..62bd4cbdde2 100644 --- a/Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp +++ b/Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp @@ -332,7 +332,7 @@ ExecuteScriptResultSerialized execute_async_script(Web::Page& page, ByteString c auto start = MonotonicTime::now(); auto has_timed_out = [&] { - return timeout.has_value() && (MonotonicTime::now() - start) > AK::Duration::from_seconds(static_cast(*timeout)); + return timeout.has_value() && (MonotonicTime::now() - start) > AK::Duration::from_milliseconds(static_cast(*timeout)); }; // AD-HOC: An execution context is required for Promise creation hooks.