beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 08:41:15 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibJS: Implement Temporal.PlainDateTime.prototype.millisecond

Browse source
This commit is contained in:
Idan Horowitz 2021-07-30 00:08:37 +03:00 committed by Linus Groh
parent 3fdb314a39
commit b2f66a06ac
Notes: sideshowbarker 2024-07-18 07:46:10 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/b2f66a06ac6
Pull-request: https://github.com/SerenityOS/serenity/pull/9097
Reviewed-by: https://github.com/linusg ✅
3 changed files with 29 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibJS/Runtime/Temporal/PlainDateTimePrototype.cpp
View file

@ -35,6 +35,7 @@ void PlainDateTimePrototype::initialize(GlobalObject& global_object)
define_native_accessor(vm.names.hour, hour_getter, {}, Attribute::Configurable);
define_native_accessor(vm.names.minute, minute_getter, {}, Attribute::Configurable);
define_native_accessor(vm.names.second, second_getter, {}, Attribute::Configurable);
define_native_accessor(vm.names.millisecond, millisecond_getter, {}, Attribute::Configurable);
u8 attr = Attribute::Writable | Attribute::Configurable;
define_native_function(vm.names.valueOf, value_of, 0, attr);
@ -171,6 +172,19 @@ JS_DEFINE_NATIVE_FUNCTION(PlainDateTimePrototype::second_getter)
return Value(date_time->iso_second());
}
// 5.3.11 get Temporal.PlainDateTime.prototype.millisecond, https://tc39.es/proposal-temporal/#sec-get-temporal.plaindatetime.prototype.millisecond
JS_DEFINE_NATIVE_FUNCTION(PlainDateTimePrototype::millisecond_getter)
{
// 1. Let dateTime be the this value.
// 2. Perform ? RequireInternalSlot(dateTime, [[InitializedTemporalDateTime]]).
auto* date_time = typed_this(global_object);
if (vm.exception())
return {};
// 3. Return 𝔽(dateTime.[[ISOMillisecond]]).
return Value(date_time->iso_millisecond());
}
// 5.3.35 Temporal.PlainDateTime.prototype.valueOf ( ), https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.valueof
JS_DEFINE_NATIVE_FUNCTION(PlainDateTimePrototype::value_of)
{

1
Userland/Libraries/LibJS/Runtime/Temporal/PlainDateTimePrototype.h
View file

@ -27,6 +27,7 @@ private:
JS_DECLARE_NATIVE_FUNCTION(hour_getter);
JS_DECLARE_NATIVE_FUNCTION(minute_getter);
JS_DECLARE_NATIVE_FUNCTION(second_getter);
JS_DECLARE_NATIVE_FUNCTION(millisecond_getter);
JS_DECLARE_NATIVE_FUNCTION(value_of);
JS_DECLARE_NATIVE_FUNCTION(to_plain_date);
JS_DECLARE_NATIVE_FUNCTION(get_iso_fields);

14
Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDateTime/PlainDateTime.prototype.millisecond.js Normal file
View file

@ -0,0 +1,14 @@
describe("correct behavior", () => {
test("basic functionality", () => {
const plainDateTime = new Temporal.PlainDateTime(2021, 7, 30, 1, 4, 32, 111);
expect(plainDateTime.millisecond).toBe(111);
});
});
test("errors", () => {
test("this value must be a Temporal.PlainDateTime object", () => {
expect(() => {
Reflect.get(Temporal.PlainDateTime.prototype, "millisecond", "foo");
}).toThrowWithMessage(TypeError, "Not a Temporal.PlainDateTime");
});
});