mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-09-30 00:31:14 +00:00
LibJS: Use local variables to store function parameters in some cases
Using local variables to store function parameters makes Kraken tests run 7-10% faster. For now this optimization is limited to only be applied if: - Parameter does not use destructuring assignment - None of the function params has default value - There is no access to "arguments" variable inside function body
This commit is contained in:
parent
2e81cc4cf7
commit
b1af91d8c4
Notes:
sideshowbarker
2024-07-17 00:47:29 +09:00
Author: https://github.com/kalenikaliaksandr Commit: https://github.com/SerenityOS/serenity/commit/b1af91d8c4 Pull-request: https://github.com/SerenityOS/serenity/pull/19858
|
@ -77,9 +77,15 @@ public:
|
|||
{
|
||||
ScopePusher scope_pusher(parser, &function_body, ScopeLevel::FunctionTopLevel, ScopeType::Function);
|
||||
scope_pusher.m_function_parameters = parameters;
|
||||
|
||||
auto has_parameters_with_default_values = false;
|
||||
for (auto& parameter : parameters) {
|
||||
parameter.binding.visit(
|
||||
[&](Identifier const& identifier) {
|
||||
if (parameter.default_value)
|
||||
has_parameters_with_default_values = true;
|
||||
scope_pusher.register_identifier(identifier);
|
||||
scope_pusher.m_function_parameters_candidates_for_local_variables.set(identifier.string());
|
||||
scope_pusher.m_forbidden_lexical_names.set(identifier.string());
|
||||
},
|
||||
[&](NonnullRefPtr<BindingPattern const> const& binding_pattern) {
|
||||
|
@ -89,6 +95,11 @@ public:
|
|||
}));
|
||||
});
|
||||
}
|
||||
|
||||
if (has_parameters_with_default_values) {
|
||||
scope_pusher.m_function_parameters_candidates_for_local_variables.clear();
|
||||
}
|
||||
|
||||
return scope_pusher;
|
||||
}
|
||||
|
||||
|
@ -313,6 +324,10 @@ public:
|
|||
scope_has_declaration = false;
|
||||
}
|
||||
|
||||
if (m_type == ScopeType::Function && !m_contains_access_to_arguments_object && m_function_parameters_candidates_for_local_variables.contains(identifier_group_name)) {
|
||||
scope_has_declaration = true;
|
||||
}
|
||||
|
||||
if (scope_has_declaration) {
|
||||
if (function_declaration)
|
||||
continue;
|
||||
|
@ -413,6 +428,7 @@ private:
|
|||
Vector<NonnullRefPtr<FunctionDeclaration const>> m_functions_to_hoist;
|
||||
|
||||
HashTable<DeprecatedFlyString> m_bound_names;
|
||||
HashTable<DeprecatedFlyString> m_function_parameters_candidates_for_local_variables;
|
||||
|
||||
struct IdentifierGroup {
|
||||
bool captured_by_nested_function { false };
|
||||
|
|
|
@ -479,12 +479,18 @@ ThrowCompletionOr<void> ECMAScriptFunctionObject::function_declaration_instantia
|
|||
Environment* used_environment = has_duplicates ? nullptr : environment;
|
||||
|
||||
if constexpr (IsSame<NonnullRefPtr<Identifier const> const&, decltype(param)>) {
|
||||
Reference reference = TRY(vm.resolve_binding(param->string(), used_environment));
|
||||
// Here the difference from hasDuplicates is important
|
||||
if (has_duplicates)
|
||||
return reference.put_value(vm, argument_value);
|
||||
else
|
||||
return reference.initialize_referenced_binding(vm, argument_value);
|
||||
if (vm.bytecode_interpreter_if_exists() && param->is_local()) {
|
||||
// NOTE: Local variables are supported only in bytecode interpreter
|
||||
callee_context.local_variables[param->local_variable_index()] = argument_value;
|
||||
return {};
|
||||
} else {
|
||||
Reference reference = TRY(vm.resolve_binding(param->string(), used_environment));
|
||||
// Here the difference from hasDuplicates is important
|
||||
if (has_duplicates)
|
||||
return reference.put_value(vm, argument_value);
|
||||
else
|
||||
return reference.initialize_referenced_binding(vm, argument_value);
|
||||
}
|
||||
}
|
||||
if constexpr (IsSame<NonnullRefPtr<BindingPattern const> const&, decltype(param)>) {
|
||||
// Here the difference from hasDuplicates is important
|
||||
|
|
Loading…
Reference in a new issue