beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 16:21:29 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Improve HTMLSelectElement spec compliance

Browse source 
Set default `size` value according to spec
This commit is contained in:
Timur Sultanov 2024-07-25 21:20:04 +04:00 committed by Sam Atkins
parent 9d4f3c938f
commit ad7b2b7c26
Notes: github-actions[bot] 2024-07-26 08:16:39 +00:00 
Author: https://github.com/TSultanov
Commit: https://github.com/LadybirdBrowser/ladybird/commit/ad7b2b7c26c
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/832
Reviewed-by: https://github.com/AtkinsSJ ✅
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibWeb/Text/expected/select.txt
View file

@ -6,7 +6,7 @@
6. "Three"
7. 45
8. 0
9. 0
9. 1
10. 3
11. 999
12. 10

11
Userland/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
View file

@ -71,15 +71,22 @@ void HTMLSelectElement::adjust_computed_style(CSS::StyleProperties& style)
style.set_property(CSS::PropertyID::Display, CSS::DisplayStyleValue::create(CSS::Display::from_short(CSS::Display::Short::InlineBlock)));
}
// https://html.spec.whatwg.org/multipage/form-elements.html#dom-select-size
// https://html.spec.whatwg.org/multipage/form-elements.html#concept-select-size
WebIDL::UnsignedLong HTMLSelectElement::size() const
{
// The size IDL attribute must reflect the respective content attributes of the same name. The size IDL attribute has a default value of 0.
if (auto size_string = get_attribute(HTML::AttributeNames::size); size_string.has_value()) {
// The display size of a select element is the result of applying the rules for parsing non-negative integers
// to the value of element's size attribute, if it has one and parsing it is successful.
if (auto size = parse_non_negative_integer(*size_string); size.has_value())
return *size;
}
return 0;
// If applying those rules to the attribute's value is not successful or if the size attribute is absent,
// then the element's display size is 4 if the element's multiple content attribute is present, and 1 otherwise.
if (has_attribute(AttributeNames::multiple))
return 4;
return 1;
}
WebIDL::ExceptionOr<void> HTMLSelectElement::set_size(WebIDL::UnsignedLong size)