From aabf1a65b14f2af67ce71699a743367ca8e29778 Mon Sep 17 00:00:00 2001 From: Tim Ledbetter Date: Thu, 21 Mar 2024 18:34:01 +0000 Subject: [PATCH] LibWeb: Align CORSSettingsAttribute values with the specification This change makes our crossOrigin attribute getter behave the same way as other browsers. --- .../expected/HTML/crossOrigin-attribute.txt | 21 ++++++++++++++++++ .../input/HTML/crossOrigin-attribute.html | 22 +++++++++++++++++++ .../LibWeb/HTML/Scripting/Fetching.idl | 3 +-- 3 files changed, 44 insertions(+), 2 deletions(-) create mode 100644 Tests/LibWeb/Text/expected/HTML/crossOrigin-attribute.txt create mode 100644 Tests/LibWeb/Text/input/HTML/crossOrigin-attribute.html diff --git a/Tests/LibWeb/Text/expected/HTML/crossOrigin-attribute.txt b/Tests/LibWeb/Text/expected/HTML/crossOrigin-attribute.txt new file mode 100644 index 00000000000..ecb74f0c131 --- /dev/null +++ b/Tests/LibWeb/Text/expected/HTML/crossOrigin-attribute.txt @@ -0,0 +1,21 @@ +audio crossOrigin initial value: null +audio crossOrigin value after setting to "invalid": anonymous +audio crossOrigin value after setting to "use-credentials": use-credentials +audio crossOrigin value after setting to null: null +audio crossOrigin value after setting to "USE-CREDENTIALS": use-credentials +audio crossOrigin value after setting to "": anonymous +audio crossOrigin value after calling removeAttribute: null +script crossOrigin initial value: null +script crossOrigin value after setting to "invalid": anonymous +script crossOrigin value after setting to "use-credentials": use-credentials +script crossOrigin value after setting to null: null +script crossOrigin value after setting to "USE-CREDENTIALS": use-credentials +script crossOrigin value after setting to "": anonymous +script crossOrigin value after calling removeAttribute: null +video crossOrigin initial value: null +video crossOrigin value after setting to "invalid": anonymous +video crossOrigin value after setting to "use-credentials": use-credentials +video crossOrigin value after setting to null: null +video crossOrigin value after setting to "USE-CREDENTIALS": use-credentials +video crossOrigin value after setting to "": anonymous +video crossOrigin value after calling removeAttribute: null diff --git a/Tests/LibWeb/Text/input/HTML/crossOrigin-attribute.html b/Tests/LibWeb/Text/input/HTML/crossOrigin-attribute.html new file mode 100644 index 00000000000..8289299c744 --- /dev/null +++ b/Tests/LibWeb/Text/input/HTML/crossOrigin-attribute.html @@ -0,0 +1,22 @@ + + + diff --git a/Userland/Libraries/LibWeb/HTML/Scripting/Fetching.idl b/Userland/Libraries/LibWeb/HTML/Scripting/Fetching.idl index 8519922558a..11c9e5a60e7 100644 --- a/Userland/Libraries/LibWeb/HTML/Scripting/Fetching.idl +++ b/Userland/Libraries/LibWeb/HTML/Scripting/Fetching.idl @@ -1,7 +1,6 @@ // https://html.spec.whatwg.org/multipage/urls-and-fetching.html#cors-settings-attribute -[MissingValueDefault=, InvalidValueDefault=anonymous] +[InvalidValueDefault=anonymous] enum CORSSettingsAttribute { "anonymous", - "", "use-credentials" };