beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 16:21:29 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Don't send a request body in XMLHttpRequest GET or HEAD

Browse source
This commit is contained in:
Andreas Kling 2021-10-04 00:06:48 +02:00
parent 0cb4d48283
commit a7b1c7eb16
Notes: sideshowbarker 2024-07-18 08:59:31 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/a7b1c7eb16e
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.cpp
View file

@ -161,7 +161,7 @@ DOM::ExceptionOr<void> XMLHttpRequest::open(const String& method, const String&
}
// https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send
DOM::ExceptionOr<void> XMLHttpRequest::send(String const& body)
DOM::ExceptionOr<void> XMLHttpRequest::send(String body)
{
if (m_ready_state != ReadyState::Opened)
return DOM::InvalidStateError::create("XHR readyState is not OPENED");
@ -169,9 +169,9 @@ DOM::ExceptionOr<void> XMLHttpRequest::send(String const& body)
if (m_send)
return DOM::InvalidStateError::create("XHR send() flag is already set");
// FIXME: If this’s request method is `GET` or `HEAD`, then set body to null.
// FIXME: If body is not null, then:
// If this’s request method is `GET` or `HEAD`, then set body to null.
if (m_method.is_one_of("GET"sv, "HEAD"sv))
body = {};
AK::URL request_url = m_window->associated_document().parse_url(m_url.to_string());
dbgln("XHR send from {} to {}", m_window->associated_document().url(), request_url);

2
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.h
View file

@ -52,7 +52,7 @@ public:
String response_text() const;
DOM::ExceptionOr<void> open(const String& method, const String& url);
DOM::ExceptionOr<void> send(String const& body);
DOM::ExceptionOr<void> send(String body);
DOM::ExceptionOr<void> set_request_header(const String& header, const String& value);