beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 08:41:15 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibJS: Use OrderedHashMap instead of HashMap in the Map built-in

Browse source 
This ensures insertion-order iteration.
This commit is contained in:
Idan Horowitz 2021-06-16 00:00:26 +03:00 committed by Linus Groh
parent f1f00be691
commit a27fbfd45f
Notes: sideshowbarker 2024-07-18 12:12:53 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/a27fbfd45f0
Pull-request: https://github.com/SerenityOS/serenity/pull/8076
Reviewed-by: https://github.com/linusg ✅
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/Map.h
View file

@ -22,13 +22,13 @@ public:
explicit Map(Object& prototype);
virtual ~Map() override;
HashMap<Value, Value, ValueTraits> const& entries() const { return m_entries; };
HashMap<Value, Value, ValueTraits>& entries() { return m_entries; };
OrderedHashMap<Value, Value, ValueTraits> const& entries() const { return m_entries; };
OrderedHashMap<Value, Value, ValueTraits>& entries() { return m_entries; };
private:
virtual void visit_edges(Visitor& visitor) override;
HashMap<Value, Value, ValueTraits> m_entries; // FIXME: Replace with a HashMap that maintains a linked list of insertion order for correct iteration order
OrderedHashMap<Value, Value, ValueTraits> m_entries;
};
}

2
Userland/Libraries/LibJS/Runtime/MapIterator.h
View file

@ -33,7 +33,7 @@ private:
Map& m_map;
bool m_done { false };
Object::PropertyKind m_iteration_kind;
HashMap<Value, Value, ValueTraits>::IteratorType m_iterator;
OrderedHashMap<Value, Value, ValueTraits>::IteratorType m_iterator;
};
}