beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 16:21:29 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Ladybird/AppKit: Support muting an entire page

Browse source 
We already display a speaker icon on tabs which are playing audio. This
allows the user to click that icon to mute the tab, at which point the
icon is replaced with a muted speaker icon.

We would previously hide the icon when audio stopped playing. We now do
this only if the tab isn't muted. If it is muted, the muted speaker icon
remains on the tab so that the page isn't stuck in a muted state.
This commit is contained in:
Timothy Flynn 2024-03-30 10:59:00 -04:00 committed by Andreas Kling
parent 0da5d5a0d0
commit 9e4ffbcf70
Notes: sideshowbarker 2024-07-17 00:23:42 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/9e4ffbcf70
Pull-request: https://github.com/SerenityOS/serenity/pull/23773
1 changed files with 39 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
Ladybird/AppKit/UI/Tab.mm
View file

@ -11,6 +11,7 @@
#include <LibGfx/ImageFormats/PNGWriter.h>
#include <LibGfx/ShareableBitmap.h>
#include <LibURL/URL.h>
#include <LibWebView/ViewImplementation.h>
#import <Application/ApplicationDelegate.h>
#import <UI/Inspector.h>
@ -179,6 +180,36 @@ static constexpr CGFloat const WINDOW_HEIGHT = 800;
[[self tab] setAttributedTitle:title_and_favicon];
}
- (void)togglePageMuteState:(id)button
{
auto& view = [[self web_view] view];
view.toggle_page_mute_state();
switch (view.audio_play_state()) {
case Web::HTML::AudioPlayState::Paused:
[[self tab] setAccessoryView:nil];
break;
case Web::HTML::AudioPlayState::Playing:
[button setImage:[self iconForPageMuteState]];
break;
}
}
- (NSImage*)iconForPageMuteState
{
auto& view = [[self web_view] view];
switch (view.page_mute_state()) {
case Web::HTML::MuteState::Muted:
return [NSImage imageNamed:NSImageNameTouchBarAudioOutputVolumeOffTemplate];
case Web::HTML::MuteState::Unmuted:
return [NSImage imageNamed:NSImageNameTouchBarAudioOutputVolumeHighTemplate];
}
VERIFY_NOT_REACHED();
}
- (void)onContentScroll:(NSNotification*)notification
{
[[self web_view] handleScroll];
@ -277,20 +308,19 @@ static constexpr CGFloat const WINDOW_HEIGHT = 800;
- (void)onAudioPlayStateChange:(Web::HTML::AudioPlayState)play_state
{
auto& view = [[self web_view] view];
switch (play_state) {
case Web::HTML::AudioPlayState::Paused:
[[self tab] setAccessoryView:nil];
if (view.page_mute_state() == Web::HTML::MuteState::Unmuted) {
[[self tab] setAccessoryView:nil];
}
break;
case Web::HTML::AudioPlayState::Playing:
auto* icon = [NSImage imageNamed:NSImageNameTouchBarAudioOutputVolumeHighTemplate];
auto* button = [NSButton buttonWithImage:icon target:nil action:nil];
// FIXME: Add a click handler to mute the tab.
NSButtonCell* cell = [button cell];
[cell setImageDimsWhenDisabled:NO];
[button setEnabled:NO];
auto* button = [NSButton buttonWithImage:[self iconForPageMuteState]
target:self
action:@selector(togglePageMuteState:)];
[[self tab] setAccessoryView:button];
break;
}