beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 16:21:29 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Remove clipper creation error check in sample_under_corners()

Browse source 
Before, this check was needed to prevent crashing when attempting to
allocate zero-size bitmap for sampled corners, which could have happened
if a corner had 0 radius in one axis.

Now, since SampleUnderCorners command is not emmited when radius is 0
in one axis, this check is no longer needed.
This commit is contained in:
Aliaksandr Kalenik 2024-05-26 15:28:59 +01:00 committed by Andreas Kling
parent 9be65e35b5
commit 9b65a2731b
Notes: sideshowbarker 2024-07-16 23:03:06 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/9b65a2731b
Pull-request: https://github.com/SerenityOS/serenity/pull/24453
1 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/Painting/CommandExecutorCPU.cpp
View file

@ -459,10 +459,6 @@ CommandResult CommandExecutorCPU::sample_under_corners(u32 id, CornerRadii const
m_corner_clippers.resize(id + 1);
auto clipper = BorderRadiusCornerClipper::create(corner_radii, border_rect.to_type<DevicePixels>(), corner_clip);
if (clipper.is_error()) {
m_corner_clippers[id] = nullptr;
return CommandResult::Continue;
}
m_corner_clippers[id] = clipper.release_value();
m_corner_clippers[id]->sample_under_corners(painter());
return CommandResult::Continue;
@ -470,9 +466,6 @@ CommandResult CommandExecutorCPU::sample_under_corners(u32 id, CornerRadii const
CommandResult CommandExecutorCPU::blit_corner_clipping(u32 id)
{
if (!m_corner_clippers[id])
return CommandResult::Continue;
m_corner_clippers[id]->blit_corner_clipping(painter());
m_corner_clippers[id] = nullptr;
return CommandResult::Continue;