beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 08:41:15 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

PDFViewer: Simplify user-facing error messages

Browse source 
We now show a simple, if less helpful, message to the user and print
the verbose error message to serial instead.
This commit is contained in:
Julian Offenhäuser 2022-11-10 22:42:44 +01:00 committed by Andreas Kling
parent e782d03f96
commit 9b1331a984
Notes: sideshowbarker 2024-07-17 04:19:58 +09:00 
Author: https://github.com/janso3
Commit: https://github.com/SerenityOS/serenity/commit/9b1331a984
Pull-request: https://github.com/SerenityOS/serenity/pull/16015
Reviewed-by: https://github.com/mattco98 ✅
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Userland/Applications/PDFViewer/PDFViewer.cpp
View file

@ -89,7 +89,8 @@ void PDFViewer::paint_event(GUI::PaintEvent& event)
return;
auto handle_error = [&](PDF::Error& error) {
GUI::MessageBox::show_error(nullptr, String::formatted("Failed to render page:\n{}", error.message()));
warnln("{}", error.message());
GUI::MessageBox::show_error(nullptr, "Failed to render the page."sv);
m_document.clear();
};

3
Userland/Applications/PDFViewer/PDFViewerWidget.cpp
View file

@ -176,7 +176,8 @@ void PDFViewerWidget::open_file(Core::File& file)
auto handle_error = [&]<typename T>(PDF::PDFErrorOr<T> maybe_error) {
if (maybe_error.is_error()) {
auto error = maybe_error.release_error();
GUI::MessageBox::show_error(nullptr, String::formatted("Couldn't load PDF {}:\n{}", file.filename(), error.message()));
warnln("{}", error.message());
GUI::MessageBox::show_error(nullptr, "Failed to load the document."sv);
return true;
}
return false;